Re: Adding regular expression support to CORS filter

2020-10-06 Thread Carsten Klein
Chris, On 9/28/20 02:40, Christopher Schultz wrote: Carsten, On 9/27/20 05:53, Carsten Klein wrote: Any comments on that? Is it worth preparing a PR? Regular expressions are fairly expensive. Yes, but my measurements of the HashSet-lookups were wrong, since hashValue() of a String gets ca

Re: Adding regular expression support to CORS filter

2020-09-27 Thread Christopher Schultz
Carsten, On 9/27/20 05:53, Carsten Klein wrote: > Any comments on that? Is it worth preparing a PR? Regular expressions are fairly expensive. If there is a way to build the code such that some subset of wildcards can be serviced without regex (and of course exact matches without using regex), th

Re: Adding regular expression support to CORS filter

2020-09-27 Thread Carsten Klein
Any comments on that? Is it worth preparing a PR?

Adding regular expression support to CORS filter

2020-09-21 Thread Carsten Klein
Hi there, I'd like to contribute a CORS filter enhancement, making it accept both wildcard-based and 'regular expression'-based expressions for its allowed origins list. I know this from a project based on Jetty, which has support for, at least, simple wildcard matching (*). Specifying multi