Re: Using a custom connector in Tomcat 5.5

2006-10-18 Thread Jacob Marcus

So may be there is another way of doing what I want. My original plan was to
override the createRequest method. The reason is, I want my own
implementation of the isSecure() method.

So my version of the createRequest method would be like,

   public Request createRequest() {

   Request request = new MyRequest(); //MyRequest extends from
org.apache.catalina.connector.Request
   request.setConnector(this);
   return (request);
   }

I can try to create MyRequest in a valve and use that in subsequent invokes.


However, does it sound like a good usecase for giving the classname
attribute back?

Thanks,
Jacob


On 10/17/06, Bill Barker [EMAIL PROTECTED] wrote:



Jacob Marcus [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
 Thanks for the replies.

 Using the protocol=my.Class does help me give my own implementation of
 the
 ProtocolHandler for the Connector.
 The className attribute would have helped me specify my own
implementation
 of the Connector itself.

 Removal of the className attribute means that I can no longer extend the
 Connector and override methods. :=(


In 5.5, I can't see any methods of the Connector that could be usefully
overridden (all it does is arrange for the ProtocolHandler and the Adapter
to talk to each other).  I'd probably be -1 to putting back className.
CoyoteAdapter doesn't do all that much either, but I'd be +0 to adding an
AdapterClassName attribute to the Connector.  I can't see where there
would
be a use case however.

 Thanks,
 Jacob




 On 10/17/06, Peter Rossbach [EMAIL PROTECTED] wrote:

 HI Mladen,

 good way! But sometimes the changes are inside the Adapter Class and
 then you must change the connector class.

 +1 to have the attribute className back

 Peter




 Am 17.10.2006 um 09:36 schrieb Mladen Turk:

  Jacob Marcus wrote:
  Hi,
  The examples no longer show the className attribute for the
Connector
  element in the server.xml. Is this not supported any more?
  In the past, I have done used my own connector as shown in the
  example
  below.
  Connector port=8080 maxHttpHeaderSize=8192 className=
  com.hello.MyConnector
maxThreads=150 minSpareThreads=25
  maxSpareThreads=75
enableLookups=false redirectPort=8443
  acceptCount=100
connectionTimeout=2
  disableUploadTimeout=true /
  I could not find the relevant documentation on this possible
  change. I will
  appreciate any pointers.
 
  Use the protocol=com.hello.MyConnector instead className,
  or you can use protocolHandlerClassName.
 
  Regards,
  Mladen.
 
  -
  To start a new topic, e-mail: users@tomcat.apache.org
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 








-
To start a new topic, e-mail: users@tomcat.apache.org
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Using a custom connector in Tomcat 5.5

2006-10-17 Thread Peter Rossbach

HI Mladen,

good way! But sometimes the changes are inside the Adapter Class and  
then you must change the connector class.


+1 to have the attribute className back

Peter




Am 17.10.2006 um 09:36 schrieb Mladen Turk:


Jacob Marcus wrote:

Hi,
The examples no longer show the className attribute for the Connector
element in the server.xml. Is this not supported any more?
In the past, I have done used my own connector as shown in the  
example

below.
Connector port=8080 maxHttpHeaderSize=8192 className=
com.hello.MyConnector
  maxThreads=150 minSpareThreads=25  
maxSpareThreads=75
  enableLookups=false redirectPort=8443  
acceptCount=100
  connectionTimeout=2  
disableUploadTimeout=true /
I could not find the relevant documentation on this possible  
change. I will

appreciate any pointers.


Use the protocol=com.hello.MyConnector instead className,
or you can use protocolHandlerClassName.

Regards,
Mladen.

-
To start a new topic, e-mail: users@tomcat.apache.org
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






Re: Using a custom connector in Tomcat 5.5

2006-10-17 Thread Jacob Marcus

Thanks for the replies.

Using the protocol=my.Class does help me give my own implementation of the
ProtocolHandler for the Connector.
The className attribute would have helped me specify my own implementation
of the Connector itself.

Removal of the className attribute means that I can no longer extend the
Connector and override methods. :=(

Thanks,
Jacob




On 10/17/06, Peter Rossbach [EMAIL PROTECTED] wrote:


HI Mladen,

good way! But sometimes the changes are inside the Adapter Class and
then you must change the connector class.

+1 to have the attribute className back

Peter




Am 17.10.2006 um 09:36 schrieb Mladen Turk:

 Jacob Marcus wrote:
 Hi,
 The examples no longer show the className attribute for the Connector
 element in the server.xml. Is this not supported any more?
 In the past, I have done used my own connector as shown in the
 example
 below.
 Connector port=8080 maxHttpHeaderSize=8192 className=
 com.hello.MyConnector
   maxThreads=150 minSpareThreads=25
 maxSpareThreads=75
   enableLookups=false redirectPort=8443
 acceptCount=100
   connectionTimeout=2
 disableUploadTimeout=true /
 I could not find the relevant documentation on this possible
 change. I will
 appreciate any pointers.

 Use the protocol=com.hello.MyConnector instead className,
 or you can use protocolHandlerClassName.

 Regards,
 Mladen.

 -
 To start a new topic, e-mail: users@tomcat.apache.org
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]







Re: Using a custom connector in Tomcat 5.5

2006-10-17 Thread Bill Barker

Jacob Marcus [EMAIL PROTECTED] wrote in message 
news:[EMAIL PROTECTED]
 Thanks for the replies.

 Using the protocol=my.Class does help me give my own implementation of 
 the
 ProtocolHandler for the Connector.
 The className attribute would have helped me specify my own implementation
 of the Connector itself.

 Removal of the className attribute means that I can no longer extend the
 Connector and override methods. :=(


In 5.5, I can't see any methods of the Connector that could be usefully 
overridden (all it does is arrange for the ProtocolHandler and the Adapter 
to talk to each other).  I'd probably be -1 to putting back className. 
CoyoteAdapter doesn't do all that much either, but I'd be +0 to adding an 
AdapterClassName attribute to the Connector.  I can't see where there would 
be a use case however.

 Thanks,
 Jacob




 On 10/17/06, Peter Rossbach [EMAIL PROTECTED] wrote:

 HI Mladen,

 good way! But sometimes the changes are inside the Adapter Class and
 then you must change the connector class.

 +1 to have the attribute className back

 Peter




 Am 17.10.2006 um 09:36 schrieb Mladen Turk:

  Jacob Marcus wrote:
  Hi,
  The examples no longer show the className attribute for the Connector
  element in the server.xml. Is this not supported any more?
  In the past, I have done used my own connector as shown in the
  example
  below.
  Connector port=8080 maxHttpHeaderSize=8192 className=
  com.hello.MyConnector
maxThreads=150 minSpareThreads=25
  maxSpareThreads=75
enableLookups=false redirectPort=8443
  acceptCount=100
connectionTimeout=2
  disableUploadTimeout=true /
  I could not find the relevant documentation on this possible
  change. I will
  appreciate any pointers.
 
  Use the protocol=com.hello.MyConnector instead className,
  or you can use protocolHandlerClassName.
 
  Regards,
  Mladen.
 
  -
  To start a new topic, e-mail: users@tomcat.apache.org
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 



 




-
To start a new topic, e-mail: users@tomcat.apache.org
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]