Re: Embedded TomEE 7.0.4 and Arquillian and TLS

2018-06-18 Thread Mark Struberg 
 will apply.
LieGrue,strub

On Monday, 18 June 2018, 16:35:44 CEST, Romain Manni-Bucau 
 wrote:  
 
 Looks good to me (if anyone wants to apply it otherwise I'll do it end of
the week)

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 18 juin 2018 à 16:02, Gurkan Erdogdu  a écrit :

> Also added test patch.
>
> On Mon, Jun 18, 2018 at 4:45 PM, Romain Manni-Bucau  >
> wrote:
>
> > Misses a test (but looks good) and surely something to fix in
> > https://github.com/apache/tomee/blob/master/tomee/tomee-
> > embedded/src/test/java/org/apache/tomee/embedded/SslTomEETest.java
> > since it should have tested it
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github  > rmannibucau> |
> > LinkedIn  | Book
> >  > ee-8-high-performance>
> >
> >
> > Le lun. 18 juin 2018 à 15:39, Gurkan Erdogdu  a
> > écrit :
> >
> > > Also added patch :)
> > >
> > > On Mon, Jun 18, 2018 at 4:37 PM, Gurkan Erdogdu 
> > > wrote:
> > >
> > > > Hello
> > > > I created the issue https://issues.apache.org/jira/browse/TOMEE-2196
> > > > Best
> > > > Gurkan
> > > >
> > > > On Mon, Jun 18, 2018 at 4:29 PM, Romain Manni-Bucau <
> > > rmannibu...@gmail.com
> > > > > wrote:
> > > >
> > > >> Hi Fabian,
> > > >>
> > > >> there is a bug for keystorefile, the property name is empty (
> > > >> https://github.com/apache/tomee/blob/fb_tomee8/tomee/tomee-
> > > >> embedded/src/main/java/org/apache/tomee/embedded/
> > Container.java#L632),
> > > >> feel free to submit a PR fixing that
> > > >>
> > > >> Romain Manni-Bucau
> > > >> @rmannibucau  |  Blog
> > > >>  | Old Blog
> > > >>  | Github <
> > > >> https://github.com/rmannibucau> |
> > > >> LinkedIn  | Book
> > > >>  > > >> high-performance>
> > > >>
> > > >>
> > > >> Le lun. 18 juin 2018 à 14:55, 
> a
> > > >> écrit :
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> >
> > > >> >
> > > >> > I am migrating to TomEE 7.0.4 and our old TLS config in
> > arquillian.xml
> > > >> is
> > > >> > not working any longer, the property
> > > >> >
> > > >> >
> > > >> >
> > > >> > property name="keystoreFile"
> > > >> >
> > > >> >
> > > >> >
> > > >> > seems to be ignored completely now, and ~/.keystore used instead.
> > What
> > > >> is
> > > >> > the replacement? Where do I find documentation on arquillian.xml
> > which
> > > >> is
> > > >> > up to date for the TomEE embedded driver?
> > > >> >
> > > >> >
> > > >> >
> > > >> > Thanks in advance and best
> > > >> >
> > > >> > Fabian
> > > >> >
> > > >> >
> > > >> >
> > > >> >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>

Re: Embedded TomEE 7.0.4 and Arquillian and TLS

2018-06-18 Thread Romain Manni-Bucau 
Looks good to me (if anyone wants to apply it otherwise I'll do it end of
the week)

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 18 juin 2018 à 16:02, Gurkan Erdogdu  a écrit :

> Also added test patch.
>
> On Mon, Jun 18, 2018 at 4:45 PM, Romain Manni-Bucau  >
> wrote:
>
> > Misses a test (but looks good) and surely something to fix in
> > https://github.com/apache/tomee/blob/master/tomee/tomee-
> > embedded/src/test/java/org/apache/tomee/embedded/SslTomEETest.java
> > since it should have tested it
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github  > rmannibucau> |
> > LinkedIn  | Book
> >  > ee-8-high-performance>
> >
> >
> > Le lun. 18 juin 2018 à 15:39, Gurkan Erdogdu  a
> > écrit :
> >
> > > Also added patch :)
> > >
> > > On Mon, Jun 18, 2018 at 4:37 PM, Gurkan Erdogdu 
> > > wrote:
> > >
> > > > Hello
> > > > I created the issue https://issues.apache.org/jira/browse/TOMEE-2196
> > > > Best
> > > > Gurkan
> > > >
> > > > On Mon, Jun 18, 2018 at 4:29 PM, Romain Manni-Bucau <
> > > rmannibu...@gmail.com
> > > > > wrote:
> > > >
> > > >> Hi Fabian,
> > > >>
> > > >> there is a bug for keystorefile, the property name is empty (
> > > >> https://github.com/apache/tomee/blob/fb_tomee8/tomee/tomee-
> > > >> embedded/src/main/java/org/apache/tomee/embedded/
> > Container.java#L632),
> > > >> feel free to submit a PR fixing that
> > > >>
> > > >> Romain Manni-Bucau
> > > >> @rmannibucau  |  Blog
> > > >>  | Old Blog
> > > >>  | Github <
> > > >> https://github.com/rmannibucau> |
> > > >> LinkedIn  | Book
> > > >>  > > >> high-performance>
> > > >>
> > > >>
> > > >> Le lun. 18 juin 2018 à 14:55, 
> a
> > > >> écrit :
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> >
> > > >> >
> > > >> > I am migrating to TomEE 7.0.4 and our old TLS config in
> > arquillian.xml
> > > >> is
> > > >> > not working any longer, the property
> > > >> >
> > > >> >
> > > >> >
> > > >> > property name="keystoreFile"
> > > >> >
> > > >> >
> > > >> >
> > > >> > seems to be ignored completely now, and ~/.keystore used instead.
> > What
> > > >> is
> > > >> > the replacement? Where do I find documentation on arquillian.xml
> > which
> > > >> is
> > > >> > up to date for the TomEE embedded driver?
> > > >> >
> > > >> >
> > > >> >
> > > >> > Thanks in advance and best
> > > >> >
> > > >> > Fabian
> > > >> >
> > > >> >
> > > >> >
> > > >> >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>

Re: Embedded TomEE 7.0.4 and Arquillian and TLS

2018-06-18 Thread Gurkan Erdogdu 
Also added test patch.

On Mon, Jun 18, 2018 at 4:45 PM, Romain Manni-Bucau 
wrote:

> Misses a test (but looks good) and surely something to fix in
> https://github.com/apache/tomee/blob/master/tomee/tomee-
> embedded/src/test/java/org/apache/tomee/embedded/SslTomEETest.java
> since it should have tested it
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  rmannibucau> |
> LinkedIn  | Book
>  ee-8-high-performance>
>
>
> Le lun. 18 juin 2018 à 15:39, Gurkan Erdogdu  a
> écrit :
>
> > Also added patch :)
> >
> > On Mon, Jun 18, 2018 at 4:37 PM, Gurkan Erdogdu 
> > wrote:
> >
> > > Hello
> > > I created the issue https://issues.apache.org/jira/browse/TOMEE-2196
> > > Best
> > > Gurkan
> > >
> > > On Mon, Jun 18, 2018 at 4:29 PM, Romain Manni-Bucau <
> > rmannibu...@gmail.com
> > > > wrote:
> > >
> > >> Hi Fabian,
> > >>
> > >> there is a bug for keystorefile, the property name is empty (
> > >> https://github.com/apache/tomee/blob/fb_tomee8/tomee/tomee-
> > >> embedded/src/main/java/org/apache/tomee/embedded/
> Container.java#L632),
> > >> feel free to submit a PR fixing that
> > >>
> > >> Romain Manni-Bucau
> > >> @rmannibucau  |  Blog
> > >>  | Old Blog
> > >>  | Github <
> > >> https://github.com/rmannibucau> |
> > >> LinkedIn  | Book
> > >>  > >> high-performance>
> > >>
> > >>
> > >> Le lun. 18 juin 2018 à 14:55,  a
> > >> écrit :
> > >>
> > >> > Hi,
> > >> >
> > >> >
> > >> >
> > >> > I am migrating to TomEE 7.0.4 and our old TLS config in
> arquillian.xml
> > >> is
> > >> > not working any longer, the property
> > >> >
> > >> >
> > >> >
> > >> > property name="keystoreFile"
> > >> >
> > >> >
> > >> >
> > >> > seems to be ignored completely now, and ~/.keystore used instead.
> What
> > >> is
> > >> > the replacement? Where do I find documentation on arquillian.xml
> which
> > >> is
> > >> > up to date for the TomEE embedded driver?
> > >> >
> > >> >
> > >> >
> > >> > Thanks in advance and best
> > >> >
> > >> > Fabian
> > >> >
> > >> >
> > >> >
> > >> >
> > >> >
> > >>
> > >
> > >
> >
>

Re: Embedded TomEE 7.0.4 and Arquillian and TLS

2018-06-18 Thread Gurkan Erdogdu 
Also added patch :)

On Mon, Jun 18, 2018 at 4:37 PM, Gurkan Erdogdu  wrote:

> Hello
> I created the issue https://issues.apache.org/jira/browse/TOMEE-2196
> Best
> Gurkan
>
> On Mon, Jun 18, 2018 at 4:29 PM, Romain Manni-Bucau  > wrote:
>
>> Hi Fabian,
>>
>> there is a bug for keystorefile, the property name is empty (
>> https://github.com/apache/tomee/blob/fb_tomee8/tomee/tomee-
>> embedded/src/main/java/org/apache/tomee/embedded/Container.java#L632),
>> feel free to submit a PR fixing that
>>
>> Romain Manni-Bucau
>> @rmannibucau  |  Blog
>>  | Old Blog
>>  | Github <
>> https://github.com/rmannibucau> |
>> LinkedIn  | Book
>> > high-performance>
>>
>>
>> Le lun. 18 juin 2018 à 14:55,  a
>> écrit :
>>
>> > Hi,
>> >
>> >
>> >
>> > I am migrating to TomEE 7.0.4 and our old TLS config in arquillian.xml
>> is
>> > not working any longer, the property
>> >
>> >
>> >
>> > property name="keystoreFile"
>> >
>> >
>> >
>> > seems to be ignored completely now, and ~/.keystore used instead. What
>> is
>> > the replacement? Where do I find documentation on arquillian.xml which
>> is
>> > up to date for the TomEE embedded driver?
>> >
>> >
>> >
>> > Thanks in advance and best
>> >
>> > Fabian
>> >
>> >
>> >
>> >
>> >
>>
>
>

Re: Embedded TomEE 7.0.4 and Arquillian and TLS

2018-06-18 Thread Gurkan Erdogdu 
Hello
I created the issue https://issues.apache.org/jira/browse/TOMEE-2196
Best
Gurkan

On Mon, Jun 18, 2018 at 4:29 PM, Romain Manni-Bucau 
wrote:

> Hi Fabian,
>
> there is a bug for keystorefile, the property name is empty (
> https://github.com/apache/tomee/blob/fb_tomee8/tomee/
> tomee-embedded/src/main/java/org/apache/tomee/embedded/Container.java#L632
> ),
> feel free to submit a PR fixing that
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  rmannibucau> |
> LinkedIn  | Book
>  ee-8-high-performance>
>
>
> Le lun. 18 juin 2018 à 14:55,  a
> écrit :
>
> > Hi,
> >
> >
> >
> > I am migrating to TomEE 7.0.4 and our old TLS config in arquillian.xml is
> > not working any longer, the property
> >
> >
> >
> > property name="keystoreFile"
> >
> >
> >
> > seems to be ignored completely now, and ~/.keystore used instead. What is
> > the replacement? Where do I find documentation on arquillian.xml which is
> > up to date for the TomEE embedded driver?
> >
> >
> >
> > Thanks in advance and best
> >
> > Fabian
> >
> >
> >
> >
> >
>

Re: Embedded TomEE 7.0.4 and Arquillian and TLS

2018-06-18 Thread Romain Manni-Bucau 
Hi Fabian,

there is a bug for keystorefile, the property name is empty (
https://github.com/apache/tomee/blob/fb_tomee8/tomee/tomee-embedded/src/main/java/org/apache/tomee/embedded/Container.java#L632),
feel free to submit a PR fixing that

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 18 juin 2018 à 14:55,  a écrit :

> Hi,
>
>
>
> I am migrating to TomEE 7.0.4 and our old TLS config in arquillian.xml is
> not working any longer, the property
>
>
>
> property name="keystoreFile"
>
>
>
> seems to be ignored completely now, and ~/.keystore used instead. What is
> the replacement? Where do I find documentation on arquillian.xml which is
> up to date for the TomEE embedded driver?
>
>
>
> Thanks in advance and best
>
> Fabian
>
>
>
>
>

Embedded TomEE 7.0.4 and Arquillian and TLS

2018-06-18 Thread fabian-a . richter 
Hi,



I am migrating to TomEE 7.0.4 and our old TLS config in arquillian.xml is not 
working any longer, the property



property name="keystoreFile"



seems to be ignored completely now, and ~/.keystore used instead. What is the 
replacement? Where do I find documentation on arquillian.xml which is up to 
date for the TomEE embedded driver?



Thanks in advance and best

Fabian







smime.p7s
Description: S/MIME Cryptographic Signature