Re: Image based on external url model object

Hi Tobias, Thanks again, I will try to test this tonight... Best regards, Sebastien. On Tue, Nov 24, 2015 at 6:28 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Here they are: > > > https://github.com/klopfdreh/wicket-components-playground/wiki/19.-ExternalImage > > To

Re: Image based on external url model object

Here they are: https://github.com/klopfdreh/wicket-components-playground/wiki/19.-ExternalImage To test only copy them into your classpath and it would be nice to give me some feedback. kind regards Tobias P.S.: If they fit the requirements I'm going to create a PR. Am 24.11.15 um 14:59

Re: Image based on external url model object

Will try to check the code this week On Tue, Nov 24, 2015 at 11:30 PM, Sebastien wrote: > Hi Tobias, > > Thanks again, I will try to test this tonight... > > Best regards, > Sebastien. > > > > On Tue, Nov 24, 2015 at 6:28 PM, Tobias Soloschenko < >

Re: Image based on external url model object

Pre 6.x the model is not used, too. kind regards Tobias > Am 24.11.2015 um 14:59 schrieb Sebastien : > > "new Image(String, IModel)" does not work with external urls and do > not support compound model :) > > > On Tue, Nov 24, 2015 at 2:29 PM, Martin Grigorov

Re: Image based on external url model object

I just looked into the Image impl. - the issue here is that the image resource automatically creates a resource reference if only the model is provided. It would be bad to change this behavior. Anyway I am going to upload the two new components and may you can try / review it. kind regards

Re: Image based on external url model object

Hi, Just to make it a little bit confusing: have you considered "new Image("id", new UrlResourceReference("...")) ? Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Nov 24, 2015 at 1:43 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > I

Re: Image based on external url model object

I am pretty sure "new Image(String, IModel)" was for such use case. Looking at the code in 6.x+ I don't see how it could work though. So it is either my mistake that it ever worked, or it has been broken at some point. I just want to avoid having more than one way to do the same thing. This will

Re: Image based on external url model object

Good point - mhh but the issue here is that the information are not stored within the model Sebastien and Maxim wanted it to be - or am I wrong? kind regards Tobias > Am 24.11.2015 um 14:11 schrieb Martin Grigorov : > > Hi, > > Just to make it a little bit confusing:

Re: Image based on external url model object

The default model is not used anywhere - even before the responsive image refactoring - in my first suggestion I wanted to improve Image that the model is read and set as src if no reference is given - in addition to that I wanted to add a constructor to also support srcset (also in the source

Re: Image based on external url model object

I finished it, yesterday. Going to push it this evening. (First to my repo and create a pull request) kind regards Tobias > Am 24.11.2015 um 03:31 schrieb Maxim Solodovnik : > > Also thanks from me :) > >> On Mon, Nov 23, 2015 at 9:17 PM, Sebastien

Re: Image based on external url model object

Hi Martin, Yes, but UrlResourceReference does not work with/like a [compound]model... Thanks & best regards, Sebastien. On Tue, Nov 24, 2015 at 2:11 PM, Martin Grigorov wrote: > Hi, > > Just to make it a little bit confusing: have you considered "new > Image("id", new

Re: Image based on external url model object

"new Image(String, IModel)" does not work with external urls and do not support compound model :) On Tue, Nov 24, 2015 at 2:29 PM, Martin Grigorov wrote: > I am pretty sure "new Image(String, IModel)" was for such use case. > Looking at the code in 6.x+ I don't see how it