Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-16 Thread Thomas Heigl
Hi Martin, If the next release is not too far away, I'd rather wait. I'm already pushing a milestone to production and don't want to copy large chunks of code to my project as well ;) Best regards, Thomas On Thu, Apr 16, 2020 at 1:33 PM Martin Grigorov wrote: > Hi Thomas, > > On Thu, Apr

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-16 Thread Martin Grigorov
Hi Thomas, On Thu, Apr 16, 2020 at 1:41 PM Thomas Heigl wrote: > Thanks Sven! > > I think the solution is good enough for now. > > Would it be possible to do a 9.0.0-M5.1 release for this? If so, I would > give it another try on production. > It would be easier to copy the class temporarily in

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-16 Thread Thomas Heigl
Thanks Sven! I think the solution is good enough for now. Would it be possible to do a 9.0.0-M5.1 release for this? If so, I would give it another try on production. Best regards, Thomas On Wed, Apr 15, 2020 at 11:57 PM Sven Meier wrote: > Hi Thomas, > > I've pushed a change for >

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-15 Thread Sven Meier
Hi Thomas, I've pushed a change for https://issues.apache.org/jira/browse/WICKET-6769 to master. I'm not sure about the API right now, but it allows you to easily use any other map implementation. Caffeine's Cache#asMap() should work fine with here, although I didn't test it myself.

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-12 Thread Thomas Heigl
Hi Sven, I was thinking about this as well. SoftReferences worked well in my application. G1GC seems to start to evict them when -XX:InitiatingHeapOccupancyPercent is reached. In my case, when the heap is around 60% full. But as you said, there is no real control over which references are

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-12 Thread Sven Meier
Hi Thomas, I've did a little research on using SoftReferences for caches: https://stackoverflow.com/questions/264582/is-there-a-softhashmap-in-java http://jeremymanson.blogspot.com/2009/07/how-hotspot-decides-to-clear_07.html The experts seem to agree that depending on the GC to clean up your

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-12 Thread Thomas Heigl
Hi Sven, That's good to hear! Please let me know when you have an implementation and I'll give it another go. Best regards, Thomas On Sat, Apr 11, 2020 at 11:01 PM Sven Meier wrote: > Hi Thomas, > > actually not bad news at all (for Wicket 9 at least). > > The old page manager implementation

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-11 Thread Sven Meier
Hi Thomas, actually not bad news at all (for Wicket 9 at least). The old page manager implementation had so many special concepts and solutions, it's easy to miss one. A soft reference feature can easily be added/restored. I'm already checking where it fits best. Thanks for your thorough

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-11 Thread Thomas Heigl
Hi all, Bad news. My application was caught in a GC loop after running for 8 hours. The old generation was exhausted. I couldn't get a heap dump at that time but restarted the application, took a heap dump after about an hour, and reverted back to Wicket 8. The problem is this: The heap was

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-10 Thread Martin Grigorov
On Fri, Apr 10, 2020 at 4:01 PM Thomas Heigl wrote: > FYI: I deployed Wicket 9.0.0-M5 to production an hour ago. 100k requests > served and no issues so far. > Awesome! Thank you for testing it! > > Great work! > > Thomas > > On Wed, Apr 8, 2020 at 3:13 PM Sven Meier wrote: > > > Many thanks

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-10 Thread Thomas Heigl
FYI: I deployed Wicket 9.0.0-M5 to production an hour ago. 100k requests served and no issues so far. Great work! Thomas On Wed, Apr 8, 2020 at 3:13 PM Sven Meier wrote: > Many thanks Maxim! > > Sven > > On 08.04.20 14:29, Maxim Solodovnik wrote: > > Released :) > > > > On Wed, 8 Apr 2020 at

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-08 Thread Sven Meier
Many thanks Maxim! Sven On 08.04.20 14:29, Maxim Solodovnik wrote: Released :) On Wed, 8 Apr 2020 at 15:41, Maxim Solodovnik wrote: OK Will start new release process in couple of hours Please stop me if you will find any blocker :) On Wed, 8 Apr 2020 at 14:36, Thomas Heigl wrote: Hi

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-08 Thread Maxim Solodovnik
Released :) On Wed, 8 Apr 2020 at 15:41, Maxim Solodovnik wrote: > > OK > > Will start new release process in couple of hours > Please stop me if you will find any blocker :) > > On Wed, 8 Apr 2020 at 14:36, Thomas Heigl wrote: >> >> Hi Maxim, >> >> It works for me now! >> >> Thomas >> >> On

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-08 Thread Maxim Solodovnik
OK Will start new release process in couple of hours Please stop me if you will find any blocker :) On Wed, 8 Apr 2020 at 14:36, Thomas Heigl wrote: > Hi Maxim, > > It works for me now! > > Thomas > > On Wed, Apr 8, 2020 at 9:17 AM Maxim Solodovnik > wrote: > > > Thanks a million! > > > > On

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-08 Thread Thomas Heigl
Hi Maxim, It works for me now! Thomas On Wed, Apr 8, 2020 at 9:17 AM Maxim Solodovnik wrote: > Thanks a million! > > On Wed, 8 Apr 2020 at 14:10, Thomas Heigl wrote: > > > > Hi Maxim, > > > > I'm testing against the snapshot now. Will get back to you shortly. > > > > Thomas > > > > On Wed,

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-08 Thread Maxim Solodovnik
Thanks a million! On Wed, 8 Apr 2020 at 14:10, Thomas Heigl wrote: > > Hi Maxim, > > I'm testing against the snapshot now. Will get back to you shortly. > > Thomas > > On Wed, Apr 8, 2020 at 2:53 AM Maxim Solodovnik > wrote: > > > Hello All, > > > > M5 seems to be broken (deploy has failed more

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-08 Thread Thomas Heigl
Hi Maxim, I'm testing against the snapshot now. Will get back to you shortly. Thomas On Wed, Apr 8, 2020 at 2:53 AM Maxim Solodovnik wrote: > Hello All, > > M5 seems to be broken (deploy has failed more than 10 times during my > build attempts) > I have to start another release > Could you

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Maxim Solodovnik
Hello All, M5 seems to be broken (deploy has failed more than 10 times during my build attempts) I have to start another release Could you please tell when can I start? On Wed, 8 Apr 2020 at 07:01, Maxim Solodovnik wrote: > > Hello Thomas, > > Please test M6-SNAPSHOT (so I don't have to release

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Maxim Solodovnik
Hello Thomas, Please test M6-SNAPSHOT (so I don't have to release M5.2 : On Wed, 8 Apr 2020 at 02:39, Thomas Heigl wrote: > > Hi Maxim, > > That would be great. I want to do some more extensive testing and then > deploy M5 into production. ;) > > Thomas > > On Tue, Apr 7, 2020 at 7:50 PM

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Thomas Heigl
Hi Maxim, That would be great. I want to do some more extensive testing and then deploy M5 into production. ;) Thomas On Tue, Apr 7, 2020 at 7:50 PM Maxim Solodovnik wrote: > I can pack another release > later this week ... > > On Wed, 8 Apr 2020 at 00:48, Thomas Heigl wrote: > > > > Thanks

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Maxim Solodovnik
I can pack another release later this week ... On Wed, 8 Apr 2020 at 00:48, Thomas Heigl wrote: > > Thanks Sven! > > Did your changes make it into the release? Or did they just miss it? > > Thomas > > On Tue, Apr 7, 2020 at 7:43 PM Sven Meier wrote: > > > Hi Thomas, > > > > yes, you're right: >

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Thomas Heigl
Thanks Sven! Did your changes make it into the release? Or did they just miss it? Thomas On Tue, Apr 7, 2020 at 7:43 PM Sven Meier wrote: > Hi Thomas, > > yes, you're right: > > wicketstuff data stores missed some adjustments to the latest updates in > wicket-core. > > And

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Sven Meier
Hi Thomas, yes, you're right: wicketstuff data stores missed some adjustments to the latest updates in wicket-core. And SessionQuotaManagingDataStore$DelegatedPage must be serializable of course. I've pushed changes to wicketstuff master. Thanks Sven On 07.04.20 14:14, Thomas Heigl

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Thomas Heigl
And one more thing. There is now a warning logged just before serialization: WARN o.a.w.pageStore.AsynchronousPageStore: Delegated page store > 'org.apache.wicket.pageStore.SerializingPageStore' can not be asynchronous On Tue, Apr 7, 2020 at 2:09 PM Thomas Heigl wrote: > The cause is the

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Thomas Heigl
The cause is the following MetaData entry in the session: class > org.wicketstuff.datastores.common.SessionQuotaManagingDataStore$1=org.wicketstuff.datastores.common.SessionQuotaManagingDataStore$SizeLimitedData@4090594a On Tue, Apr 7, 2020 at 1:59 PM Thomas Heigl wrote: > Hi Sven, > > I just

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-04-07 Thread Thomas Heigl
Hi Sven, I just found time to give this a try with Wicket 9.0.0-M5. There seem to be issues with serialization now. My new config: protected IPageStore newCachingStore(IPageStore pageStore) { > return new CachingPageStore(pageStore, new InMemoryPageStore(getName(), >

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-03-28 Thread Thomas Heigl
Thanks Sven! That looks much better. I'll give it a try as soon as I can. Best regards, Thomas On Fri, Mar 27, 2020 at 2:23 PM Sven Meier wrote: > Hi Thomas, > > your question comes at the right time. > > I was able to improve the implementation with a new CachingPageStore: > > >

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-03-27 Thread Sven Meier
Hi Thomas, your question comes at the right time. I was able to improve the implementation with a new CachingPageStore: https://github.com/apache/wicket/blob/8df3528dc44a08b7d375c20e764a3664cd6a5f30/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java#L145 You can now

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-03-27 Thread Sven Meier
Hi Thomas, I thought I covered that usecase, but I will have to take a look. Thanks for testing Wicket 9 Sven On 25.03.20 20:10, Thomas Heigl wrote: Maybe the same approach could be used as for InSessionPageStore that can be used as cache and a store:

Re: Equivalent for PerSessionPageStore in Wicket 9

2020-03-25 Thread Thomas Heigl
Maybe the same approach could be used as for InSessionPageStore that can be used as cache and a store: https://github.com/apache/wicket/commit/894799e01227781be76886b2d1cdb2a424c812e0 On Wed, Mar 25, 2020 at 6:35 PM Thomas Heigl wrote: > Hi all, > > I just merged our master in our Wicket 9

Equivalent for PerSessionPageStore in Wicket 9

2020-03-25 Thread Thomas Heigl
Hi all, I just merged our master in our Wicket 9 branch and I ran into an issue: Our current configuration with Wicket 8 looks like this: PageStore = PerSessionPageStore DataStore = RedisDataStore So the page store keeps the last couple of pages of a session in memory and Redis is used as a