Re: FormTester, FinishButton and Wicket 8.0

2018-06-13 Thread Martin Grigorov
On Thu, Jun 14, 2018 at 8:40 AM Martin Grigorov wrote: > > > On Wed, Jun 13, 2018 at 7:59 PM Sven Meier wrote: > >> @Martin The result is garantueed to be non-null in these lines, how >> should ofNullable() make any difference? >> > > Right! Just checked that Class.isInstance(null) would return

Re: FormTester, FinishButton and Wicket 8.0

2018-06-13 Thread Martin Grigorov
On Wed, Jun 13, 2018 at 7:59 PM Sven Meier wrote: > @Martin The result is garantueed to be non-null in these lines, how should > ofNullable() make any difference? > Right! Just checked that Class.isInstance(null) would return false. The problem is in AjaxFallbackButton methods.

Re: FormTester, FinishButton and Wicket 8.0

2018-06-13 Thread Sven Meier
Hi, minor correction: If no an AjaxButton or AjaxSubmitLink, FormTester submits the button via a non-Ajax request. Thus no AjaxRequestTarget can be  found. Have fun Sven Am 13.06.2018 um 18:58 schrieb Sven Meier: @Martin The result is garantueed to be non-null in these lines, how should

Re: FormTester, FinishButton and Wicket 8.0

2018-06-13 Thread Sven Meier
@Martin The result is garantueed to be non-null in these lines, how should ofNullable() make any difference? @Francesco FormTester submits via Ajax request only in case of an AjaxButton or AjaxSubmitLink, which ist not the case with AjaxButtonBar. As fallback the whole form is submitted

Re: FormTester, FinishButton and Wicket 8.0

2018-06-13 Thread Martin Grigorov
I guess those two should really use Optional.ofNullable(): https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java#L886-L892 On Wed, Jun 13, 2018 at 2:33 PM Francesco Chicchiriccò wrote: > I have spent some time investigating this

Re: FormTester, FinishButton and Wicket 8.0

2018-06-13 Thread Francesco Chicchiriccò
I have spent some time investigating this issue, and I have finally found that the actual problem lies at https://github.com/apache/syncope/blob/SYNCOPE-1323/client/console/src/main/java/org/apache/syncope/client/console/wizards/AjaxWizard.java#L198 e.g.

Re: FormTester, FinishButton and Wicket 8.0

2018-06-11 Thread Francesco Chicchiriccò
On 2018/06/07 16:43:58, Sven Meier wrote: > Hi, > > I'm not able to run the test in Intellij nor in Eclipse: > > java.lang.NoSuchMethodError: > org.junit.platform.commons.util.ReflectionUtils.getDefaultClassLoader Thanks for reporting, it seems that the problem was due to an accidental

Re: FormTester, FinishButton and Wicket 8.0

2018-06-07 Thread Sven Meier
Hi, I'm not able to run the test in Intellij nor in Eclipse: java.lang.NoSuchMethodError: org.junit.platform.commons.util.ReflectionUtils.getDefaultClassLoader I suspect your problem might be caused by WICKET-6541, but I don't see why the changes should fail during tests. Have fun Sven

Re: FormTester, FinishButton and Wicket 8.0

2018-06-06 Thread Sven Meier
I'll take a look. Have fun Sven Am 06.06.2018 um 17:16 schrieb Francesco Chicchiriccò: Hi all, I am migrating the Syncope master branch from Wicket 7 to 8. It seems all is working fine when dealing via browser, but the integration tests are mostly failing. As Syncope heavily uses Wizards,

FormTester, FinishButton and Wicket 8.0

2018-06-06 Thread Francesco Chicchiriccò
Hi all, I am migrating the Syncope master branch from Wicket 7 to 8. It seems all is working fine when dealing via browser, but the integration tests are mostly failing. As Syncope heavily uses Wizards, the reason seems that FormTester fails somehow to submit the Finish button (though no error