Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)

2013-12-06 Thread Martin Grigorov
I've backported ExactLevelFeedbackMessageFilter from master branch. It has been introduced for: WICKET-4585 WicketTester.assertErrorMessages passes even if the message isn't visible on the page WICKET-5128 Allow for Testing Component relative Feedback-Messages in Wicket-Tester No need of new

Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)

2013-12-06 Thread Paul Bors
We should still edit the JavaDoc for FeedbackMessages#hasMessage(int) and instruct to use ExactLevelFeedbackMessageFilter. Otherwise might get confused if the don't review the implementation. ~ Thank you, Paul Bors On Fri, Dec 6, 2013 at 4:11 AM, Martin Grigorov mgrigo...@apache.orgwrote:

Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)

2013-12-05 Thread Martin Grigorov
Hi, You are right. But I think we can only improve the javadoc. You will have to use org.apache.wicket.feedback.FeedbackMessages#hasMessage(org.apache.wicket.feedback.IFeedbackMessageFilter) with a filter that makes exact match. I have the feeling that we added such filter but I can only see

Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)

2013-12-05 Thread Paul Bors
Yes, we are using the .FeedbackMessages#hasMessage(IFeedbackMessageFilter) as we had no other choice. I'll file a ticket with a pull request now that I got used to GitHub :) ~ Thank you, Paul Bors On Thu, Dec 5, 2013 at 11:39 AM, Martin Grigorov mgrigo...@apache.orgwrote: Hi, You are