Re: error messages due to hack/search-bots

2008-12-22 Thread Pointbreak
Not an answer to your question, but why fight this kind of stuff? It's an invalid request, so it should result in an error. If you don't want these entries in your log, you could just add a filter to your logger (e.g. filtering out error messages from

Re: error messages due to hack/search-bots

2008-12-22 Thread Antoine van Wel
Hmm, actually you have a point. Errors we've caught until now where mis-constructed URLs for pages; those could be user errors too so we wanted to identify all places where it could break and present a good feedback message to the user. But in this particular case something/someone is clearly

Re: error messages due to hack/search-bots

2008-12-22 Thread Antoine van Wel
Hmm, actually you have a point. Errors we've caught until now where mis-constructed URLs for pages; those could be user errors too so we wanted to identify all places where it could break and present a good feedback message to the user. But in this particular case something/someone is clearly

Re: error messages due to hack/search-bots

2008-12-22 Thread Sebastiaan van Erk
Pointbreak wrote: Not an answer to your question, but why fight this kind of stuff? It's an invalid request, so it should result in an error. I actually prefer it would result in a 404 for the client and nothing more. Perhaps, when enabling DEBUG, it can log the message + exception it is

Re: error messages due to hack/search-bots

2008-12-22 Thread Jeremy Thomerson
A 404 is an error - so on the one hand you say it is an error, but on the other, you say it isn't. I think it should remain an error. Just my 0.02 though. On Mon, Dec 22, 2008 at 7:56 AM, Sebastiaan van Erk sebs...@sebster.comwrote: Pointbreak wrote: Not an answer to your question, but why

Re: error messages due to hack/search-bots

2008-12-22 Thread Michael Sparer
the thing is that 404 is a client error. I'd only log server errors (i.e. errors in the code) as Error. Of course a 404 can also happen due to a error in the code, but logging 404 as errors will flood your log file ... just my two cents Jeremy Thomerson-5 wrote: A 404 is an error - so on

Re: error messages due to hack/search-bots

2008-12-22 Thread Antoine van Wel
agree with Sebastiaan and Michael here when a user types a wrong url, you're not going to log that 404 - client error, file not found - no fixes necessary, so not logged 500 - server error - log it, needs to be fixed so instead of implementing the filter, I prefer waiting for a Wicket patch..

Re: error messages due to hack/search-bots

2008-12-22 Thread Sebastiaan van Erk
I created a JIRA issue (with trivial patch). https://issues.apache.org/jira/browse/WICKET-1991 Regards, Sebastiaan Antoine van Wel wrote: agree with Sebastiaan and Michael here when a user types a wrong url, you're not going to log that 404 - client error, file not found - no fixes