Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-22 Thread Dirk Germonpré
Hello Andrea, Thanks a lot for this fix. I have another question. The fix now delays the creation of the settings object inside the InPlaceEditComponent to the onInitialize() method. This means I can no longer configure the settings after creating the InPlaceEditComponent in my panel. Is it

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-22 Thread Martin Grigorov
Hi, You can override #onInitialize() and do what you need after calling super.onInitialize(). Martin Grigorov Wicket Training and Consulting On Tue, Apr 22, 2014 at 3:35 PM, Dirk Germonpré dirk.germon...@gmail.comwrote: Hello Andrea, Thanks a lot for this fix. I have another question.

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-22 Thread Dirk Germonpré
Hello, I understand. In that case, I still need a getter method for the settings object inside the TinyMceBehavior. Kind regards, Dirk. 2014-04-22 14:38 GMT+02:00 Martin Grigorov mgrigo...@apache.org: Hi, You can override #onInitialize() and do what you need after calling

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-22 Thread Dirk Germonpré
Hello, I think there is a problem with the fix. In TinyMceBehavior the method beforeRender was removed (in which a div was added), so I suppose the method afterRender should also be removed (in which the div is closed). Kind regards, Dirk. 2014-04-21 14:32 GMT+02:00 Andrea Del Bene

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-22 Thread Andrea Del Bene
Hi Dirk, I changed the code following your advices: https://github.com/wicketstuff/core/commit/d763815f6cc05d799df628e2c3cba61b9c6b1410 Hello, I think there is a problem with the fix. In TinyMceBehavior the method beforeRender was removed (in which a div was added), so I suppose the method

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-21 Thread Andrea Del Bene
Hello, I've worked to fix the issue. You can see the result here: https://github.com/wicketstuff/core/commit/ed9d3e52f4537c67c395a5e3bcb1dbb639158eb7 However, I don't think there is an easy workaround to apply to the current version. The good news is that Wicket 6.15.0 is around the conner

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-15 Thread Dirk Germonpré
Hello, Switching back to version 6.9.0 doesn't make a change. If I click the cancel button in the editor, it closes, but when I reopen it again, nothing works anymore. In what version should it be fixed? Is there a new JIRA issue? Kind regards, Dirk.

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-15 Thread Martin Grigorov
https://github.com/wicketstuff/core/commit/9fa1c25c113800ef9c55cdc4afbaacc3d6e3256a this is the fix Martin Grigorov Wicket Training and Consulting On Tue, Apr 15, 2014 at 11:00 AM, Dirk Germonpré dirk.germon...@gmail.comwrote: Hello, Switching back to version 6.9.0 doesn't make a change.

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-15 Thread Dirk Germonpré
Great! It does the trick. Thanks a lot! Kind regards, Dirk. 2014-04-15 10:03 GMT+02:00 Martin Grigorov mgrigo...@apache.org: https://github.com/wicketstuff/core/commit/9fa1c25c113800ef9c55cdc4afbaacc3d6e3256a this is the fix Martin Grigorov Wicket Training and Consulting On Tue, Apr

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-15 Thread Dirk Germonpré
Hello, The editor is now working fine in a normal page. But I also need the editor to work inside a modal window. In that case, the editor opens and seems to work fine, until I hit the save button. The save button does nothing, the editor stays open. Is this a known issue? I'm currently working

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-15 Thread Andrea Del Bene
No, it's not a known issue. I will try to investigate it in during the very next days. Hello, The editor is now working fine in a normal page. But I also need the editor to work inside a modal window. In that case, the editor opens and seems to work fine, until I hit the save button. The save

TinyMCE InPlaceEditComponent on Wicket 6

2014-04-14 Thread Dirk Germonpré
Hello, I'm working on a large web application. Parts of the application are still running on Wicket 1.4, but I'm in the process of migrating them to Wicket 6. We used the wicket.contrib.tinymce.InPlaceEditComponent for inline editing of large texts. This worked fine on Wicket 1.4, but there seem

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-14 Thread Martin Grigorov
Hi, Do you use wicketstuff-tinymce 6.14 as well ? http://central.maven.org/maven2/org/wicketstuff/wicketstuff-tinymce/6.14.0/ Martin Grigorov Wicket Training and Consulting On Mon, Apr 14, 2014 at 5:54 PM, Dirk Germonpré dirk.germon...@gmail.comwrote: Hello, I'm working on a large web

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-14 Thread Dirk Germonpré
Yes, I'm using version 6.14 of wicketstuff-tinymce. Dirk. 2014-04-14 16:59 GMT+02:00 Martin Grigorov mgrigo...@apache.org: Hi, Do you use wicketstuff-tinymce 6.14 as well ? http://central.maven.org/maven2/org/wicketstuff/wicketstuff-tinymce/6.14.0/ Martin Grigorov Wicket Training and

Re: TinyMCE InPlaceEditComponent on Wicket 6

2014-04-14 Thread Andrea Del Bene
It's a problem introduced with the workaround at https://issues.apache.org/jira/browse/WICKET-5248 and never removed. If you try working with version 6.9.0 (both Wicket and WicketStuff) you shouldn't have this problem. I'm committing a fix. Yes, I'm using version 6.14 of wicketstuff-tinymce.