Re: Fix for WICKET-3947 and WICKET-4700

[Veikko Törmänen]

>> I'm looking at the tests in the patch and I see things like:
>>
>> +
>> +   //assertEquals("InlineEnclosure has traversed page x
>> times ", new
>> Integer(1), new
>> Integer(InlineEnclosure.inlineEnclosureTraversalCounter));
>> +   // 
>> InlineEnclosure.CALCULATE_INLINE_ENCLOSURE_PERFORMANCE = false;
>> +
>>
>> Not happy!
>
> Ok, we'll fix that.

Fixed. 
I replaced previous patch with new one.

-Veikko



--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651701.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: Fix for WICKET-3947 and WICKET-4700

[Veikko Törmänen]

Thank you for the information.

I had missed the correct patch protocol and wasn't aware that the 1.4.x was
frozen.

Apologies.



--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Fix for WICKET-3947 and WICKET-4700

[Veikko Törmänen]

Hi!

I have a fix/patch for two wicket bugs:

https://issues.apache.org/jira/browse/WICKET-3947
https://issues.apache.org/jira/browse/WICKET-3947 

and

https://issues.apache.org/jira/browse/WICKET-4700
https://issues.apache.org/jira/browse/WICKET-4700 


This fix causes three of the junit tests to fail and I could use some help
on figuring them out.

First two are in "org.apache.wicket.markup.html.border.ComponentBorderTest"
where both of tests cause error.
I don't understand what these tests do so I've had problems on locating the
problem.

Third is in "org.apache.wicket.markup.html.internal.InlineEnclosureTest"
where testInlineEnclosurePage_1 causes error.
This test I understand but what I don't understand is why my patch causes
this error?

If someone could take a look of this patch and could help me locate my
problem I would appreciate it.

http://apache-wicket.1842946.n4.nabble.com/file/n4651386/Patch_for_WICKET-3947.zip
Patch_for_WICKET-3947.zip 

-Veikko



--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org