Re: wicket contrib yui
> > IMHO hardwiring is somehow an antipattern for me - maybe we could have a > "setYuiPath" in it that defaults to the delivered YUI but leaves the > possibility to have other YUI versions as well? > Well, its not really hardwired, its just a default fallback used by the static factory methods. Other factory methods exist to provide choice for these attributes. But while you are in there adapting it to 2.3.0, by all means feel free to make whatever adjustments you want. You might even want to start with a clean slate, since the work YuiHeaderContributor was set up to do has been made redundant with the addition of the dynamic loader. best, jim - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: wicket contrib yui
Hi Jim,
> Yes, my understanding is that 2.3.0 will return most of
> YuiHeaderContributor back to the compost pile. Do you think you will
> be able to do this? Let me know if you have questions.
I'll have a look on this, but this will not be before the weekend however.
> Not sure. A few people have worked on the project and no naming
> convention was ever established. It is a good idea to enforce one,
> though. You should enter an issue in wicketstuff.org so it won't be
> forgotten.
http://wicketstuff.org/jira/browse/WSYUI-2
> Right, you either need to change the default version in the
> HeaderContributor, or change the components you want to use to call
> the above method.
IMHO hardwiring is somehow an antipattern for me - maybe we could have a
"setYuiPath" in it that defaults to the delivered YUI but leaves the
possibility to have other YUI versions as well?
Regards
Korbinian
James McLaughlin schrieb:
On 8/28/07, Korbinian Bachl <[EMAIL PROTECTED]> wrote:
Hi James,
i checked out of svn today and changed yui to 2.3.0 - at first, all
seemed ok, but when looking closer its a bit irritating.
No doubt. Exactly why I have procrastinated on this for the past month.
In 2.2 you seem to have to attach much JS files to the header, while in
2.3.0 1 (the loader) is enough (as far as I understood it).
This means, the big YuiHeaderContributor could shrink to some few lines.
In a short dirty test where i just replaced the
static final String DEFAULT_YUI_BUILD = "2.3.0";
all seemed quite ok - but the real big work would be to add the new
yui-content to the contrib.
Yes, my understanding is that 2.3.0 will return most of
YuiHeaderContributor back to the compost pile. Do you think you will
be able to do this? Let me know if you have questions.
BTW: i find the naming very confusing - is there a reason not all
classes have a "Yui" in front of them? (so you can see them faster as
calling it e.g.: SortBox or Slider)
Not sure. A few people have worked on the project and no naming
convention was ever established. It is a good idea to enforce one,
though. You should enter an issue in wicketstuff.org so it won't be
forgotten.
the include of "YuiHeaderContributor.forModule("menu", null, false,
"2.3.0")" at page level however doesnt work as the components call it by
themselfes, meaning if you add it to page, it will load 2.3 and 2.2.
Right, you either need to change the default version in the
HeaderContributor, or change the components you want to use to call
the above method.
best,
jim
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: wicket contrib yui
On 8/28/07, Korbinian Bachl <[EMAIL PROTECTED]> wrote:
> Hi James,
>
> i checked out of svn today and changed yui to 2.3.0 - at first, all
> seemed ok, but when looking closer its a bit irritating.
No doubt. Exactly why I have procrastinated on this for the past month.
>
> In 2.2 you seem to have to attach much JS files to the header, while in
> 2.3.0 1 (the loader) is enough (as far as I understood it).
>
> This means, the big YuiHeaderContributor could shrink to some few lines.
> In a short dirty test where i just replaced the
> static final String DEFAULT_YUI_BUILD = "2.3.0";
> all seemed quite ok - but the real big work would be to add the new
> yui-content to the contrib.
Yes, my understanding is that 2.3.0 will return most of
YuiHeaderContributor back to the compost pile. Do you think you will
be able to do this? Let me know if you have questions.
>
> BTW: i find the naming very confusing - is there a reason not all
> classes have a "Yui" in front of them? (so you can see them faster as
> calling it e.g.: SortBox or Slider)
Not sure. A few people have worked on the project and no naming
convention was ever established. It is a good idea to enforce one,
though. You should enter an issue in wicketstuff.org so it won't be
forgotten.
>
> the include of "YuiHeaderContributor.forModule("menu", null, false,
> "2.3.0")" at page level however doesnt work as the components call it by
> themselfes, meaning if you add it to page, it will load 2.3 and 2.2.
Right, you either need to change the default version in the
HeaderContributor, or change the components you want to use to call
the above method.
best,
jim
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: wicket contrib yui
> Also note that we did something similar in wicket-datetime. Maybe, in > some future, it would be great to have all the YUI components > together. For now, we could look whether the projects can at least be > used together without having them bite. A thread of two weeks ago > discussed this. The conclusion was that we probably would like > something like a separate YUI project with all the js dependencies in > it, so that projects using them can access it in a consistent fashion. > If someone is up to it, please dig up that discussion and create a > feature request linking to that discussion (nabble). > > Eelco Done: https://issues.apache.org/jira/browse/WICKET-902, with some minor blathering by yours truly. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: wicket contrib yui
Hi James,
i checked out of svn today and changed yui to 2.3.0 - at first, all
seemed ok, but when looking closer its a bit irritating.
In 2.2 you seem to have to attach much JS files to the header, while in
2.3.0 1 (the loader) is enough (as far as I understood it).
This means, the big YuiHeaderContributor could shrink to some few lines.
In a short dirty test where i just replaced the
static final String DEFAULT_YUI_BUILD = "2.3.0";
all seemed quite ok - but the real big work would be to add the new
yui-content to the contrib.
BTW: i find the naming very confusing - is there a reason not all
classes have a "Yui" in front of them? (so you can see them faster as
calling it e.g.: SortBox or Slider)
the include of "YuiHeaderContributor.forModule("menu", null, false,
"2.3.0")" at page level however doesnt work as the components call it by
themselfes, meaning if you add it to page, it will load 2.3 and 2.2.
Best Regards,
Korbinian
PS: most time today i spent on fighting with maven - anyone an idea how
i can have a maven-project as "Library" in a normal project under
Netbeans 5.5.1 ?
James McLaughlin schrieb:
Yes there is. I haven't had much time to see what the impact of the
change would be, but I set up YuiHeaderContributor to be able to
select versions. If you have the time and inclination, you can setup
the 2.3.0 library under org/wicketstuff/yui/inc, and include the
library with something like this:
YuiHeaderContributor.forModule("menu", null, false, "2.3.0")
then let us know what works and what doesn't. Ultimately, the
yuiloader in 2.3.0 will eliminate most of the work that
YuiHeaderContributer does (resolving deps), so if you want to take a
stab at porting it the headercontributor to yuiloader, that would be
great too.
best,
jim
On 8/27/07, Korbinian Bachl <[EMAIL PROTECTED]> wrote:
Hi,
i stumbled over yui some time ago, and noticed that there is also a
wicket-contrib-yui project. However, the version under
https://wicket-stuff.svn.sourceforge.net/svnroot/wicket-stuff/trunk/wicket-contrib-yui/
seem to rely on 2.2.0.
Are there any plans for a 2.3.0 or sth. like that?
Best Regards,
Korbinian
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: wicket contrib yui
On 8/27/07, James McLaughlin <[EMAIL PROTECTED]> wrote:
> Yes there is. I haven't had much time to see what the impact of the
> change would be, but I set up YuiHeaderContributor to be able to
> select versions. If you have the time and inclination, you can setup
> the 2.3.0 library under org/wicketstuff/yui/inc, and include the
> library with something like this:
>
> YuiHeaderContributor.forModule("menu", null, false, "2.3.0")
>
> then let us know what works and what doesn't. Ultimately, the
> yuiloader in 2.3.0 will eliminate most of the work that
> YuiHeaderContributer does (resolving deps), so if you want to take a
> stab at porting it the headercontributor to yuiloader, that would be
> great too.
Also note that we did something similar in wicket-datetime. Maybe, in
some future, it would be great to have all the YUI components
together. For now, we could look whether the projects can at least be
used together without having them bite. A thread of two weeks ago
discussed this. The conclusion was that we probably would like
something like a separate YUI project with all the js dependencies in
it, so that projects using them can access it in a consistent fashion.
If someone is up to it, please dig up that discussion and create a
feature request linking to that discussion (nabble).
Eelco
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: wicket contrib yui
Yes there is. I haven't had much time to see what the impact of the
change would be, but I set up YuiHeaderContributor to be able to
select versions. If you have the time and inclination, you can setup
the 2.3.0 library under org/wicketstuff/yui/inc, and include the
library with something like this:
YuiHeaderContributor.forModule("menu", null, false, "2.3.0")
then let us know what works and what doesn't. Ultimately, the
yuiloader in 2.3.0 will eliminate most of the work that
YuiHeaderContributer does (resolving deps), so if you want to take a
stab at porting it the headercontributor to yuiloader, that would be
great too.
best,
jim
On 8/27/07, Korbinian Bachl <[EMAIL PROTECTED]> wrote:
> Hi,
>
> i stumbled over yui some time ago, and noticed that there is also a
> wicket-contrib-yui project. However, the version under
> https://wicket-stuff.svn.sourceforge.net/svnroot/wicket-stuff/trunk/wicket-contrib-yui/
> seem to rely on 2.2.0.
>
> Are there any plans for a 2.3.0 or sth. like that?
>
> Best Regards,
>
> Korbinian
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
wicket contrib yui
Hi, i stumbled over yui some time ago, and noticed that there is also a wicket-contrib-yui project. However, the version under https://wicket-stuff.svn.sourceforge.net/svnroot/wicket-stuff/trunk/wicket-contrib-yui/ seem to rely on 2.2.0. Are there any plans for a 2.3.0 or sth. like that? Best Regards, Korbinian - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
