Bug modal.js when wicket in production mode / setStripJavascriptCommentsAndWhitespace(true)

2009-02-09 Thread Antoine Angenieux 

Hi all,

I can't tell you from which version it started, but in wicket-1.3 (as 
from the latest version on SVN), as soon as I do a 
setStripJavascriptCommentsAndWhitespace(true) or set the wicket mode to 
production, I get javascript errors in modal.js : (line 64 / 65 of the 
received javascript)


e.clientX = evt.clientX + Wicket.Iframe.findPosX(iframe) - dx;
e.clientY = evt.clientY + Wicket.Iframe.findPosY(iframe) - dy; 
doc.onmousemove(e); } idoc.old_onmouseup = idoc.old_onmousemove;

idoc.onmouseup = function(evt) {

Both IE (67) and firefox (1.5+,2+) complain about the } right before 
idoc.old_onmouseoup =...


Did anyone else encounter this ? Should I oppen a JIRA ticket ?

Thanks in advance,

Cheers,

Antoine.

PS: I did not have enough time to check if the behavior was the same in 
1.4 trunk.


--
Antoine Angénieux
Associé

Clinigrid
5, avenue Mozart
75016 Paris, France
+336 60 21 09 18
aangeni...@clinigrid.com



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: Bug modal.js when wicket in production mode / setStripJavascriptCommentsAndWhitespace(true)

2009-02-09 Thread Matej Knopp 
Hi,

thanks for the report. Should be fixed in SVN.

-Matej

On Mon, Feb 9, 2009 at 5:35 PM, Antoine Angenieux
aangeni...@clinigrid.com wrote:
 Hi all,

 I can't tell you from which version it started, but in wicket-1.3 (as from
 the latest version on SVN), as soon as I do a
 setStripJavascriptCommentsAndWhitespace(true) or set the wicket mode to
 production, I get javascript errors in modal.js : (line 64 / 65 of the
 received javascript)

 e.clientX = evt.clientX + Wicket.Iframe.findPosX(iframe) - dx;
 e.clientY = evt.clientY + Wicket.Iframe.findPosY(iframe) - dy;
 doc.onmousemove(e); } idoc.old_onmouseup = idoc.old_onmousemove;
 idoc.onmouseup = function(evt) {

 Both IE (67) and firefox (1.5+,2+) complain about the } right before
 idoc.old_onmouseoup =...

 Did anyone else encounter this ? Should I oppen a JIRA ticket ?

 Thanks in advance,

 Cheers,

 Antoine.

 PS: I did not have enough time to check if the behavior was the same in 1.4
 trunk.

 --
 Antoine Angénieux
 Associé

 Clinigrid
 5, avenue Mozart
 75016 Paris, France
 +336 60 21 09 18
 aangeni...@clinigrid.com



 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: Bug modal.js when wicket in production mode / setStripJavascriptCommentsAndWhitespace(true)

2009-02-09 Thread Antoine Angenieux 

Fantastic Matej, you're the man ;)

Cheers,

Antoine.

Matej Knopp wrote:

Hi,

thanks for the report. Should be fixed in SVN.

-Matej

On Mon, Feb 9, 2009 at 5:35 PM, Antoine Angenieux
aangeni...@clinigrid.com wrote:

Hi all,

I can't tell you from which version it started, but in wicket-1.3 (as from
the latest version on SVN), as soon as I do a
setStripJavascriptCommentsAndWhitespace(true) or set the wicket mode to
production, I get javascript errors in modal.js : (line 64 / 65 of the
received javascript)

e.clientX = evt.clientX + Wicket.Iframe.findPosX(iframe) - dx;
e.clientY = evt.clientY + Wicket.Iframe.findPosY(iframe) - dy;
doc.onmousemove(e); } idoc.old_onmouseup = idoc.old_onmousemove;
idoc.onmouseup = function(evt) {

Both IE (67) and firefox (1.5+,2+) complain about the } right before
idoc.old_onmouseoup =...

Did anyone else encounter this ? Should I oppen a JIRA ticket ?

Thanks in advance,

Cheers,

Antoine.

PS: I did not have enough time to check if the behavior was the same in 1.4
trunk.

--
Antoine Angénieux
Associé

Clinigrid
5, avenue Mozart
75016 Paris, France
+336 60 21 09 18
aangeni...@clinigrid.com



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org




-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org




--
Antoine Angénieux
Associé

Clinigrid
5, avenue Mozart
75016 Paris, France
+336 60 21 09 18
aangeni...@clinigrid.com



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org