Re: ChainingModel warnings in Wicket 8

2018-06-10 Thread Thomas Heigl
Hi Maxim, Created https://issues.apache.org/jira/browse/WICKET-6560. Thomas On Sat, Jun 9, 2018 at 5:44 AM, Maxim Solodovnik wrote: > Sounds like these 2 comments worth JIRA > Or Jira+PR ;)) > > On Thu, Jun 7, 2018 at 9:45 PM, Thomas Heigl wrote: > > Also the warning is logged for `null` obje

Re: ChainingModel warnings in Wicket 8

2018-06-08 Thread Maxim Solodovnik
Sounds like these 2 comments worth JIRA Or Jira+PR ;)) On Thu, Jun 7, 2018 at 9:45 PM, Thomas Heigl wrote: > Also the warning is logged for `null` objects, which probably shouldn't > happen. > > public ChainingModel(final Object modelObject) >> { >> if (modelObject instanceof Session) >>

Re: ChainingModel warnings in Wicket 8

2018-06-07 Thread Thomas Heigl
Also the warning is logged for `null` objects, which probably shouldn't happen. public ChainingModel(final Object modelObject) > { > if (modelObject instanceof Session) > { > LOG.warn("It is not a good idea to reference the ."); > } else if (modelObject instanceof Seria

ChainingModel warnings in Wicket 8

2018-06-07 Thread Thomas Heigl
Hi all, After porting our app to Wicket 8, I'm getting these warnings on my test environment: WAR o.a.w.model.ChainingModel It is not a good idea to reference a > non-serializable instance in models directly as it may lead to > serialization problems The warning is OK, but it gives me absolutel