RE: ModalWindow.setResizable(false) no longer works in 1.4-rc5?
I provided a patch that fixes the issue. cheers Marcin -- View this message in context: http://www.nabble.com/ModalWindow.setResizable%28false%29-no-longer-works-in-1.4-rc5--tp24135317p24210823.html Sent from the Wicket - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
RE: ModalWindow.setResizable(false) no longer works in 1.4-rc5?
I filled a JIRA for this: https://issues.apache.org/jira/browse/WICKET-2345 -- View this message in context: http://www.nabble.com/ModalWindow.setResizable%28false%29-no-longer-works-in-1.4-rc5--tp24135317p24210005.html Sent from the Wicket - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
RE: ModalWindow.setResizable(false) no longer works in 1.4-rc5?
I had problems with ModalWindow also when converting from 1.3.5 I was able to use a percentage in setInitialHeight and Width, which no longer worked (for me) - I had to switch to pixels. And yes, the window is resizable even though it is set to false. -Original Message- From: Marcin Palka [mailto:marcin.pa...@gmail.com] Sent: Sunday, June 21, 2009 4:27 PM To: users@wicket.apache.org Subject: Re: ModalWindow.setResizable(false) no longer works in 1.4-rc5? James, thanks for the reply. The problem turns out to be more complex. Simple page with a modal window works like a charm with RC5 (I mean I can easily set modal window's resizability). My application's modal windows on the other hand don't. I will try to investigate it further and fill a JIRA report if needed. So far I compared the markup generated by both, my problematic application and simple quickstart application and it seems that style attributes are missing in the app that experiences resizability problem. The style attributes that are missing are "cursor: default;" (as below). Fixed size modal window: Resizable (but supposed to be fixed size) modal window: I will dig into the ModalWindow's code to find out when these atributes are added and when they don't. And the code I use to construct and show a modal window: final ModalWindow modal = new ModalWindow("modal"); modal.setContent(new DummyPanel(modal.getContentId())); //DummyPanel contains only static text modal.setTitle("Modal window"); modal.setHeightUnit("px"); modal.setWidthUnit("px"); modal.setInitialHeight(100); modal.setInitialWidth(300); modal.setResizable(false); add(modal); AjaxFallbackLink showModal = new AjaxFallbackLink("show_modal") { @Override public void onClick(AjaxRequestTarget target) { modal.show(target); } }; add(showModal); Marcin James Carman-3 wrote: > > The 1.4 release is all about "genericizing" Wicket. If you've got a > regression like this, it's probably not supposed to be happening. I > would file a JIRA and attach a quickstart. > -- View this message in context: http://www.nabble.com/ModalWindow.setResizable%28false%29-no-longer-works-in-1.4-rc5--tp24135317p24138498.html Sent from the Wicket - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ EMAIL CONFIDENTIALITY NOTICE This Email message, and any attachments, may contain confidential patient health information that is legally protected. This information is intended only for the use of the individual or entity named above. The authorized recipient of this information is prohibited from disclosing this information to any other party unless required to do so by law or regulation and is required to destroy the information after its stated need has been fulfilled. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or action taken in reliance on the contents of this message is strictly prohibited. If you have received this information in error, please notify the sender immediately by replying to this message and delete the message from your system. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow.setResizable(false) no longer works in 1.4-rc5?
James, thanks for the reply. The problem turns out to be more complex. Simple page with a modal window works like a charm with RC5 (I mean I can easily set modal window's resizability). My application's modal windows on the other hand don't. I will try to investigate it further and fill a JIRA report if needed. So far I compared the markup generated by both, my problematic application and simple quickstart application and it seems that style attributes are missing in the app that experiences resizability problem. The style attributes that are missing are "cursor: default;" (as below). Fixed size modal window: Resizable (but supposed to be fixed size) modal window: I will dig into the ModalWindow's code to find out when these atributes are added and when they don't. And the code I use to construct and show a modal window: final ModalWindow modal = new ModalWindow("modal"); modal.setContent(new DummyPanel(modal.getContentId())); //DummyPanel contains only static text modal.setTitle("Modal window"); modal.setHeightUnit("px"); modal.setWidthUnit("px"); modal.setInitialHeight(100); modal.setInitialWidth(300); modal.setResizable(false); add(modal); AjaxFallbackLink showModal = new AjaxFallbackLink("show_modal") { @Override public void onClick(AjaxRequestTarget target) { modal.show(target); } }; add(showModal); Marcin James Carman-3 wrote: > > The 1.4 release is all about "genericizing" Wicket. If you've got a > regression like this, it's probably not supposed to be happening. I > would file a JIRA and attach a quickstart. > -- View this message in context: http://www.nabble.com/ModalWindow.setResizable%28false%29-no-longer-works-in-1.4-rc5--tp24135317p24138498.html Sent from the Wicket - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow.setResizable(false) no longer works in 1.4-rc5?
The 1.4 release is all about "genericizing" Wicket. If you've got a regression like this, it's probably not supposed to be happening. I would file a JIRA and attach a quickstart. On Sun, Jun 21, 2009 at 11:21 AM, Marcin Palka wrote: > Hi, > > I migrated my application from 1.4-rc1 to 1.4-rc5 and noticed that the > ModalWindow's setResizable(false) method no longer works. All the > modal dialogs in my application became resizable. Was there any change > introduced in this area in the RC5 or is this a regular bug? > > cheers, > Marcin > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
ModalWindow.setResizable(false) no longer works in 1.4-rc5?
Hi, I migrated my application from 1.4-rc1 to 1.4-rc5 and noticed that the ModalWindow's setResizable(false) method no longer works. All the modal dialogs in my application became resizable. Was there any change introduced in this area in the RC5 or is this a regular bug? cheers, Marcin - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org