Re: Always calling getXxx() and hideXxx() both decreases performance of application (?)

2018-02-17 Thread Dan Haywood
ok, raised https://issues.apache.org/jira/browse/ISIS-1864 On Sat, 17 Feb 2018 at 15:24 Dan Haywood wrote: > Hi Erik, > > Yes, I'm not sure myself what the impact would be. > > I think that the parent EntityModel shouldnt' really have this > responsibility of

Re: Always calling getXxx() and hideXxx() both decreases performance of application (?)

2018-02-17 Thread Dan Haywood
Hi Erik, Yes, I'm not sure myself what the impact would be. I think that the parent EntityModel shouldnt' really have this responsibility of telling each of its child ScalarModel's to reset themselves. Rather, perhaps it should simply instruct the ScalarModels that they are now dirty, so that

Re: Always calling getXxx() and hideXxx() both decreases performance of application (?)

2018-02-16 Thread Erik de Hair
Hi Dan, We have the same issues on [1] when executing an action. I can create a pull request and add equal code as for the fix on [2] but I can't foresee what a possible impact might be. Thanks, Erik [1]

Re: Always calling getXxx() and hideXxx() both decreases performance of application (?)

2018-02-12 Thread Dan Haywood
Hi Erik, Mistake on my part. I've brought the ticket back for fix in 1.16.1, and added a comment to the ticket itself. thx Dan On Mon, 12 Feb 2018 at 11:48 Erik de Hair wrote: > Hi Dan, > > As far as I can see the fix [1] for ISIS-1759 [2] is not merged to > current

Re: Always calling getXxx() and hideXxx() both decreases performance of application (?)

2018-02-12 Thread Erik de Hair
Hi Dan, As far as I can see the fix [1] for ISIS-1759 [2] is not merged to current release of Apache Isis [3] [1] https://gitbox.apache.org/repos/asf?p=isis.git;a=commitdiff;h=c6c2fc7 [2] https://issues.apache.org/jira/browse/ISIS-1759 [3]

Re: Always calling getXxx() and hideXxx() both decreases performance of application (?)

2017-10-25 Thread Dan Haywood
Raised https://issues.apache.org/jira/browse/ISIS-1759 for this On Sun, 1 Oct 2017 at 19:52 Dan Haywood wrote: > Hi Erik, > I'll look into this... This doesn't sound right that this version is > creating these extra calls into the domain code. > Thx, > Dan > > On

Re: Always calling getXxx() and hideXxx() both decreases performance of application (?)

2017-10-01 Thread Dan Haywood
Hi Erik, I'll look into this... This doesn't sound right that this version is creating these extra calls into the domain code. Thx, Dan On Wed, 27 Sep 2017, 11:35 Erik de Hair, wrote: > Hi, > > I'm not really sure about this but it feels like our app's performance > (Apache