[ovirt-users] Re: Can't remove snapshot

2021-06-04 Thread Strahil Nikolov via Users
Hm... The description is absolutely clear.
Maybe we can put it in the documentation.
Best Regards,Strahil Nikolov
 
 
  On Thu, Jun 3, 2021 at 22:51, David Johnson 
wrote:   ___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/G5NUSE46BFRENYQ7CWFSOLYN7GETP6LF/
  
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/OQXJQDCMC5QYSGIX4IRHTF6EVDRAZHBR/


[ovirt-users] Re: Can't remove snapshot

2021-06-03 Thread David Johnson
Thanks!

On Thu, Jun 3, 2021, 2:46 PM Nir Soffer  wrote:

> On Thu, Jun 3, 2021 at 8:47 PM Strahil Nikolov 
> wrote:
> >
> > Hey Nir,
> >
> > you said that the data in the snapshot changed ?
> > I always thought that snapshots are read-only.
>
> Indeed snapshot is ready only - until you start to delete it. This is
> why we mark the
> snapshot as illegal once delete snapshot was started.
>
> It works like this:
>
> 1. Before snapshot
>
> Snapshots: (none)
> Volumes: A (active)
>
> A is read-write volume, changing while the vm is running.
>
> 2. After snapshot
>
> Snapshot: snap1 (disk snapshot A)
> Volumes: A <- B (active)
>
> A is now read only image, will never change
> B is read-write, modified by the vm
> B backing file is A
>
> 2. Start delete snapshot 1
>
> Snapshot: snap1 (disk snapshot A, illegal)
> Volumes: A <- B (active)
>
> On the host running the vm, we perform block commit job,
> copying data from B into A.
>
> When the job completes, A contains all data in B, and any new
> data written to the B is mirrored to A.
>
> 3. Pivoting to volume A
>
> When the block commit has completed, we switch to vm to use volume A
> instead of volume B.
>
> At this point the VM is writing again to volume A, and volume B is unused.
>
> Snapshot: snap1 (disk snapshot A, illegal)
> Volumes: A (active) <- B
>
> 4. Cleanup
>
> On engine side, snapshot 1 is deleted
> On the host, volume B is deactivated
> On the SPM host, volume B is deleted
>
> Snapshot: (none)
> Volumes: A (active)
>
> I hope this is more clear now.
>
> Nir
>
>
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/G5NUSE46BFRENYQ7CWFSOLYN7GETP6LF/


[ovirt-users] Re: Can't remove snapshot

2021-06-03 Thread Nir Soffer
On Thu, Jun 3, 2021 at 8:47 PM Strahil Nikolov  wrote:
>
> Hey Nir,
>
> you said that the data in the snapshot changed ?
> I always thought that snapshots are read-only.

Indeed snapshot is ready only - until you start to delete it. This is
why we mark the
snapshot as illegal once delete snapshot was started.

It works like this:

1. Before snapshot

Snapshots: (none)
Volumes: A (active)

A is read-write volume, changing while the vm is running.

2. After snapshot

Snapshot: snap1 (disk snapshot A)
Volumes: A <- B (active)

A is now read only image, will never change
B is read-write, modified by the vm
B backing file is A

2. Start delete snapshot 1

Snapshot: snap1 (disk snapshot A, illegal)
Volumes: A <- B (active)

On the host running the vm, we perform block commit job,
copying data from B into A.

When the job completes, A contains all data in B, and any new
data written to the B is mirrored to A.

3. Pivoting to volume A

When the block commit has completed, we switch to vm to use volume A
instead of volume B.

At this point the VM is writing again to volume A, and volume B is unused.

Snapshot: snap1 (disk snapshot A, illegal)
Volumes: A (active) <- B

4. Cleanup

On engine side, snapshot 1 is deleted
On the host, volume B is deactivated
On the SPM host, volume B is deleted

Snapshot: (none)
Volumes: A (active)

I hope this is more clear now.

Nir
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/7XX74LQ7IYYQCCUSEIMV35TPFRIP4NDD/


[ovirt-users] Re: Can't remove snapshot

2021-06-03 Thread David Johnson
If you check roman's update, there is a known bug in the engine. The
snapshot was successfully deleted, but the engine database is out of sync.

On Thu, Jun 3, 2021, 12:46 PM Strahil Nikolov  wrote:

> Hey Nir,
>
> you said that the data in the snapshot changed ?
> I always thought that snapshots are read-only.
>
> How is that possible?
>
> Best Regards,
> Strahil Nikolov
>
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/XFLDX3P5EGNCT34JHF6F7RU3T6KAR6LR/


[ovirt-users] Re: Can't remove snapshot

2021-06-03 Thread Strahil Nikolov via Users
Hey Nir,
you said that the data in the snapshot changed ?I always thought that snapshots 
are read-only.
How is that possible?
Best Regards,Strahil Nikolov___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/FVGGEPKAYXXYUNGT3OYDPTJBJTZSFJ4C/


[ovirt-users] Re: Can't remove snapshot

2021-06-03 Thread Nir Soffer
On Fri, May 28, 2021 at 7:09 PM David Johnson 
wrote:

> Hi all,
>
> I patched one of my Windows VM's yesterday.  I started by snapshotting the
> VM, then applied the Windows update.  Now that the patch has been tested, I
> want to remove the snapshot. I get this message:
>
> Error while executing action:
>
> win-sql-2019:
>
>- Cannot remove Snapshot. The following attached disks are in ILLEGAL
>status: win-2019-tmpl_Disk1 - please remove them and try again.
>
>
> Does anyone have any thoughts how to recover from this? I really don't
> want to keep this snapshot hanging around.
>

The engine ILLEGAL state means that you started a delete snapshot operation,
and the data in this snapshot has changed. This snapshot cannot be used for
restoring the vm state to the state as it was when the snapshot was created.

In this situation you can retry the delete snapshot operation again. If the
first
delete failed because of a temporary error the operation should succeed and
the snapshot will be deleted.

Nir
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/PY5G5XXAYK53O5ZC3E2BPMVE77LDVIBW/