Re: Failing locale dependent tests in wicket-core

2016-03-30 Thread Tobias Soloschenko
Nice! Thanks Martin! kind regards Tobias Am 30.03.16 um 16:32 schrieb Martin Grigorov: Fixed it! Thanks! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 3:59 PM, Martin Grigorov wrote: I've pasted the same output

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Thorsten Schöning
Guten Tag Thorsten Schöning, am Mittwoch, 30. März 2016 um 14:16 schrieben Sie: > "mvn --version" should provide all requested info: No change even with a more current version of Maven: > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-10T17:41:47+01:00) > Maven home:

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Thorsten Schöning
Guten Tag Martin Grigorov, am Mittwoch, 30. März 2016 um 12:42 schrieben Sie: > The tests pass successfully here and at the CI server. > Which version of JDK and Maven do you use? What is the system locale ? "mvn --version" should provide all requested info: > Apache Maven 3.1.1

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Martin Grigorov
Hi, The tests pass successfully here and at the CI server. Which version of JDK and Maven do you use? What is the system locale ? Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 12:05 PM, Thorsten Schöning wrote: >

Re: Test with IMarkupResourceStreamProvider and using IMarkupResourceStreamProvider for input

2016-03-30 Thread Martin Grigorov
Hi, On Wed, Mar 30, 2016 at 11:08 AM, andre seame wrote: > Hello, > > 1°) According the advices of this mailing list, I try to use > IMarkupResourceStreamProvider as described in > > https://ci.apache.org/projects/wicket/guide/7.x/guide/single.html#advanced_5 > > When

Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Thorsten Schöning
Hi all, I try to build 7.3.0.0-SNAPSHOT from source, but there's at least the following failing test. Skipping the tests builds OK and the results seem to work, but that shouldn't be necessary, right? [...] > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.398 sec - > in

Test with IMarkupResourceStreamProvider and using IMarkupResourceStreamProvider for input

2016-03-30 Thread andre seame
Hello, 1°) According the advices of this mailing list, I try to use IMarkupResourceStreamProvider as described in https://ci.apache.org/projects/wicket/guide/7.x/guide/single.html#advanced_5 When using something like: public class AutoMarkupGenPanel extends Panel implements

Failing locale dependent tests in wicket-core

2016-03-30 Thread Thorsten Schöning
Hi, I'm building wicket 7.3.0.0 SNAPSHOT in Ubuntu 12.04 LTS and have the following failed tests: > Failed tests: > > MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115 > expected: but was: > >

Re: wicket 7 + cglib + asm: net.sf.cglib.core.CodeGenerationException

2016-03-30 Thread Martin Grigorov
Hi, The versions were "latest" at the time Wicket 7 was in development (ASM 5.0.x, CGLIB 3.1.x). The current latest of ASM and CGLIB are targeted for Java 8 (ASM 5.1.x, CGLIB 3.2.x). Both ASM and CGLIB do not follow semantic versioning and this leads to confusions like this one. The solution is

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Tobias Soloschenko
I also think that this are bugs of the tests. The specific test receive a different locale then the environment and so different resources are compared. You can see it in the Base64 encoded image test. kind regards Tobias > Am 30.03.2016 um 15:45 schrieb Martin Grigorov

Re: wicket 7 + cglib + asm: net.sf.cglib.core.CodeGenerationException

2016-03-30 Thread Marieke Vandamme
Hi, That's something I first tried, but other libraries we use (like org.apache.tika.tika-parsers) set version of asm or cglib. I also see that asm-util is used, but with version 5.0.3. Is there no standard dependencies I can use to solve this? I do not have to possibility to not set the version,

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Martin Grigorov
But wicket-spring passes even with de_DE. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 3:45 PM, Martin Grigorov wrote: > If I try to build Wicket 7.x with de_DE locale the build fails at > wicket-core: > > Failed

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Martin Grigorov
Please create a patch / Pull Request and a ticket. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 3:49 PM, Thorsten Schöning wrote: > Guten Tag Thorsten Schöning, > am Mittwoch, 30. März 2016 um 14:52

Re: Failing locale dependent tests in wicket-core

2016-03-30 Thread Martin Grigorov
I've pasted the same output in your other thread about the issue in the Spring related test. It is a bug in the tests. If a test expects to see _en in the result then it should make sure the session locale is EN. I build Wicket with bg_BG all the time but those tests do not fail in that case :-/

wicket 7 + cglib + asm: net.sf.cglib.core.CodeGenerationException

2016-03-30 Thread Marieke Vandamme
​Hi, I'm trying to use wicket 7.2.0 and saw in the migration guide ​that other libraries also changed to the latest stable version. So I also tried this, and the following are used by me now: - Spring Framework 4.2.5 - ASM 5.1 - CGLIB 3.2.1 I get the following stacktrace, on which I'm really

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Thorsten Schöning
Guten Tag Thorsten Schöning, am Mittwoch, 30. März 2016 um 14:52 schrieben Sie: > No change even with a more current version of Maven: I have the feeling that the error is non deterministic somehow, because yesterday after upgrading 7.3.0.0 I was so damn sure that the error didn't occur anymore,

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Martin Grigorov
If I try to build Wicket 7.x with de_DE locale the build fails at wicket-core: Failed tests: MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115 expected: but was:

Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT

2016-03-30 Thread Thorsten Schöning
Guten Tag Martin Grigorov, am Mittwoch, 30. März 2016 um 15:45 schrieben Sie: > If I try to build Wicket 7.x with de_DE locale the build fails at > wicket-core: Not on Windows BTW, I'm building on Ubuntu and Windows and the wicket-spring problem is currently only on Windows, while the

Re: Failing locale dependent tests in wicket-core

2016-03-30 Thread Martin Grigorov
Fixed it! Thanks! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 3:59 PM, Martin Grigorov wrote: > I've pasted the same output in your other thread about the issue in the > Spring related test. > > It is a bug in the

Re: wicket 7 + cglib + asm: net.sf.cglib.core.CodeGenerationException

2016-03-30 Thread Martin Grigorov
In that case try with CGLIB 3.2.0. I remember seeing NPE like this when I tried to upgrade Wicket 8.x to 3.2.1. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 4:20 PM, Marieke Vandamme wrote: > Hi, > > That's

Re: wicket 7 + cglib + asm: net.sf.cglib.core.CodeGenerationException

2016-03-30 Thread Marieke Vandamme
And which version of asm should I use? I now get another stacktrace: java.lang.ExceptionInInitializerError at org.apache.wicket.jmx.Initializer.createProxy(Initializer.java:256) at org.apache.wicket.jmx.Initializer.register(Initializer.java:249) at

Re: wicket 7 + cglib + asm: net.sf.cglib.core.CodeGenerationException

2016-03-30 Thread Rob Audenaerde
I have had some similar issue in the past (and finally decided to ditch spring :). IIRC, the maven-shade-plugin could be used to relocate packages of classes of dependencies. But it is kind of black magic :/ -Rob On Wed, Mar 30, 2016 at 4:20 PM, Marieke Vandamme

Re: wicket 7 + cglib + asm: net.sf.cglib.core.CodeGenerationException

2016-03-30 Thread Martin Grigorov
Latest 5.0.x for Java 7 and latest 5.1.x if you run on Java 8. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 4:43 PM, Marieke Vandamme wrote: > And which version of asm should I use? > I now get another