RE: [RFE] HeaderContributor.forFavicon(Reference)

2007-12-03 Thread William Hoover
done... http://issues.apache.org/jira/browse/WICKET-1203 -Original Message- From: Eelco Hillenius [mailto:[EMAIL PROTECTED] Sent: Friday, November 30, 2007 8:32 PM To: users@wicket.apache.org Subject: Re: [RFE] HeaderContributor.forFavicon(Reference) On Nov 30, 2007 4:29 AM, William

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-12-01 Thread Alex Objelean
farther down the dom tree to increase performance (http://developer.yahoo.com/performance/rules.html#js_bottom)? -Original Message- From: Johan Compagner [mailto:[EMAIL PROTECTED] Sent: Friday, November 30, 2007 2:35 AM To: users@wicket.apache.org Subject: Re: [RFE

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-30 Thread Eelco Hillenius
On Nov 30, 2007 4:29 AM, William Hoover [EMAIL PROTECTED] wrote: While your on the subject... shouldn't there be a forJavaScript that is external from the HeaderContributor that does a more intelligent insertion of the script farther down the dom tree to increase performance

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-30 Thread Igor Vaynberg
Compagner [mailto:[EMAIL PROTECTED] Sent: Friday, November 30, 2007 2:35 AM To: users@wicket.apache.org Subject: Re: [RFE] HeaderContributor.forFavicon(Reference) I dont think there is any thing magical at the headerresponse if you ask me. Do remeber that when doing header responses you have

RE: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-30 Thread William Hoover
Message- From: Johan Compagner [mailto:[EMAIL PROTECTED] Sent: Friday, November 30, 2007 2:35 AM To: users@wicket.apache.org Subject: Re: [RFE] HeaderContributor.forFavicon(Reference) I dont think there is any thing magical at the headerresponse if you ask me. Do remeber that when doing header

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-30 Thread Ryan Sonnek
See the Wicket FeedResource in wicketstuff for an example. I'm not saying it's perfect, but I *do* think it's a step in the right direction. https://wicket-stuff.svn.sourceforge.net/svnroot/wicket-stuff/trunk/wicketstuff-rome/src/main/java/org/wicketstuff/rome/FeedResource.java On Nov 30, 2007

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Matej Knopp
You can do this by directly using IHeaderResponse.renderString(). e.g. make a custom behavior that implements IHeaderContributor and call this from it's renderHead. I don't think we need this in HeaderContributor itself. But others might have different opinion. -Matej On Nov 29, 2007 11:08 AM,

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Alex Objelean
Also this can be done extending PackagedResourceReference, but this is not the point. I found myself copying the same code from one project to another, just because wicket core does not provide a common way to add favicons. I think, that since HeaderContributor has already: forCss

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Ryan Sonnek
-1 for this. I'm very much against the current static util pattern that the HeaderContributor object is headed. I would much rather have this behavior moved into the appropriate class (ex: JavascriptResource.headerContribution()) instead of bloating HeaderContributor. this is how i designed the

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Alex Objelean
That's nice idea. My opinion that any type of abstraction that helps a developer to write a simpler code is good. Alex Ryan Sonnek-2 wrote: -1 for this. I'm very much against the current static util pattern that the HeaderContributor object is headed. I would much rather have this

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Eelco Hillenius
I'm very much against the current static util pattern that the HeaderContributor object is headed. I would much rather have this behavior moved into the appropriate class (ex: JavascriptResource.headerContribution()) instead of bloating HeaderContributor. this is how i designed the wicket

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Ryan Sonnek
I don't quite understand this... Instead of having to know a ton of classes, you just have to know this one. I really struggled with wicket originally when trying to do these header contributions. I was using the IDE and searching for Javascript* or CSS* and nothing relevant came up. Instead, I

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Eelco Hillenius
On Nov 29, 2007 11:37 AM, Ryan Sonnek [EMAIL PROTECTED] wrote: I don't quite understand this... Instead of having to know a ton of classes, you just have to know this one. I really struggled with wicket originally when trying to do these header contributions. I was using the IDE and

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Ryan Sonnek
Understood. Just want to make it aware that the current pattern makes it impossible for other projects (wicketstuff) to add header contributions in the standard/supported way. When I created the FeedResource, it became painfully obvious that the current pattern should be changed for the sake of

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Eelco Hillenius
On Nov 29, 2007 12:15 PM, Ryan Sonnek [EMAIL PROTECTED] wrote: Understood. Just want to make it aware that the current pattern makes it impossible for other projects (wicketstuff) to add header contributions in the standard/supported way. When I created the FeedResource, it became painfully

Re: [RFE] HeaderContributor.forFavicon(Reference)

2007-11-29 Thread Alex Objelean
Could it be possible, until the 1.4 appears, to add forFavicon static utility method? Eelco Hillenius wrote: On Nov 29, 2007 12:15 PM, Ryan Sonnek [EMAIL PROTECTED] wrote: Understood. Just want to make it aware that the current pattern makes it impossible for other projects (wicketstuff)