Re: scriptaculous toaster

2008-06-11 Thread Nino Saturnino Martinez Vazquez Wael
Ryan Sonnek wrote: if we reach a point where there are several contributed scriptaculous components, i think it would make sense to create a wicketstuff-scriptaculous-sandbox project that can house them all. +1, if we get to that... the sync and queue methods should be moved off of the

Re: scriptaculous toaster

2008-06-10 Thread Nino Saturnino Martinez Vazquez Wael
Ok. But I think that we should be a little carefull splitting up in too many projects... But it's fine with me, so we should just move all the stuff from the fx package away from your project right? Since the other stuff(only the queue part though) I do need to be present or i'll have to build

Re: scriptaculous toaster

2008-06-10 Thread Ryan Sonnek
if we reach a point where there are several contributed scriptaculous components, i think it would make sense to create a wicketstuff-scriptaculous-sandbox project that can house them all. the sync and queue methods should be moved off of the core Effect interface and into the AbstractEffect

Re: scriptaculous toaster

2008-06-09 Thread Nino Saturnino Martinez Vazquez Wael
Sorry, something were messed up with my svn, so I think I might have overriden what you just commited(it stated that you just deleted files). But take a look at it and see if it's okay.. It turned out that I only need to add an option to set queue on effects... However I also added the

Re: scriptaculous toaster

2008-06-09 Thread Ryan Sonnek
Nino, you overwrote my changes to the Effect class. Please revert your changes and restore my Effect.multiple addition. I can't find *any* reference to this toaster in the core scriptaculous library. please provide a url. is this a custom effect? If so, i think it should be moved out of the

Re: scriptaculous toaster

2008-06-09 Thread Nino Saturnino Martinez Vazquez Wael
Ryan Sonnek wrote: Nino, you overwrote my changes to the Effect class. Please revert your changes and restore my Effect.multiple addition. I'll do that ASAP, will probably first be tommorrow. I can't find *any* reference to this toaster in the core scriptaculous library. It's a

Re: scriptaculous toaster

2008-06-09 Thread Nino Saturnino Martinez Vazquez Wael
Hi Ryan So, now I have merged our two versions, I had to add the two new interface methods as NOOP's on multiple effect. I use the setQueue to obtain the same as the new multiple effect btw. Funny how many ways there are todo stuff:) I guess I should add blind up and blind down effects too?

Re: scriptaculous toaster

2008-06-09 Thread Ryan Sonnek
It's a combination of effects(the example effects from scriptaculous), something that fades in shakes and for example squishes.. Did you see the example? I still think this would best be served in a separate project.

Re: scriptaculous toaster

2008-06-06 Thread Nino Saturnino Martinez Vazquez Wael
Ryan Sonnek wrote: Not sure what this 'toaster' is, but i really like the multiple effect! is it available in 1.8 or is this in scriptaculous 2.0? Im not sure what the definition of toaster really are. But im thinking of something like this:

Re: scriptaculous toaster

2008-06-06 Thread Nino Saturnino Martinez Vazquez Wael
Hmm The Effect's as they are now gives me some trouble, because you need to give the component when creating the component. It would be much more flexible if it could be changed. And would allow the user to control which effects were used.. So what do you say? I could make the change:) API

Re: scriptaculous toaster

2008-06-06 Thread Ryan Sonnek
I'll take a swing at it and try to check something workable in asap. On 6/6/08, Nino Saturnino Martinez Vazquez Wael [EMAIL PROTECTED] wrote: Hmm The Effect's as they are now gives me some trouble, because you need to give the component when creating the component. It would be much more

Re: scriptaculous toaster

2008-06-06 Thread Ryan Sonnek
Okay Nino, I've created a new Effect.multiple that should give you what you need. take a look and let me know what you think. here's how it works: AbstractEffect[] effects = new AbstractEffect[] { new Effect.Fade(component1), new Effect.Highlight(component2), etc... } new

Re: scriptaculous toaster

2008-06-05 Thread Ryan Sonnek
Not sure what this 'toaster' is, but i really like the multiple effect! is it available in 1.8 or is this in scriptaculous 2.0? We have a scriptaculous header contributor using the ScriptaculousAjaxBehavior.newJavascriptBindingBehavior(). do you need something different? On Wed, Jun 4, 2008