Re: AW: AW: Tabbed Panel with bookmarkable links

2009-04-29 Thread Vladimir K
: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- View this message in context: http://www.nabble.com/Tabbed-Panel-with-bookmarkable-links-tp22418170p23295407.html Sent from the Wicket - User mailing list archive at Nabble.com

AW: AW: Tabbed Panel with bookmarkable links

2009-03-12 Thread Christian Helmbold
The development of the bookmarkable tabbed panel component is continued on http://wicketskunkworks.org. We decided to use a Google Code project for now but we plan to make the final component available via wicket stuff or maybe in the extensions tree of the core distribution (i don't know if

Re: AW: Tabbed Panel with bookmarkable links

2009-03-12 Thread Martijn Dashorst
Why start yet another project when the intention is to move it to stuff anyway? Martijn On Thu, Mar 12, 2009 at 12:22 PM, Christian Helmbold christian.helmb...@yahoo.de wrote: The development of the bookmarkable tabbed panel component is continued on http://wicketskunkworks.org. We decided

Re: AW: Tabbed Panel with bookmarkable links

2009-03-12 Thread Brill Pappin
I don't think we know that it will be moved... right now we only know that we two need it. - Brill On 12-Mar-09, at 7:28 AM, Martijn Dashorst wrote: Why start yet another project when the intention is to move it to stuff anyway? Martijn On Thu, Mar 12, 2009 at 12:22 PM, Christian

Re: AW: Tabbed Panel with bookmarkable links

2009-03-11 Thread Jeremy Thomerson
Use wicket-stuff. It makes sense for this. You might even consider just adding this to minis in WS. http://wicket-stuff.svn.sourceforge.net/viewvc/wicket-stuff/trunk/wicketstuff-core/minis-parent/ -- Jeremy Thomerson http://www.wickettraining.com On Tue, Mar 10, 2009 at 10:25 AM, Christian

AW: Tabbed Panel with bookmarkable links

2009-03-10 Thread Christian Helmbold
Since others seem to need it, this might be worth refining over on wicket-stuff. I think it's worth to build a universal bookmarkable tabbed panel. Brill, please post your solution so we can look what is better in your or in my solution and built the ultimative BookmarkableTabbedPanel. I

Re: Tabbed Panel with bookmarkable links

2009-03-10 Thread James Carman
What if you use two different tabbed panels on the same page? On Tue, Mar 10, 2009 at 8:27 AM, Christian Helmbold christian.helmb...@yahoo.de wrote: Since others seem to need it, this might be worth refining over on wicket-stuff. I think it's worth to build a universal bookmarkable tabbed

AW: AW: Tabbed Panel with bookmarkable links

2009-03-10 Thread Christian Helmbold
What if you use two different tabbed panels on the same page? Good point! It doesn't work with two panels on the same page! I don't know why and how to fix it. It was a mistake in my test code, that lead to this error. I accidentally added the tabs of my second tabbed panel to the

Re: AW: Tabbed Panel with bookmarkable links

2009-03-10 Thread Brill Pappin
Instead of competing, why don't we set up a project some place and check both solutions in under different packages? We can then refactor them into one and take the best of both :) - Brill On 10-Mar-09, at 8:27 AM, Christian Helmbold wrote: Since others seem to need it, this might be worth

Re: Tabbed Panel with bookmarkable links

2009-03-10 Thread Brill Pappin
That is exactly the problem I *do* have :) Have not resolved it yet, but I was thinking or allowing them to be nested to its actually one tab panel, but with multiple levels. - Brill On 10-Mar-09, at 8:41 AM, James Carman wrote: What if you use two different tabbed panels on the same page?

AW: AW: Tabbed Panel with bookmarkable links

2009-03-10 Thread Christian Helmbold
Instead of competing, why don't we set up a project some place and check both solutions in under different packages? We can then refactor them into one and take the best of both :) I agree. Is there an existing place in the wicket project to do this? I've discovered some troubles in my

Re: Tabbed Panel with bookmarkable links

2009-03-10 Thread James Carman
It may not be worth it. Having multiple tabbed panels on the same page may not be a very common usecase. Perhaps it's better to settle for YAGNI in this case and if it really does comes up and someone wants to solve the issue, then address it then. But, for now, a good Javadoc warning might

AW: Tabbed Panel with bookmarkable links

2009-03-10 Thread Christian Helmbold
The problem is that the tabbed panels have to know the state of other panels to generate correct stateful links. So we need some object that keeps track of all tabbed panels and their states. This object must be initialized before the newLink method is called. But this method is called during

AW: AW: Tabbed Panel with bookmarkable links

2009-03-10 Thread Christian Helmbold
In my code were two little bugs. If the constructor with parameter defaultTabIndex was used, the active tab was always set to this value regardless what tab the use clicked on. The other issue affected the specified parameter name that stores the active tab. It did not work in the constructor

Re: AW: AW: Tabbed Panel with bookmarkable links

2009-03-10 Thread Brill Pappin
Yes, because you no longer have the previous state... I have the same problem, but maybe some ideas for a solution. - Brill On 10-Mar-09, at 11:25 AM, Christian Helmbold wrote: Instead of competing, why don't we set up a project some place and check both solutions in under different

Tabbed Panel with bookmarkable links

2009-03-09 Thread Christian Helmbold
Hello, I've written a component which provides bookmarkable links for a tabbed panel. The link to the currend tab is disabled and the url to the default tab contains no tab information to keep URLs short. It works so far, but since this is my first wicket component I'd like to know your

Re: Tabbed Panel with bookmarkable links

2009-03-09 Thread Brill Pappin
bookmarkable links for a tabbed panel. The link to the currend tab is disabled and the url to the default tab contains no tab information to keep URLs short. It works so far, but since this is my first wicket component I'd like to know your suggestions to improve the code. A possible