Committed patchset #1 (id:1)
https://codereview.chromium.org/1186463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/f2747ed9b48d0e62c7a30da69825ff926aeedbd2
Cr-Commit-Position: refs/heads/master@{#28981}
https://codereview.chromium.org/1186463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm ~ rebase
https://codereview.chromium.org/1175313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2015/06/12 07:33:06, jochen wrote:
ptal
lgtm if you add comment regarding non-hydrogen handlers.
https://codereview.chromium.org/1184493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1180043003/1
https://codereview.chromium.org/1180043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Sven Panne,
Description:
[turbofan] Use appropriate type for NodeId.
Up until now we used int32_t for NodeId, but that was not ideal because
negative values are invalid for NodeId and we use it as an array index
for example in the NodeMarker class, where C++ compilers on x64 have to
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1133163005/240001
https://codereview.chromium.org/1133163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Igor Sheludko, jochen,
Message:
ptal
@jochen: fyi
Description:
Query the existince of an element on the interceptor before trying to
delete it.
The deleter doesn't inform us whether it actually deleted something.
BUG=v8:4137
LOG=n
Please review this at
Comment #35 on issue 3996 by bugdro...@chromium.org: Improve typed array
performance
https://code.google.com/p/v8/issues/detail?id=3996#c35
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/89b9a2cfb317e52186f682c91502b22932d52db3
commit
Committed patchset #7 (id:120001)
https://codereview.chromium.org/1179893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 7 (id:??) landed as
https://crrev.com/fa32d461c16a053cc6d48d3fb326016bc2765765
Cr-Commit-Position: refs/heads/master@{#28988}
https://codereview.chromium.org/1179893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1182493007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: danno, martyn.capewell, paul.l..., akos.palfi.imgtec,
dusmil.imgtec, Jakob, Michael Achenbach, Sven Panne, balazs.kilvady,
Message:
Created Revert of MIPS64: Enable shorten-64-to-32 warning.
Description:
Revert of MIPS64: Enable shorten-64-to-32 warning. (patchset #12 id:240001
A revert of this CL (patchset #12 id:240001) has been created in
https://codereview.chromium.org/1182493007/ by yang...@chromium.org.
The reason for reverting is: Compile failure:
https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac64%20-%20debug/builds/3070/steps/compile/logs/stdio.
Try jobs failed on following builders:
v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1278)
https://codereview.chromium.org/1180043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/06/11 18:08:05, domenic wrote:
On 2015/06/11 at 17:59:58, domenic wrote:
On 2015/06/11 at 11:42:04, yangguo wrote:
We may want to consider renaming exports. I do not know what a good
name
would be though.
I will update the design doc with this new pattern.
Design doc
Patchset 2 (id:??) landed as
https://crrev.com/888b4ecab4bbdef6f04f2339b264ce67caff1f95
Cr-Commit-Position: refs/heads/master@{#28980}
https://codereview.chromium.org/1181123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1181123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: ulan,
Description:
Version 4.3.61.28 (cherry-pick)
Merged abbaac48457b6887f5e0bb1c54855f4529c60755
Reland Prevent stack overflow in the serializer/deserializer.
TBR=u...@chromium.org
Please review this at https://codereview.chromium.org/1181053003/
Base URL:
Committed patchset #1 (id:1) manually as
a2a61c311fca08b720a1ef581816fb24335f6f47.
https://codereview.chromium.org/1181053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
LGTM with a nit (didn't really look at the platform-dependent parts)
https://codereview.chromium.org/1133163005/diff/220001/src/base/platform/time.cc
File src/base/platform/time.cc (right):
https://codereview.chromium.org/1133163005/diff/220001/src/base/platform/time.cc#newcode114
On 2015/06/12 05:18:30, Hannes Payer wrote:
Did you forget to add the tests?
Ah, yes, uploaded the missing test file.
https://codereview.chromium.org/1163143009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
lgtm
https://codereview.chromium.org/1184693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1179053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: vogelheim,
Description:
External snapshot: allow empty snapshot for external snapshot.
R=vogelh...@chromium.org
Please review this at https://codereview.chromium.org/1180043003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M
lgtm
https://codereview.chromium.org/1180043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1179053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/21bca71c6d304de9bd6bcf53a572fae843047e76
Cr-Commit-Position: refs/heads/master@{#28985}
https://codereview.chromium.org/1179053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1177083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3
Cr-Commit-Position: refs/heads/master@{#28987}
https://codereview.chromium.org/1177083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1182493007/1
https://codereview.chromium.org/1182493007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 1 (id:??) landed as
https://crrev.com/74534bb8be0befff32cb372043a8c4c180ad7160
Cr-Commit-Position: refs/heads/master@{#28991}
https://codereview.chromium.org/1182493007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1186463002/1
https://codereview.chromium.org/1186463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1186463002/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Speculative revert for changing
layout
tests:
Reviewers: adamk, arv,
Message:
Created Revert of [es6] Bound function names
Description:
Revert of [es6] Bound function names (patchset #1 id:1 of
https://codereview.chromium.org/1182513002/)
Reason for revert:
[Sheriff] Speculative revert for changing layout tests:
LGTM on the TurboFan part with a few nits.
https://codereview.chromium.org/1179893002/diff/11/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1179893002/diff/11/src/compiler/ast-graph-builder.cc#newcode2857
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1178403003/1
https://codereview.chromium.org/1178403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1178403003/ by bmeu...@chromium.org.
The reason for reverting is: GC stress unhappy.
https://codereview.chromium.org/1133773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Hannes Payer, jochen,
Message:
Created Revert of Keep track of array buffers in new space separately
Description:
Revert of Keep track of array buffers in new space separately (patchset #4
id:60001 of https://codereview.chromium.org/1133773002/)
Reason for revert:
GC stress unhappy
Comment #34 on issue 3996 by bugdro...@chromium.org: Improve typed array
performance
https://code.google.com/p/v8/issues/detail?id=3996#c34
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/64ba57ce612ad698dec64135a5cf57990ffd55f6
commit
Committed patchset #1 (id:1)
https://codereview.chromium.org/1178403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6
Cr-Commit-Position: refs/heads/master@{#28979}
https://codereview.chromium.org/1178403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Yang,
Message:
ptal
Description:
Add support for walking stack frames from hydrogen stubs
R=yang...@chromium.org
BUG=none
LOG=n
Please review this at https://codereview.chromium.org/1184493003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+15, -4
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1184493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1180943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/06/12 07:05:18, Benedikt Meurer wrote:
Hey Yang,
This is the change we've talked about. Please take a look.
Thanks,
Benedikt
lgtm!
https://codereview.chromium.org/1180043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1180043002/1
https://codereview.chromium.org/1180043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Note: In case you submitted a blink CL in the mean time, please always
leave a
note about that on the v8-side CL, then I don't revert.
Note2: Your CQ_INCLUDE_TRYBOTS lacks a linebreak, otherwise the tests would
have
run I guess.
https://codereview.chromium.org/1182513002/
--
--
v8-dev
Hey Yang,
This is the change we've talked about. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1180043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Reviewers: Yang,
Description:
[heap] All immutable roots are either smis or immovable heap objects.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1180043002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -2 lines):
M
Committed patchset #1 (id:1) manually as
bd3edf37e1a1ecf158b1ec57904558b5afddd5e3 (presubmit successful).
https://codereview.chromium.org/1184693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 2 (id:??) landed as
https://crrev.com/b935e44c79f3b8e0300bfc0e9c4fba04e94b73e5
Cr-Commit-Position: refs/heads/master@{#28984}
https://codereview.chromium.org/1184493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1179893002/120001
https://codereview.chromium.org/1179893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1180043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/dd96c47a8162b4456c12b7b96e48e46c559b06b1
Cr-Commit-Position: refs/heads/master@{#28989}
https://codereview.chromium.org/1180043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: jarin,
Description:
[turbofan] Inline hot functions for NodeMarkerBase.
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/1184693002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+18, -32 lines):
M
Hey Jaro,
These show up high in the profile for small functions. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1184693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1184493003/20001
https://codereview.chromium.org/1184493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Yang,
Description:
Update PrintStack signature in gdbinit
BUG=none
R=yang...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1179053004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M tools/gdbinit
Index:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1177083003/20001
https://codereview.chromium.org/1177083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Hannes Payer,
Message:
i wonder why this didn't explode before.
guess we should merge this back
Description:
Reland Keep track of array buffers in new space separately
Original review https://codereview.chromium.org/1133773002/
BUG=v8:3996
TBR=hpa...@chromium.org
LOG=n
Please
Hey Sven,
This is an obvious one. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1178403004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Patchset 12 (id:??) landed as
https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb
Cr-Commit-Position: refs/heads/master@{#28990}
https://codereview.chromium.org/1133163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #12 (id:240001)
https://codereview.chromium.org/1133163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Quick DBC...
https://codereview.chromium.org/1157663007/diff/160001/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1157663007/diff/160001/src/compiler/register-allocator.h#newcode969
src/compiler/register-allocator.h:969: if
The TurboFan part is looking good. Mostly nits.
https://codereview.chromium.org/1178363002/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1178363002/diff/1/src/compiler/ast-graph-builder.cc#newcode1645
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1179053004/1
https://codereview.chromium.org/1179053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Michael Starzinger,
Description:
[turbofan] Move RawMachineAssembler to unittests.
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/1177353003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -844 lines):
M
lgtm
https://codereview.chromium.org/1179763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang, Erik Corry Chromium.org,
Message:
Yang, Erik please take a look at the changes here. Thanks!
Description:
Additional HandleScopes to limit Handle consumption.
erikco...@chromium.org suggested digging into v8 handle usage. Found
potential
scopes in ast.cc and
Patchset 1 (id:??) landed as
https://crrev.com/b5b00cc031c15263bbc4e8e8b2bef01b6fdfd284
Cr-Commit-Position: refs/heads/master@{#28993}
https://codereview.chromium.org/1177353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1177353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1172333002/20001
https://codereview.chromium.org/1172333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Mostly looking good, except that it is missing plenty of tests. Some
features
are obviously not working yet (e.g. equality, typeof, etc), but for the
value
behaviour that this CL implements we need tests (in
test/mjsunit/harmony/simd.js), e.g.:
- variants of constructor calls
- prototype
Patchset 1 (id:??) landed as
https://crrev.com/4cc4bc591cc8ffe7d458f4e89e1fbe3944d44c9f
Cr-Commit-Position: refs/heads/master@{#28999}
https://codereview.chromium.org/1181163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1181163002/1
https://codereview.chromium.org/1181163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
There was also this error:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/3374
https://codereview.chromium.org/1179893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
On 2015/06/12 12:03:59, wingo wrote:
Patchset 1 is the CL most recently applied. Patchset 2 fixes a nosnap
deserialization test expectation.
Humm, sometimes rollouts are good. I realized I forgot to add the
regression
test to git! Patchset 2 adds the test.
Status: Assigned
Owner: joc...@chromium.org
CC: habl...@chromium.org, hpa...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4180 by joc...@chromium.org: array buffer backing store might get
confused by not-yet-initialized array buffers
Committed patchset #1 (id:1)
https://codereview.chromium.org/1180943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/a066202b17f5f53cb3419e7dd9785e9f7ce36f97
Cr-Commit-Position: refs/heads/master@{#29000}
https://codereview.chromium.org/1180943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: tandrii(chromium), Jakob,
Message:
PTAL
Description:
[test] More debugging output in test runner.
Also use again the taskkill method, recently removed in
https://codereview.chromium.org/1156133006/
BUG=chromium:485932
LOG=n
Please review this at
On 2015/06/12 at 07:06:24, machenbach wrote:
Note: In case you submitted a blink CL in the mean time, please always
leave a
note about that on the v8-side CL, then I don't revert.
This time I didn't do a blink cl first. I didn't think blink would have
tests
impacted by this but to be sure
LGTM.
https://codereview.chromium.org/1177353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1177353003/1
https://codereview.chromium.org/1177353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM on patch set #2.
https://codereview.chromium.org/117004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/117004/20001
https://codereview.chromium.org/117004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM if my nit is addressed, BTW :-)
https://codereview.chromium.org/1178403004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
Patchset 2 (id:??) landed as
https://crrev.com/a5b0a3e298c9e8eb5917040c6f7ed2f0b919b123
Cr-Commit-Position: refs/heads/master@{#28995}
https://codereview.chromium.org/1172333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1172333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1180943002/1
https://codereview.chromium.org/1180943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 3 (id:??) landed as
https://crrev.com/103fcfaa40c23f7c732601d2f4f8be251415a45c
Cr-Commit-Position: refs/heads/master@{#28998}
https://codereview.chromium.org/1178903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1178903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
This CL actually belongs to issue v8:4173.
https://codereview.chromium.org/1181163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Comment #13 on issue 4121 by andreasl...@gmail.com: Regression: Memory leak
since at least 3.26.33
https://code.google.com/p/v8/issues/detail?id=4121
oh :( I was about to test it on my local machine
--
You received this message because this project is configured to send all
issue
https://codereview.chromium.org/1181903003/diff/20001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/20001/src/typedarray.js#newcode139
src/typedarray.js:139: while (!current.done) {
The main benefit of using for-of is that you get everything
lgtm with a nit:
https://codereview.chromium.org/1180073002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1180073002/diff/20001/src/objects.cc#newcode5093
src/objects.cc:5093:
Spurious change.
https://codereview.chromium.org/1180073002/
--
--
v8-dev
Reviewers: jarin,
Description:
[turbofan] Ensure lazy bailout point in exception handler.
This ensures there is a lazy bailout point at the entry of every
exception handler so that deoptimized code is not re-entered through
caught exceptions.
R=ja...@chromium.org
Reviewers: ulan,
Description:
Debugger: require debugger to be active when dealing with breaks.
This invariant will save us some head ache.
The changes to test-debug/DebugStub is due to the fact that it abuses
the ability to set break points in code that has no debug break slots.
This is now no
Status: Available
Owner:
CC: yang...@chromium.org, bbu...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4178 by joc...@chromium.org: support double-unaligned (and maybe
simd128-unaligned) for snapshot
https://code.google.com/p/v8/issues/detail?id=4178
to get the double value
1 - 100 of 197 matches
Mail list logo
