CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1197703002/180001
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
The author jacob.bram...@arm.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.
https://codereview.chromium.org/1038363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
LGTM. Sorry for the delay.
https://codereview.chromium.org/1038363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1038363002/20001
https://codereview.chromium.org/1038363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Looking good to me. Win64 seems to be unhappy tho.
https://codereview.chromium.org/1191513003/diff/80001/src/compiler/arm/code-generator-arm.cc
File src/compiler/arm/code-generator-arm.cc (right):
Reviewers: Sven Panne,
Description:
[turbofan] Make TyperCache global and thread safe.
This way we need the common types only once per process and we don't
need to recreate them for every compilation. It uses the same pattern
that we already apply to caching operators.
R=svenpa...@chromium.org
lgtm. (although the c++11 magic frightens and confuses me)
https://codereview.chromium.org/1209513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1206773002/1
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: jarin,
Description:
[x64] Fix instruction selection for Word64Equal(Word64And, 0).
This fixes a slight inconsistency in the InstructionSelector that
basically disabled the optimization for things like ObjectIsSmi.
R=ja...@chromium.org
Please review this at
Hey Jaro,
Trivial fix to make %_IsSmi fast on x64. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1206773002/20001
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instruction-selector-x64.cc
File src/compiler/x64/instruction-selector-x64.cc (right):
https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instruction-selector-x64.cc#newcode1322
Patchset 1 (id:??) landed as
https://crrev.com/b7f4981c161c4aeaa8da9ceb01a0fdba94b21490
Cr-Commit-Position: refs/heads/master@{#29247}
https://codereview.chromium.org/1202973003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1202973003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm.
https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instruction-selector-x64.cc
File src/compiler/x64/instruction-selector-x64.cc (right):
https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instruction-selector-x64.cc#newcode1322
lgtm
https://codereview.chromium.org/1202973003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202973003/1
https://codereview.chromium.org/1202973003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #6 (id:180001)
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 6 (id:??) landed as
https://crrev.com/c019d7f498ce6fbac6659924e20ddb6c59aebeb8
Cr-Commit-Position: refs/heads/master@{#29248}
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #20 on issue 4124 by bugdro...@chromium.org: Implement SIMD.js
https://code.google.com/p/v8/issues/detail?id=4124#c20
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/b7f4981c161c4aeaa8da9ceb01a0fdba94b21490
commit
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1038363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/48d726cd6f6ad176d54b546b7d1ca717e5478b46
Cr-Commit-Position: refs/heads/master@{#29249}
https://codereview.chromium.org/1038363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
The author jacob.bram...@arm.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.
https://codereview.chromium.org/1038363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Exceeded global retry quota
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Exceeded global retry quota
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1209513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/db4101ef81002b73f4a57ea6d115429061985acd
Cr-Commit-Position: refs/heads/master@{#29251}
https://codereview.chromium.org/1209513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1209513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/7a675e0e3be0fe1415c8243841fcbdff704dc32a
Cr-Commit-Position: refs/heads/master@{#29250}
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Owner: wi...@igalia.com
Comment #2 on issue 4214 by wi...@igalia.com: Wrong this-value when
deleting property named eval in with-statement context
https://code.google.com/p/v8/issues/detail?id=4214
(No comment was entered for this change.)
--
You received this message
Hey Sven, Jaro,
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1209513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1206773002/40001
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1206773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1209513002/1
https://codereview.chromium.org/1209513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1) manually as
70c26cf6ad3fd5fd473fb2e729bd7d57a8d3b697.
https://codereview.chromium.org/1202413004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1209453003/1
https://codereview.chromium.org/1209453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: ulan,
Message:
Ulan, please review.
This has to be landed before https://codereview.chromium.org/1211453002/
Description:
Serializer: clear next link in weak cells.
If we do not clear next links during serialization, the
serializer would simply follow those links and serialize
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1203973002/40001
https://codereview.chromium.org/1203973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm other than maybe an ordering issue.
Thanks, that was fast!
https://codereview.chromium.org/1202263006/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/1202263006/diff/1/src/compiler/pipeline.cc#newcode608
src/compiler/pipeline.cc:608:
Reviewers: Benedikt Meurer,
Message:
Hi Benedikt, here is the change we discussed. I'm running some perf jobs and
will upload arm64, mips, mips64 soon.
Thx,
--Michael
Description:
Record call counts for monomorphic calls made with an IC.
The idea is that TurboFan can use this information for
Reviewers: adamk,
Message:
This can be relanded once the fix for the code serializer to correctly deal
with
weak cells goes in: https://codereview.chromium.org/1203973002/
But I'll most likely wait with this until after branching.
Description:
Reland Keep a canonical list of shared function
Reviewers: Igor Sheludko,
Message:
ptal
Description:
Move reconfiguration into the elements accessor
BUG=v8:4137
LOG=n
Please review this at https://codereview.chromium.org/1207613005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+90, -98 lines):
M
Reviewers: ulan,
Description:
Re-land new insertion write barrier.
BUG=
Please review this at https://codereview.chromium.org/1211513002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -27 lines):
M src/heap/incremental-marking-inl.h
M src/heap/spaces.h
Try jobs failed on following builders:
v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/5419)
https://codereview.chromium.org/1203973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/a9558715394e38afa299843404f3f45fbf950205
Cr-Commit-Position: refs/heads/master@{#29253}
https://codereview.chromium.org/1202843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1202843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Yang,
Description:
Version 4.5.74.1 (cherry-pick)
Merged 3164aa7483cb476da84895a3c9810015758fccf9
Revert Keep a canonical list of shared function infos.
BUG=chromium:503552,v8:4132
LOG=N
TBR=yang...@chromium.org
Please review this at https://codereview.chromium.org/1202413004/
Patchset 1 (id:??) landed as
https://crrev.com/9f67f3f2d538d5fd8a8e8b34a42dedf6e571bcac
Cr-Commit-Position: refs/heads/master@{#29252}
https://codereview.chromium.org/1209453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1209453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1199413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as
cb69f68bf65ea5888ef93e139a0d5b74ab092611.
https://codereview.chromium.org/1199413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Looks good to me. Thanks for doing that.
https://codereview.chromium.org/1201193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: arv, Michael Starzinger,
Message:
PTAL. Another option would be to revert the part of
https://codereview.chromium.org/1178903003 that made
kResolvePossiblyDirectEval
return just one result, and make it take the receiver again, dunno though.
Description:
Fix receiver when calling
On 2015/06/24 11:55:20, wingo wrote:
PTAL. Another option would be to revert the part of
https://codereview.chromium.org/1178903003 that made
kResolvePossiblyDirectEval
return just one result, and make it take the receiver again, dunno though.
also note that this patch is missing TF support
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1208443002/1
https://codereview.chromium.org/1208443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #4 on issue 4214 by wi...@igalia.com: Wrong this-value when
deleting property named eval in with-statement context
https://code.google.com/p/v8/issues/detail?id=4214
On the other hand:
d8 with({get foo(){return function(){return this}}}) foo()
{get foo(){return function(){return
Reviewers: ulan,
Description:
Version 4.3.61.31 (cherry-pick)
Merged 7ad9980d995b0381046ee8677861491ef6d234ed
Avoid having untyped slots for objects embedded into code because it breaks
slots filtering.
BUG=chromium:478747,chromium:478811
LOG=N
R=u...@chromium.org
Please review this at
Reviewers: ulan,
Description:
Version 4.3.61.32 (cherry-pick)
Merged f6b71512ea8a99f0882a2997f5ba600bea6e8752
Serializer: do not miss outdated contexts if they are serialized deferred.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/1210503002/
Base URL:
lgtm
https://codereview.chromium.org/1202843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Hey Ben,
As discussed offline, this revives the unquestionable parts of the
SimplifiedOperatorReducer. Mostly straight forward. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1202263006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/06/24 11:47:57, commit-bot: I haz the power wrote:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202843006/1
Oh dear, I accidentally uploaded a patch on top of this one which was from a
different branch. Will delete and re-cq+ the
Reviewers: titzer,
Description:
[turbofan] Revive the useful parts of the SimplifiedOperatorReducer.
This partially reverts https://codereview.chromium.org/1162563002
because we might actually be able to optimize certain combinations
now due to dead code elimination.
R=tit...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202843006/1
https://codereview.chromium.org/1202843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1208443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: ulan, jochen,
Message:
PTAL. I bumped a bit too high in
https://codereview.chromium.org/1181413003. Our
android 32 bit builds are broken since then. Chromium seems to use platform
level 16, see
https://codereview.chromium.org/1161933005/diff/11/build/config/android/config.gni
Comment #5 on issue 4214 by wi...@igalia.com: Wrong this-value when
deleting property named eval in with-statement context
https://code.google.com/p/v8/issues/detail?id=4214
The semantics are here:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1203973002/20001
https://codereview.chromium.org/1203973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Exceeded global retry quota
https://codereview.chromium.org/1203973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1194023004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Description:
Make sure bound functions never make it into optimized code map.
This is one step torwards extracting an OptimizedCodeMap out from the
SharedFunctionInfo in order to have a more flexible implementation.
R=bmeu...@chromium.org
Please review this at
Comment #3 on issue 4214 by wi...@igalia.com: Wrong this-value when
deleting property named eval in with-statement context
https://code.google.com/p/v8/issues/detail?id=4214
I don't really understand this bug tbh. Is it not equivalent to:
var obj = {}
with (obj) (function(){return
lgtm
https://codereview.chromium.org/1210503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
I just looked at the deltas beyond the original patch, and say LGTM.
https://codereview.chromium.org/1199983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Reviewers: v8-mips-ports_googlegroups.com, Rodolph Perfetta (ARM),
Message:
Hey Rodolph, MIPS people,
Please add the ports (mips, mips64, arm64).
Thanks,
Benedikt
Description:
[turbofan] Add support for calling to (a subset of) C functions.
Please review this at
Reviewers: Jakob,
Description:
Fix -Werror=sign-compare error with GCC
R=jkumme...@chromium.org
LOG=N
BUG=
Please review this at https://codereview.chromium.org/1202843006/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (+1, -1 lines):
M src/frames.cc
Index:
Committed patchset #2 (id:20001) manually as
b98f3a1bebf4d2ba3bf31ec115500c33af7ddbbd.
https://codereview.chromium.org/1210503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Comment #6 on issue 4214 by wi...@igalia.com: Wrong this-value when
deleting property named eval in with-statement context
https://code.google.com/p/v8/issues/detail?id=4214
https://codereview.chromium.org/1202963005 for the fix
--
You received this message because this project is
lgtm
https://codereview.chromium.org/1208443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/06/23 21:40:17, adamk wrote:
I don't see any obvious things missing from your test cases, this looks
ready
to
port to me.
+1
https://codereview.chromium.org/1203813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm if comments are addressed:
https://codereview.chromium.org/1203973002/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
https://codereview.chromium.org/1203973002/diff/1/src/snapshot/serialize.cc#newcode1866
src/snapshot/serialize.cc:1866: if (weak_cell_)
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202843006/1
https://codereview.chromium.org/1202843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1211513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 4 (id:??) landed as
https://crrev.com/51073d5f404354d89a3a988f8de28b1f0ea1b96a
Cr-Commit-Position: refs/heads/master@{#29268}
https://codereview.chromium.org/1199813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Fixed
Comment #4 on issue 4220 by a...@chromium.org: Unchecked use of built-ins in
String.prototype.normalize
https://code.google.com/p/v8/issues/detail?id=4220
(No comment was entered for this change.)
--
You received this message because this project is configured
Comment #2 on issue 4240 by a...@chromium.org: jsmin does not handle
template strings correctly
https://code.google.com/p/v8/issues/detail?id=4240
There are some issues but none of them are the of 4235.
1. The escaping is wrong `abc\`def`
2. Nested templates are not handled `abc${ `def`
lgtm
https://codereview.chromium.org/1202383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202383005/1
https://codereview.chromium.org/1202383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #4 (id:50001)
https://codereview.chromium.org/1199813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Comment #3 on issue 4220 by bugdro...@chromium.org: Unchecked use of
built-ins in String.prototype.normalize
https://code.google.com/p/v8/issues/detail?id=4220#c3
The following revision refers to this bug:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1207013002/20001
https://codereview.chromium.org/1207013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1211663002/1
https://codereview.chromium.org/1211663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1209713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/a0f4706e5ea0ffaf0fbd1e0015a1a8697427f021
Cr-Commit-Position: refs/heads/master@{#29271}
https://codereview.chromium.org/1209713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #2 on issue 4232 by little...@chromium.org: Unchecked assignment
with plain object in PromiseDeferred (promise.js)
https://code.google.com/p/v8/issues/detail?id=4232
I tried this test case with --no-harmony_arrays and the setter was still
called. I don't see what this might have to
Committed patchset #1 (id:1)
https://codereview.chromium.org/1202383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/c05c9f1881ffd50a1f3600250a05c0986414fbb9
Cr-Commit-Position: refs/heads/master@{#29269}
https://codereview.chromium.org/1202383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Started
Comment #2 on issue 4229 by a...@chromium.org:
Object.prototype.hasOwnProperty steps not executed in correct order
https://code.google.com/p/v8/issues/detail?id=4229
(No comment was entered for this change.)
--
You received this message because this project
Status: Assigned
Owner: yang...@chromium.org
CC: a...@chromium.org, caitpott...@gmail.com
Labels: Type-Bug Priority-Medium
New issue 4240 by a...@chromium.org: jsmin does not handle template strings
correctly
https://code.google.com/p/v8/issues/detail?id=4240
jsmin.py has some issues with
Patchset 2 (id:??) landed as
https://crrev.com/6e6a1c8aee16cffdcbbf54f09b73b2b79b2ecedf
Cr-Commit-Position: refs/heads/master@{#29270}
https://codereview.chromium.org/1207013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #4 on issue 4229 by bugdro...@chromium.org:
Object.prototype.hasOwnProperty steps not executed in correct order
https://code.google.com/p/v8/issues/detail?id=4229#c4
The following revision refers to this bug:
1 - 100 of 287 matches
Mail list logo
