LGTM. Hope that helps to find the root causes...
https://codereview.chromium.org/1255383004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Reviewers: Yang,
Description:
[stubs] Use a single slot for context globals.
Don't use different read/write slots for context globals, but
let them share the same slot, which reduces the number of
initial misses, and also saves some memory for large scripts.
R=yang...@chromium.org
Please
Patchset 1 (id:??) landed as
https://crrev.com/4eeafb8802aaf32dac03b91ec61e166f45b76f81
Cr-Commit-Position: refs/heads/master@{#29889}
https://codereview.chromium.org/1258213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1258213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
I suspect the test has some value, as a parser/compiler stress test.
Keeping but
shortening it sounds good.
https://codereview.chromium.org/1257583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Status: WontFix
Comment #1 on issue 4329 by habl...@chromium.org: v8_base_0 build failed
using visual studio 2013 in window7
https://code.google.com/p/v8/issues/detail?id=4329
Hi,
please ask this question again at v8-us...@googlegroups.com and please
provide the following
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [stubs] Properly handle read-only properties in
StoreGlobalViaContextStub.
port cac64b9f634743f7f5311d4dca8d50157b10fab5 (r29881)
original commit message:
We don't need the hole check and slow runtime mode for read-only
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1258213002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1258213002/1
https://codereview.chromium.org/1258213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1263473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1262583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1263473002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1263473002/1
https://codereview.chromium.org/1263473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1257883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1257883003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1257883003/1
https://codereview.chromium.org/1257883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1259063004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 2 (id:??) landed as
https://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9
Cr-Commit-Position: refs/heads/master@{#29893}
https://codereview.chromium.org/1262583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1257583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/d4d5663a2f432a97721a15044f118154a287a1ed
Cr-Commit-Position: refs/heads/master@{#29895}
https://codereview.chromium.org/1257583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1262583002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1262583002/20001
https://codereview.chromium.org/1262583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Hey Martyn,
Thanks for the port. I had to split the CL into parts and did the ARM/ARM64
ports as part of that. Sorry for the late notice.
Thanks,
Benedikt
https://codereview.chromium.org/1263493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Patchset 1 (id:??) landed as
https://crrev.com/d12e3232e9609909095262074468c23197a7db2f
Cr-Commit-Position: refs/heads/master@{#29894}
https://codereview.chromium.org/1264443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1264443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/07/28 05:39:03, mvstanton wrote:
Hi Michael, it's pretty unlikely that those OSR failures are due to this.
It
only changes code behind a flag that is turned off in the build.
https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc
File src/ic/ia32/ic-ia32.cc
Patchset 1 (id:??) landed as
https://crrev.com/02f097487cb69c1b51712e8b3c6e767b0f892fdf
Cr-Commit-Position: refs/heads/master@{#29891}
https://codereview.chromium.org/1263473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Hablich, Michael Starzinger,
Message:
Created Revert of Activate preserving of optimized code map accross GCs.
Description:
Revert of Activate preserving of optimized code map accross GCs. (patchset
#1
id:1 of https://codereview.chromium.org/1217863006/)
Reason for revert:
This
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1255043003/ by hpa...@chromium.org.
The reason for reverting is: This CL may be the reason for the spike on
memory
corruption. Tentatively reverting this CL.
BUG=chromium:512780
LOG=n.
Patchset 1 (id:??) landed as
https://crrev.com/4b6770867a08fe96b7643e4fee6de1a5c01a1ae9
Cr-Commit-Position: refs/heads/master@{#29888}
https://codereview.chromium.org/1255043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1255043003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1255043003/1
https://codereview.chromium.org/1255043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1255043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/07/28 07:31:16, Benedikt Meurer wrote:
Hey Yang,
This is a followup optimization for context globals, which is now possible
since
we handle readonly properties correctly (in the fast case for stores).
Please take a look.
Thanks,
Benedikt
Igor: FYI
LGTM. This is great!
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1259063004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1259063004/1
https://codereview.chromium.org/1259063004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1263473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Description:
ARM: Further optimize Load/StoreGlobalViaContext stubs
ARM and ARM64 port of https://codereview.chromium.org/1250413002/
BUG=
Please review this at https://codereview.chromium.org/1263493002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1257583005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1257583005/1
https://codereview.chromium.org/1257583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1254143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/6cf94ebde1ad31dfce0af4dfa642468ec21b0174
Cr-Commit-Position: refs/heads/master@{#29887}
https://codereview.chromium.org/1254143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Benedikt Meurer,
Message:
Hi Benedikt, here is the bug we were looking at...
Description:
Verify that type feedback vector structure is the same on recompile.
Use a CHECK statement to find any violations of this rule.
BUG=
Please review this at
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs.
port 5dff4bdff06c0463db1e876af7541af2b715392c (r29886).
original commit message:
No need to pass the name explicitly to the stubs; the runtime can
extract the name from
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: VectorICs: vector [keyed]store ic MISS handling infrastructure.
port a913f4bf5c40ef88c52e7cf821540f0faf5524f9 (r29870).
original commit message:
BUG=
Please review this at https://codereview.chromium.org/1257883003/
Base URL:
Reviewers: Benedikt Meurer,
Message:
ptal
2nd patchset contains fix in JSTypedArray::GetBuffer() to not try to
externalize
an already neutered external buffer
Description:
Reland of Remove ExternalArray, derived types, and element kinds
Original issue's description:
Remove ExternalArray,
lgtm once nits are addressed.
https://codereview.chromium.org/1257543003/diff/40001/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):
https://codereview.chromium.org/1257543003/diff/40001/src/interpreter/bytecodes.cc#newcode19
src/interpreter/bytecodes.cc:19: {
Comment #46 on issue 3996 by bugdro...@chromium.org: Improve typed array
performance
https://code.google.com/p/v8/issues/detail?id=3996#c46
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/fded08f6949ac3f673f64d3e36be5d03800660e9
commit
On 2015/07/27 20:31:29, Michael Achenbach wrote:
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1257223002/ by
mailto:machenb...@chromium.org.
The reason for reverting is: [Sheriff] Breaks several layout tests, e.g.:
Committed patchset #1 (id:1)
https://codereview.chromium.org/1257883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/95fc22e4c8fbd9cfccf94ab8cbcb308a690f39d7
Cr-Commit-Position: refs/heads/master@{#29890}
https://codereview.chromium.org/1257883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
LGTM.
https://codereview.chromium.org/1245133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
OK, thanks. I'll close this.
https://codereview.chromium.org/1263493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1255563002/80001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1255563002/80001
https://codereview.chromium.org/1255563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/07/28 19:07:30, bbudge wrote:
In the spirit of the change I made to ToNumber.
This changes the message for the TypeError when converting a Symbol
wrapper to
a
primitive. I'm not sure if that matters.
This isn't needed for SIMD.
Comment #21 on issue 3453 by yun...@netflix.com: endless map growth with
--perf-basic-prof
https://code.google.com/p/v8/issues/detail?id=3453
+1, would really love to see this get integrated in V8
--
You received this message because this project is configured to send all
issue
Status: Untriaged
Owner:
New issue 4332 by fre...@google.com: JSON.parse() fails without helpful
line number of line offset information when unexpected token is encountered
https://code.google.com/p/v8/issues/detail?id=4332
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4)
On 2015/07/28 10:56:58, ulan wrote:
lgtm
lgtm.
https://codereview.chromium.org/1260953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1262613002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1262613002/1
https://codereview.chromium.org/1262613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/07/28 10:56:58, ulan wrote:
lgtm
lgtm.
https://codereview.chromium.org/1260953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Comment #2 on issue 4330 by vogelh...@chromium.org: Deal with flakiness
for 'futex' on 'V8Linux64 TSAN'.
https://code.google.com/p/v8/issues/detail?id=4330
Can't reproduce, but from the log this looks to be the assignment
options.script_executed = true in v8::Shell::ExecuteString, which
LGTM. Please sort the list alphabetically.
https://codereview.chromium.org/1259013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
LGTM!
https://codereview.chromium.org/1256413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Looks good to me, thanks for updating this.
https://codereview.chromium.org/1245133002/diff/11/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
https://codereview.chromium.org/1245133002/diff/11/src/arm/builtins-arm.cc#newcode951
src/arm/builtins-arm.cc:951: // -
lgtm
https://codereview.chromium.org/1252993004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Status: Assigned
Owner: mvstan...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4331 by mvstan...@chromium.org: CCTest
test-func-name-inference/InConstructor is broken
https://code.google.com/p/v8/issues/detail?id=4331
The test fails with other parser fixes.
Address asap.
--
You
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
https://codereview.chromium.org/1257543003/diff/40001/src/interpreter/interpreter.cc#newcode57
src/interpreter/interpreter.cc:57: void
Interpreter::DoLoadSmi8(compiler::InterpreterAssembler* assembler) {
On 2015/07/27 16:59:00, oth
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1256413005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1256413005/1
https://codereview.chromium.org/1256413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/d2e815f15be1682bb4b44d6b9f9f4aad47341f10
Cr-Commit-Position: refs/heads/master@{#29896}
https://codereview.chromium.org/1256413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
patchset 2 lgtm.
But a couple nits in commit message: title should remove the word 'test',
since
you fixed disasm itself, and TEST should show the actual failing test:
TEST=cctest/test-disasm-mips[64]/Type3
https://codereview.chromium.org/1258743004/
--
--
v8-dev mailing list
Reviewers: Michael Achenbach,
Message:
PTAL
Description:
Moved project configs to infra/config branch
luci-config has been switched to read from
https://chromium.googlesource.com/v8/v8/+/infra/config
R=machenb...@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513460
Please
Hey Yang,
This is a followup optimization for context globals, which is now possible
since
we handle readonly properties correctly (in the fast case for stores).
Please take a look.
Thanks,
Benedikt
Igor: FYI
https://codereview.chromium.org/1258213002/
--
--
v8-dev mailing list
On 2015/07/27 15:56:13, paul.l... wrote:
On 2015/07/27 07:45:23, rmcilroy (OOO until 10th Aug) wrote:
Are t1 and t2 callee saved for JS calls? If so, lgtm. Thanks!
No, these new regs are not callee-saved, and your original s0,s1 are, but
are
not in our 'allocatable' list. Let me see what I
Patchset 1 (id:??) landed as
https://crrev.com/029ca8ca6b6efaf16ae10352e5fafdc9591f0e4e
Cr-Commit-Position: refs/heads/master@{#29892}
https://codereview.chromium.org/1259063004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1259063004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
LGTM.
https://codereview.chromium.org/1262583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
TBR
Description:
[test] Skip slow test in novfp3 mode.
TBR=yang...@chromium.org
NOTRY=true
Please review this at https://codereview.chromium.org/1264443002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -0 lines):
M
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1264443002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1264443002/1
https://codereview.chromium.org/1264443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Benedikt Meurer, ulan, Yang,
Description:
[arm] Fix --enable-vldr-imm.
This fixes several bugs related to float64 pool constants.
Note that float64 pool constants are still disabled by default, and are
only used if --enable-vldr-imm is provided.
BUG=
Please review this at
Committed patchset #1 (id:1)
https://codereview.chromium.org/1256413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1257543003/140001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1257543003/140001
https://codereview.chromium.org/1257543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Thanks, done a couple of exceptions (git cl format, work in other patch).
https://codereview.chromium.org/1257543003/diff/60001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
On 2015/07/28 13:35:28, oth wrote:
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
https://codereview.chromium.org/1257543003/diff/40001/src/interpreter/interpreter.cc#newcode57
src/interpreter/interpreter.cc:57: void
Interpreter::DoLoadSmi8(compiler::InterpreterAssembler*
Reviewers: adamk, Dan Ehrenberg,
Description:
[es6] Refactor FormalParameter
Store arity in FormalParameters; store name (instead of var) and is_rest
flag in
individual parameters.
This is preparation for more parameter destructuring adjustments. In
particular,
a follow-up CL will
Reviewers: Benedikt Meurer,
Message:
PTAL, thx!
Description:
Bugfix: Incorrect type feedback vector structure on recompile.
Scoping rules are different on recompile vis-a-vis global loads.
BUG=514526
Please review this at https://codereview.chromium.org/1256413005/
Base URL:
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/buildtools to f0b8022601cf9c3c1a2f7efcea48e2fe81d3b143
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1262733002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files
Reviewers: balazs.kilvady, akos.palfi.imgtec, ilija.pavlovic_imgtec.com,
Message:
PTAL, this is first step in getting some callee-saved regs into our register
allocator list, for use in interpreter. MIPS64 port still to come.
Description:
MIPS: Tweak CEntryStub to free up callee-saved regs
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1258763004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1258763004/1
https://codereview.chromium.org/1258763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1258763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js
File src/runtime.js (left):
https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js#oldcode796
src/runtime.js:796: if (IS_FLOAT32X4(x)) throw
MakeTypeError(kSimdToNumber);
Perhaps add a comment explaining
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1260273002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1260273002/40001
https://codereview.chromium.org/1260273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: ulan,
Message:
PTAL.
https://codereview.chromium.org/1263543004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1263543004/diff/1/src/objects.cc#newcode4659
src/objects.cc:4659: if (maybe_old_prototype-IsJSObject()) {
This if-block is new; the
lgtm
https://codereview.chromium.org/1263543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: adamk,
Description:
Correct handling of temporaries as parameters.
They need to be properly recorded in the scope's temps set, otherwise
allocation
doesn't know about them and can break. (Not observable right now, but
necessary
for follow-up changes to parameter destructuring.)
Comment #27 on issue 2159 by longlive...@gmail.com: Add support for rest
parameters
https://code.google.com/p/v8/issues/detail?id=2159
kpdecker that is an awesome piece of work on the test suite. Bookmarked up
there with chromestatus.
--
You received this message because this project is
Yes, I like this approach much better. LGTM.
What's up with the v8_linux_rel bot? Looks like it doesn't have test262-es6.
https://codereview.chromium.org/1245623005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Reviewers: Benedikt Meurer, dstence, michael_dawson,
Description:
PPC: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs.
Port 5dff4bdff06c0463db1e876af7541af2b715392c
Original commit message:
No need to pass the name explicitly to the stubs; the runtime can
extract the name
Reviewers: rossberg,
Message:
This seems to give about 3% back.
Description:
Optimise ToNumber and NonNumberToNumber.
Defers some uncommon type checking from ToNumber and
NonNumberToNumber into DefaultNumber. This should
speed up numeric operations as more value types are
added.
LOG=N
Patchset 1 (id:??) landed as
https://crrev.com/b8568ec86c91628d5662aa2aabca8fa187e9c952
Cr-Commit-Position: refs/heads/master@{#29897}
https://codereview.chromium.org/1258763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: adamk, Dan Ehrenberg,
Description:
[es6] Implement proper TDZ for parameters
Previously, examples like (({a = x}, x) = {})({}, 0) did not throw a
ReferenceError like they should. This CL
- Splits up DeclareFormalParameters such that the formals can be recorded
first
and declared
lgtm
https://codereview.chromium.org/1258763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js
File src/runtime.js (left):
https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js#oldcode796
src/runtime.js:796: if (IS_FLOAT32X4(x)) throw
MakeTypeError(kSimdToNumber);
On 2015/07/28 15:03:19, rossberg wrote:
Comment #23 on issue 3018 by longlive...@gmail.com: Implement the spread
operator
https://code.google.com/p/v8/issues/detail?id=3018
Cool, that's good to know. Nice shipping with all the ES2015 !
--
You received this message because this project is configured to send all
issue
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1258743004/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1258743004/20001
https://codereview.chromium.org/1258743004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1259013002/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1259013002/60001
https://codereview.chromium.org/1259013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1263543004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1263543004/1
https://codereview.chromium.org/1263543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1263543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
1 - 100 of 146 matches
Mail list logo
