Thanks, done a couple of exceptions (git cl format, work in other patch).
https://codereview.chromium.org/1257543003/diff/60001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1257543003/diff/60001/src/compiler/interpreter-assembler.h#newcode44
src/compiler/interpreter-assembler.h:44: // Returns the bytecode
argument |index| for the current bytecode.
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
update comment too please.
Done. sed'ited it and missed this, doh!
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/bytecodes.cc#newcode20
src/interpreter/bytecodes.cc:20: ,
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
nit - comma on the line above?
git cl format, leaving for now to avoid the presubmit warning.
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/bytecodes.h#newcode18
src/interpreter/bytecodes.h:18: // The list of operands used by
bytecodes.
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
/s/operands/operand types/
Done.
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/bytecodes.h#newcode29
src/interpreter/bytecodes.h:29:
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
nit - extra newline
Done.
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/bytecodes.h#newcode41
src/interpreter/bytecodes.h:41:
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
nit - extra newline
Done.
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/bytecodes.h#newcode63
src/interpreter/bytecodes.h:63: // Returns bytecode for |value|,
checking validity in the process.
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
nit - remove the ", checking validity in the process" since this is
now a
DCHECK.
Done.
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/interpreter.cc#newcode50
src/interpreter/interpreter.cc:50: // argument.
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
/s/the register index specified by the bytecode's argument/the
destination
register
Done.
https://codereview.chromium.org/1257543003/diff/60001/src/interpreter/interpreter.cc#newcode62
src/interpreter/interpreter.cc:62: UNIMPLEMENTED();
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
nit - just make this //TODO(rmcilroy) Implement LoadSmi8 for now.
Done.
https://codereview.chromium.org/1257543003/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1257543003/diff/60001/src/objects.cc#newcode11637
src/objects.cc:11637: os << bytecode << "\n";
On 2015/07/28 08:58:12, rmcilroy (OOO until 10th Aug) wrote:
could we add the formatted versions of the arguments after the
bytecode - e.g.,
r1 for register 1 and #123 for literal SMI 123, etc? (fine to do in
another CL).
Part of next patch.
https://codereview.chromium.org/1257543003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
