Reviewers: cbruni,
Description:
Debugger: refactor and move ScopeIterator and FrameInspector.
This is a pure refactor and does not change functionality.
R=cbr...@chromium.org
Please review this at https://codereview.chromium.org/1264993002/
Base URL:
Thanks for the review. I have addressed your comments. PTAL.
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h#newcode358
src/heap/spaces-inl.h:358: top =
Reviewers: danno,
Message:
PTAL.
Turns out that CallDescriptor::JSParameterCount() isn't so interesting after
all.
Description:
[turbofan] Simplifying handling of callee-cleanup stack area.
R=da...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1269913002/
Base URL:
On 2015/07/31 12:23:51, Benedikt Meurer wrote:
lgtm
More details about the failure I'm getting:
After calling ld.gold with --verbose --debug all, I'm seeing this in the
end:
.../v8/third_party/binutils/Linux_x64/Release/bin/ld.gold: 0 running
task
Plugin_hook
Patchset 4 (id:??) landed as
https://crrev.com/4fc6f5472441523c1a46d0d273ba8b216f96250f
Cr-Commit-Position: refs/heads/master@{#29953}
https://codereview.chromium.org/1266013006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1266013006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1260733003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1260733003/1
https://codereview.chromium.org/1260733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1268433003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1268433003/1
https://codereview.chromium.org/1268433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1267773004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1268433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/3edebf08ebc1bcceb8b21c414f836fed5e41d6b7
Cr-Commit-Position: refs/heads/master@{#29955}
https://codereview.chromium.org/1268433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
looking good so far. Maybe you can define the dummy as TypeFeedbackVector
directly so you don't need the cast helper.
https://codereview.chromium.org/1268783004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1268783004/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1268783004/60001
https://codereview.chromium.org/1268783004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1260733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/9bf532350f1f2f55a215a998114cd97fe7d7b190
Cr-Commit-Position: refs/heads/master@{#29954}
https://codereview.chromium.org/1260733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
On 2015/07/31 13:26:19, mvstanton wrote:
Ugh. It breaks the world because the ROOT_LIST needs the complete
definition
of
TypeFeedbackVector and a circular dependency results. I'm playing with
it, but
doesn't look awesome...
lgtm.
https://codereview.chromium.org/1268783004/
--
--
v8-dev
Patchset 3 (id:??) landed as
https://crrev.com/1a5751f9b3ca682fadb6fce8202dda2db5b017c6
Cr-Commit-Position: refs/heads/master@{#29956}
https://codereview.chromium.org/1268783004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:60001)
https://codereview.chromium.org/1268783004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1268433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM with a few more minor comments.
https://codereview.chromium.org/1260283002/diff/180001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1260283002/diff/180001/src/elements.cc#newcode1180
src/elements.cc:1180: // to_add is 0 and new_length = elms_len, so
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1266013006/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1266013006/60001
https://codereview.chromium.org/1266013006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Benedikt Meurer,
Description:
[turbofan] Float32 LinkageLocations need double registers too.
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1268433003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
Ugh. It breaks the world because the ROOT_LIST needs the complete
definition of
TypeFeedbackVector and a circular dependency results. I'm playing with it,
but
doesn't look awesome...
https://codereview.chromium.org/1268783004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Benedikt Meurer, Jarin (OOO - vacation),
Description:
Setting up the stage for heuristics that preprocess live ranges before
register
allocation, and are independent of register allocation - e.g. the deferred
blocks heuristic, or the split at call sites heuristic.
Added a separate
lgtm
https://codereview.chromium.org/1269913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1269913002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1269913002/1
https://codereview.chromium.org/1269913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/44bfb4b57e25e1df529624a02686e98051e03c5b
Cr-Commit-Position: refs/heads/master@{#29957}
https://codereview.chromium.org/1269913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1260283002/220001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1260283002/220001
https://codereview.chromium.org/1260283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #2 on issue 4337 by heriber...@gmail.com: Failure to build Android
shared library in OSX
https://code.google.com/p/v8/issues/detail?id=4337
That's what I did a few days ago, with no success so far:
https://groups.google.com/forum/#!topic/v8-users/TweC9Q6Q68c
That's the reason I
Committed patchset #1 (id:1)
https://codereview.chromium.org/1269913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 12 (id:??) landed as
https://crrev.com/ffb3a927592ecc4dc6858ca8fb0d9a0c31e3fb53
Cr-Commit-Position: refs/heads/master@{#29958}
https://codereview.chromium.org/1260283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #12 (id:220001)
https://codereview.chromium.org/1260283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: Hannes Payer,
Message:
PTAL
In local testing I observed that memory reducer can time long time to kick
in
because it doesn't use the current allocation rate.
Description:
Memory reducer should use the current allocation rate instead of the overall
allocation rate.
BUG=
Please
Michael,
the internal error looks familiar. See
https://crbug.com/513074
https://codereview.chromium.org/1249273003/
Thank you for working on this!
https://codereview.chromium.org/1267773004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Reviewers: Yang,
Message:
Thanks for the look, Yang!
Description:
VectorICs: refactoring to eliminate for queries only vector ic mode.
Since we need the notion of a dummy vector ic, we can use that to avoid
a special case of the IC constructor. Also, consolidate the two dummy
ICs into one.
Updates:
Status: PendingFurtherInfo
Comment #1 on issue 4337 by habl...@chromium.org: Failure to build Android
shared library in OSX
https://code.google.com/p/v8/issues/detail?id=4337
Could you redirect this to v8-us...@googlegroups.com please? I think you
will get more interactive
Comment #6 on issue 4335 by jkumme...@chromium.org: large google maps
performance regression in chrome canary (version 46)
https://code.google.com/p/v8/issues/detail?id=4335
I started to implement the thread-through approach, but then realized it
wouldn't work. We can't set the requires
PTAL, thanks.
https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc
File test/cctest/interpreter/test-interpreter.cc (right):
https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc#newcode31
Reviewers: joransiu, john.yan, michael_dawson, mvstanton,
Description:
PPC: VectorICs: refactoring to eliminate for queries only vector ic mode.
Port 1a5751f9b3ca682fadb6fce8202dda2db5b017c6
Original commit message:
Since we need the notion of a dummy vector ic, we can use that to avoid
Comment #7 on issue 4335 by toon.ver...@gmail.com: large google maps
performance regression in chrome canary (version 46)
https://code.google.com/p/v8/issues/detail?id=4335
No we don't need to clear if the object is not a prototype; since we'll
clear if it becomes a prototype if necessary.
Reviewers: joransiu, john.yan, michael_dawson, titzer,
Message:
Including titzer due to the change to src/compiler/c-linkage.cc.
Description:
PPC: Clean up register save/restore logic.
R=tit...@chromium.org, michael_daw...@ca.ibm.com, j...@ca.ibm.com,
joran...@ca.ibm.com
BUG=
Please review
Reviewers: Michael Achenbach,
Message:
PTAL
Description:
Renamed internal tryjob group
R=machenb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1266233002/
Base URL: https://chromium.googlesource.com/v8/v8@config
Affected files (+1, -1 lines):
M
lgtm
https://codereview.chromium.org/1271583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Internal error: failed to checkout. Please try again.
https://codereview.chromium.org/1266233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1266233002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1266233002/1
https://codereview.chromium.org/1266233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/de7e8a8c6df64b4db4f4f9d472d5db3aee497b70
Cr-Commit-Position: refs/heads/master@{#29959}
https://codereview.chromium.org/1261433007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1271583002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1271583002/1
https://codereview.chromium.org/1271583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1266233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1261433007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1261433007/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1261433007/1
https://codereview.chromium.org/1261433007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Nice try, thought CQ might be smart... well, please land this manually.
https://codereview.chromium.org/1266233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Committed patchset #1 (id:1) manually as
0e6e555724095d742a7b22aa72d43d78be2d4060 (presubmit successful).
https://codereview.chromium.org/1266233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #1 (id:1)
https://codereview.chromium.org/1261433007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Try jobs failed on following builders:
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4609)
https://codereview.chromium.org/1271583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
lgtm
https://codereview.chromium.org/1271583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1261433007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/31 21:36:18, krasin wrote:
On 2015/07/31 21:26:13, Michael Achenbach wrote:
On 2015/07/31 15:41:52, krasin wrote:
Michael,
the internal error looks familiar. See
https://crbug.com/513074
https://codereview.chromium.org/1249273003/
Thank you for working on this!
There
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1269753002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1269753002/40001
https://codereview.chromium.org/1269753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1263183002/ by machenb...@chromium.org.
The reason for reverting is: Committing more than one CL at a time led to
some
odd buildbot behavior on the console (probably an independent bug)..
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1263183002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1263183002/1
https://codereview.chromium.org/1263183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Benedikt Meurer,
Description:
[turbofan] GraphBuilderTester uses --print-opt-code.
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1256723003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -0 lines):
M
Patchset 1 (id:??) landed as
https://crrev.com/029c8131457d605f559905ede3562c31e2382256
Cr-Commit-Position: refs/heads/master@{#29944}
https://codereview.chromium.org/1263183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1263183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Jakob, Hablich,
Message:
Created Revert of [cq] Increase commit burst delay.
Description:
Revert of [cq] Increase commit burst delay. (patchset #1 id:1 of
https://codereview.chromium.org/1258193003/)
Reason for revert:
Committing more than one CL at a time led to some odd buildbot
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1269753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/b2f56b8599ae6c158eceb1508e7585b8840028a5
Cr-Commit-Position: refs/heads/master@{#29945}
https://codereview.chromium.org/1269753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Hannes Payer,
Description:
After trying once to create a Realm in regress-crbug-501711.js give up
R=hpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1261123003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -1
lgtm
https://codereview.chromium.org/1256723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1256723003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1256723003/1
https://codereview.chromium.org/1256723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm, with one nit
https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):
https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h#newcode107
src/heap/gc-tracer.h:107: MC_SWEEP_RESCAN_LARGE_OBJECTS,
This is actually not
https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):
https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h#newcode107
src/heap/gc-tracer.h:107: MC_SWEEP_RESCAN_LARGE_OBJECTS,
On 2015/07/31 06:51:53, Hannes Payer
lgtm
https://codereview.chromium.org/1261123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1261123003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1261123003/1
https://codereview.chromium.org/1261123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
I like it a lot, it is way simpler now! Looking almost good. A few comments
left.
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h#newcode358
On 2015/07/31 07:17:01, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/029c8131457d605f559905ede3562c31e2382256
Cr-Commit-Position: refs/heads/master@{#29944}
lgtm
https://codereview.chromium.org/1263183002/
--
--
v8-dev mailing list
Try jobs failed on following builders:
v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/6416)
v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED,
Committed patchset #1 (id:1)
https://codereview.chromium.org/1261123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1267773004/diff/20001/build/download_gold_plugin.py
File build/download_gold_plugin.py (right):
https://codereview.chromium.org/1267773004/diff/20001/build/download_gold_plugin.py#newcode3
build/download_gold_plugin.py:3: # Copyright 2015 The Chromium
PTAL
https://codereview.chromium.org/1260283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1266983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/f8a4afa7bdc6304946e5ed63a196db6e84fd7755
Cr-Commit-Position: refs/heads/master@{#29952}
https://codereview.chromium.org/1266983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Ben, could you take a look please, thanks.
https://codereview.chromium.org/1269683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Ben, could you take a look please, thanks.
https://codereview.chromium.org/1269683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc
File test/cctest/interpreter/test-interpreter.cc (right):
https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc#newcode31
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/testing/gmock to 0421b6f358139f02e102c9c332ce19a33faf75be
Rolling v8/testing/gtest to 9855a87157778d39b95eccfb201a9dc90f6d61c6
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1271653002/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1271653002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1271653002/1
https://codereview.chromium.org/1271653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/11eb702e51f52b70bcf5eb1ab4081625dbd489f7
Cr-Commit-Position: refs/heads/master@{#29960}
https://codereview.chromium.org/1271653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1271653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/07/31 15:41:52, krasin wrote:
Michael,
the internal error looks familiar. See
https://crbug.com/513074
https://codereview.chromium.org/1249273003/
Thank you for working on this!
There might well be a connection. What puzzles me though is that the CL you
refer to is already
On 2015/07/31 21:26:13, Michael Achenbach wrote:
On 2015/07/31 15:41:52, krasin wrote:
Michael,
the internal error looks familiar. See
https://crbug.com/513074
https://codereview.chromium.org/1249273003/
Thank you for working on this!
There might well be a connection. What puzzles me
lgtm
https://codereview.chromium.org/1264913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/d5419bb6b4aad8b4e6cc1cb55dd9af0a1889765c
Cr-Commit-Position: refs/heads/master@{#29947}
https://codereview.chromium.org/1269743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1269743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Great idea!
LGTM.
https://codereview.chromium.org/1261973004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Updates:
Status: Assigned
Owner: mvstan...@chromium.org
Cc: jkumme...@chromium.org
Labels: Area-Runtime Type-Bug Priority-High
Comment #1 on issue 4338 by habl...@chromium.org: Segfault when vector ICs
are enabled on ARMv6
Updates:
Summary: Function name constant does not respect strict mode on first
compile.
Comment #5 on issue 4336 by yang...@chromium.org: Function name constant
does not respect strict mode on first compile.
https://code.google.com/p/v8/issues/detail?id=4336
(No comment was entered for
Status: Untriaged
Owner:
New issue 4338 by mic.bes...@gmail.com: Segfault when vector ICs are
enabled on ARMv6
https://code.google.com/p/v8/issues/detail?id=4338
Version: 4.4.63.25
OS: Raspbian
Architecture: ARM
The bug happens on io.js, on the branch that is trying to integrate latest
Reviewers: mvstanton,
Description:
Add debug mode flag to force recompiling debug code for verification.
The flag is called --always-recompile-debug
Please review this at https://codereview.chromium.org/1261973004/
Base URL: https://chromium.googlesource.com/v8/v8.git@allassert
Affected
Reviewers: titzer,
Message:
PTAL. As discussed, this will be tested
byhttps://codereview.chromium.org/1269683002/, but I will add an explicit
test
when I return from vacation on Aug 10th.
Description:
[turbofan] Fix kArchTailCallCodeObject on ia32/x64.
Previously these instructions tried to
Reviewers: mvstanton,
Description:
Create function name const assignment after parsing language mode.
Otherwise we may choose sloppy const or strict const depending on
whether the function is parsed the first time.
R=mvstan...@chromium.org
BUG=v8:4336
LOG=N
Please review this at
1 - 100 of 141 matches
Mail list logo
