Re: [v8-dev] Re: Is the LOG= line still useful?

I agree with Dan. I think it make more sense to simply use a tracking bug. +Michael Achenbach any objections? On Wed, Jan 20, 2016 at 10:37 PM Adam Klein wrote: > Some stats on the ChangeLog in the 4.9 branch: > > - Out of 385 minor revisions, 60

Re: [v8-dev] A bug in android-sync tool

can you login with your samsung address on codereview.chromium.org? If not, did you ever create a google account for that address? best -jochen On Thu, Jan 21, 2016 at 12:08 PM 'Daniel Vogelheim' via v8-dev < v8-dev@googlegroups.com> wrote: > On Thu, Jan 21, 2016 at 10:36 AM, Yang Guo

Re: [v8-dev] A bug in android-sync tool

On Thu, Jan 21, 2016 at 10:36 AM, Yang Guo wrote: > This looks like a necessary change, Thanks! Daniel, Ulan, does this look > right to you guys? > The change looks good, assuming that sync_file does nothing if the source file doesn't exist. The default build now uses the

Re: [v8-dev] A bug in android-sync tool

Hi Yang, Thank you, that's fine if you can make the change for me. In CLA, it's bangfu@samsung.com. But I tried both IDs, neither of them worked. Thanks Bangfu On Thu, Jan 21, 2016 at 9:36 AM, Yang Guo wrote: > Hi Bangfu, > > This looks like a necessary change,

[v8-dev] A bug in android-sync tool

Hi, I noticed a bug in android-sync.sh, which caused the android_arm.release.check unittests crash on device. It is fixed by adding: sync_file "$OUTDIR/$ARCH_MODE/natives_blob.bin" sync_file "$OUTDIR/$ARCH_MODE/snapshot_blob.bin" I would like to upload the changes, but it failed to create CL.

Re: [v8-dev] A bug in android-sync tool

Yup. I can confirm that address for having signed the CLA. On Thu, Jan 21, 2016 at 11:16 AM Bangfu Tao wrote: > Hi Yang, > > Thank you, that's fine if you can make the change for me. > > In CLA, it's bangfu@samsung.com. But I tried both IDs, neither of > them worked. >

Re: [v8-dev] A bug in android-sync tool

Hi Bangfu, This looks like a necessary change, Thanks! Daniel, Ulan, does this look right to you guys? While I have no clue what may be wrong with the depot tools authentication, I cannot confirm that you have signed the CL with your address " bangfu...@gmail.com". Would it be alright with you if

Re: [v8-dev] Re: Is the LOG= line still useful?

I'd like to separate the questions of requiring LOG= lines and requiring BUG= lines. I think the former is clearly not doing much for us (given my exploration of the data). For the latter, I think there's a variety of workflows used by folks on the team, and forcing tracking bugs for every patch

Re: [v8-dev] Re: Is the LOG= line still useful?

To clarify, I wasn't arguing that all of those workflows should have BUG= lines. Dan On Thu, Jan 21, 2016 at 10:41 AM, Adam Klein wrote: > I'd like to separate the questions of requiring LOG= lines and requiring > BUG= lines. I think the former is clearly not doing much for

Re: [v8-dev] A bug in android-sync tool

Hi Jochen, I can also login with Samsung address on codereview.chromium.org. Just wondering, do I need to do "git cl config"? If yes, please show me how to. Thanks Bangfu On Thu, Jan 21, 2016 at 11:30 AM, Jochen Eisinger wrote: > can you login with your samsung address