Re: [v8-dev] Side effect of increasing max_old_space_size

2018-02-06 Thread Ben Noordhuis
On Tue, Feb 6, 2018 at 8:43 PM, wrote: > Hi v8 devs, > I'm working on VSCode and looking into on large file (Gigabyte files) > improvement. As VSCode is Electron based and currently we load the whole > file into memory (we can do mmap), we easily run into heap size limit.

[v8-dev] Side effect of increasing max_old_space_size

2018-02-06 Thread penn . lv
Hi v8 devs, I'm working on VSCode and looking into on large file (Gigabyte files) improvement. As VSCode is Electron based and currently we load the whole file into memory (we can do mmap), we easily run into heap size limit

[v8-dev] Re: Profiling WASM code.

2018-02-06 Thread Pierre Langlois
Clemens Hammacher writes: > Please go ahead and open a bug for this. I saw at least one TODO about > profiling support for native wasm code, but having a bug to track progress > seems appropriate. Whoops, I realized I only have permissions to create bug reports. I cannot open a

[v8-dev] Re: Profiling WASM code.

2018-02-06 Thread 'Clemens Hammacher' via v8-dev
Please go ahead and open a bug for this. I saw at least one TODO about profiling support for native wasm code, but having a bug to track progress seems appropriate. We should also find out how to add regression tests for this. Can you provide insights there? On Tue, Feb 6, 2018 at 2:23 PM Pierre

[v8-dev] Profiling WASM code.

2018-02-06 Thread Pierre Langlois
Hi all, We realized we were lacking support for profiling asm.js and WASM, via the --prof or --perf-prof flags for instance. A quick look showed we'd need to register WasmCode objects with the logging infrastructure, probably in the same way as the new InstructionStream support [0]. I was going