lgtm with nits
https://codereview.chromium.org/1105793002/diff/160001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/1105793002/diff/160001/src/compiler/register-allocator.cc#newcode2683
Reviewers: Toon Verwaest,
Message:
ptal
Description:
poor man's global double tracking
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1117843002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+18, -6 lines):
M
On 2015/04/29 20:55:12, brucedawson wrote:
This change makes kUninitialized and kUndefined have the same value, where
they
used to be distinct. I noticed this because the /analyze builder gave a
new
warning pointing out that there was some redundant code. The warning is:
On 2015/04/30 09:23:30, dcarney wrote:
ptal
nm, breaks a few things, perf doesn't seem great
https://codereview.chromium.org/1117843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1119683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1105793002/diff/120001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/1105793002/diff/120001/src/compiler/register-allocator.cc#newcode909
src/compiler/register-allocator.cc:909: std::ostream
if we ever care able the allocated registers in the frame after code
generation,
they should be marked here
https://codereview.chromium.org/1112823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1112823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1116633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1105793002/diff/11/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1105793002/diff/11/src/compiler/register-allocator.h#newcode12
src/compiler/register-allocator.h:12: #include iostream
I'd still have that stream available under DEBUG only, though.
that wouldn't be consistent with the rest of v8, just expose it
unconditionally
https://codereview.chromium.org/1105793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
couple minor comments, everything else looks fine is you clean up all the
printing stuff
https://codereview.chromium.org/1105793002/diff/11/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
Reviewers: jarin,
Message:
ptal
Description:
[turbofan] add MachineType to AllocatedOperand
- allows the optimization of emitted gap move code since the representation
of
the value in the register is known
- necessary preparation for vector register allocation
- prepare for slot sharing for
lgtm
https://codereview.chromium.org/1108313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1053123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1112503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
thanks, was wondering about if i covered that branch correctly
lgtm
https://codereview.chromium.org/1102243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
lgtm
https://codereview.chromium.org/1107843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1107853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1093183004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
adding a few comments i left out before because i wanted to get this landed.
Please address them in a followup cl at some point. no hurry
https://codereview.chromium.org/1061923005/diff/430001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
lgtm
https://codereview.chromium.org/1090393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm, after the below comments are done
you should be able to check the cq box now that you've gotten my lgtm
https://codereview.chromium.org/1061923005/diff/370001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
Reviewers: Toon Verwaest,
Message:
ptal. this fixes that crash by bailing out instead of messing with the
cell. it
rarely happens so should be okay
Description:
Reland: track global accesses to constant types
R=verwa...@chromium.org
BUG=
Please review this at
/1062163005/diff/260001/src/hydrogen.cc#newcode6633
src/hydrogen.cc:6633: AddHCheckSmi(value);
same questions as in the code stub
https://codereview.chromium.org/1062163005/diff/260001/src/hydrogen.cc#newcode6645
src/hydrogen.cc:6645: // TODO(dcarney): bailout here or deopt?
what to do here
okay, please refactor one more time after
https://codereview.chromium.org/1100713003/ lands. you'll just need to
extend
RegisterAllocator
the only change i'd like is that the code comes in order of appearance in
the
header, as it's all currently ordered by phases, meaning both
lgtm
https://codereview.chromium.org/1096693011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1051393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1095083002/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/1095083002/diff/1/include/v8.h#newcode3434
include/v8.h:3434: size_t byte_length, bool is_external = true);
no bool args! use enum class outside of class (in v8::
quick update
i'm currently splitting the register allocator into little pieces, which
will
make your cl smaller and more focused. it'll require some rebasing on your
part... will update when everything's in place
https://codereview.chromium.org/1061923005/
--
--
v8-dev mailing list
lgtm
https://codereview.chromium.org/1080633006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: titzer,
Message:
On 2015/04/20 13:33:53, titzer wrote:
Looks good, just one more slice.
https://codereview.chromium.org/1094063002/diff/11/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
okay, phase one of the refactor is here and will land soon:
https://codereview.chromium.org/1094063002/
this is going to change some things for you:
I was forced, due to no one coming up with a better name, to introduce a
RegisterAllocationData class, which means there is no way you can have a
On 2015/04/20 18:31:44, Mircea Trofin wrote:
Updated after the refactoring.
Consolidated some common functionality into helper utility functions (see
GetRegisterCount and GetFixedRegisters).
Moved (opportunistically) stateless, live range-splitting APIs to
RegisterAllocationData, since
I agree with you, in the short term, it's safest to leave the current APIs
as-is, and I'll add separately whatever I need for the backtracking
allocator
-
perhaps as members to GreedyAllocator.
Once I'm done with the port, I intend to look for opportunities for
refactoring
/ cleanup. If
Okay, style-wise you're looking good. I don't want to comment on the
implementation of GreedyAllocator at all since it'll completely change I
assume.
I left some comments on RegisterAllocationInfo since that seemed more
likely to
be stable.
Maybe we could chat sometime this week about ways
);
On 2015/04/19 16:13:38, Mircea Trofin wrote:
On 2015/04/19 12:21:01, dcarney wrote:
size != 0
not DCHECK_NE(0, size)? I went with this, in the spirit of DCHECK_EQ -
but let
me know
yeah, DCHECK_NE is better if it compiles. for size_t there's an issue
in our DCHECK implementation
you still have a bunch of places where you are comparing against zero/null
without making it explicit.
at least the following variables are still camel-cased in the header or the
implementation file: regId, regNr, thisMax, maxConflicting, currentPair,
allocInfo, useCount.
one last style thing.
first round of comments: mostly to do with v8 style/peculiarities
https://codereview.chromium.org/1061923005/diff/160001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
As discussed in person, we take dependencies on property cells if the code
depends either on it being a constant or just existing (i.e. not being
deleted).
We could separate the cases in the future.
I just ran across this name and found it confusing as hell.
AssumePropertyCellValid might be
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
[turbofan] cleanup ParallelMove
- make ParallelMove into a ZoneVector, removing an annoying level of
indirection
- make MoveOperands hold InstructionOperands instead of pointers, so
there's no
more operand aliasing for moves
- opens
not throwing an exception and returning a bool instead sounds fine.
that would be inconsistent with the entire rest of the api. you have to
allow
the exception to propagate
https://codereview.chromium.org/1073953004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
It might be worth having a fast-path in C++ for the no existing property,
extensible object case. I don't think that's too much duplication,
really.
while this is totally reasonable, it's problematic as we really, really
want to
limit the number of implementations of the same thing, which
https://codereview.chromium.org/1073953004/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/1073953004/diff/20001/include/v8.h#newcode2689
include/v8.h:2689: V8_WARN_UNUSED_RESULT MaybeLocalValue
DefineObjectProperty(
On 2015/04/15 16:31:53, adamk wrote:
Why
On 2015/04/15 19:14:12, adamk wrote:
Oh, I think I see the confusion. Of course for cases where we have no
choice
but
to throw (say, worker termination) this can throw. What I'm suggesting is
that
the underlying operation not throw when defining the property fails.
that's right. could be
lgtm
https://codereview.chromium.org/1073953004/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1073953004/diff/1/src/api.cc#newcode3449
src/api.cc:3449: auto obj = Utils::OpenHandle(this);
most of these got renamed to 'self'
Reviewers: Benedikt Meurer,
Message:
On 2015/04/14 07:45:03, dcarney wrote:
mailto:dcar...@chromium.org changed reviewers:
+ mailto:bmeu...@chromium.org
ptal, probably not the most efficient possible solution, but almost
certainly
better than what we currently have
Description:
[turbofan
lgtm
https://codereview.chromium.org/1088913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1083943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1083083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1083933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
do we know for which cpus this matters? instead of the comment, maybe
something
like EmitMoveForRegisterRenamer() or something would be better?
https://codereview.chromium.org/1081033003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Reviewers: jochen, Hannes Payer, Erik Corry Chromium.org,
Message:
ptal
Description:
collect phantom handle data before it gets overwritten
R=joc...@chromium.org, hpa...@chromium.org, erikco...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1064713005/
Base URL:
https://codereview.chromium.org/1064713005/diff/20001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/1064713005/diff/20001/src/global-handles.cc#newcode174
src/global-handles.cc:174: !(state() == NEAR_DEATH weakness_type() !=
NORMAL_WEAK);
On
On 2015/04/13 13:13:45, I haz the power (commit-bot) wrote:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1064713005/20001
need to commit to fix blink, i'll do the comment later
https://codereview.chromium.org/1064713005/
--
--
v8-dev mailing
lgtm, assuming you always want MEGAMORPHIC in the keyed case
https://codereview.chromium.org/1067573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: titzer,
Message:
ptal
Description:
[turbofan] support small immediates
R=tit...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1075903002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+81, -38 lines):
M
lgtm
https://codereview.chromium.org/1070003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/04/06 18:05:31, brucedawson wrote:
Please take a look at variable shadowing comment?
https://codereview.chromium.org/755323011/diff/340001/src/compiler/move-optimizer.cc
File src/compiler/move-optimizer.cc (right):
Reviewers: ulan,
Description:
Version 4.2.77.14 (cherry-pick)
Merged d7f25f557c20afe13a383a331208f4a8f05db3a5
use a hash table for the function cache as blink is leaking
functiontemplates
R=u...@chromium.org
BUG=472608
Please review this at https://codereview.chromium.org/1053973002/
Committed patchset #1 (id:1) manually as
e65bd3efa19fb96186900ea88809a78347bf23aa.
https://codereview.chromium.org/1053973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Reviewers: titzer,
Message:
ptal
Description:
[turbofan] cleanup InstructionOperand a little
- ConstantOperand was using a too-small field too store its virtual register
- drop ConvertTo, replace it with simple copy
- split AllocatedOperand off from Immediate and Constant to make assignment
Reviewers: Sven Panne,
Message:
ptal
Description:
make ToLocalCheck crash in release mode
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1043363005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -4 lines):
M
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1057873003/ by dcar...@chromium.org.
The reason for reverting is: breaks some devtools things.
https://codereview.chromium.org/1043363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Sven Panne, Michael Achenbach (travelling),
Message:
Created Revert of make ToLocalCheck crash in release mode
Description:
Revert of make ToLocalCheck crash in release mode (patchset #1 id:1 of
https://codereview.chromium.org/1043363005/)
Reason for revert:
breaks some devtools
Reviewers: titzer,
Message:
ptal
Description:
[turbofan] smash GapInstruction into Instruction
R=tit...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1041163002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+519, -586 lines):
M
lgtm, assuming all that assembler/disassembler stuff is correct.
https://codereview.chromium.org/1044793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Sven Panne,
Message:
ptal
Description:
ensure maybe results are checked in v8.h
also some drive-by handlescope fixes in api.cc
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1040043002/
Base URL:
lgtm
https://codereview.chromium.org/1046893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
ptal
Description:
fix reconfigure of indexed integer exotic objects
R=verwa...@chromium.org
BUG=466084
LOG=N
Please review this at https://codereview.chromium.org/1037213002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+9,
lgtm
https://codereview.chromium.org/1036233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest, Dmitry Lomov (chromium),
Message:
On 2015/03/27 13:30:15, dcarney wrote:
mailto:dcar...@chromium.org changed reviewers:
+ mailto:dslo...@chromium.org
dmitry, is this correct? Do i need to match Infinity and -Infinity as
well. As
the patch stands, -Infinity
On 2015/03/27 14:30:52, Toon Verwaest wrote:
https://codereview.chromium.org/1038313004/diff/20001/src/conversions.cc
File src/conversions.cc (right):
https://codereview.chromium.org/1038313004/diff/20001/src/conversions.cc#newcode521
src/conversions.cc:521: if (buffer[offset] == '0') return
https://codereview.chromium.org/998253006/diff/60001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/998253006/diff/60001/include/v8-util.h#newcode328
include/v8-util.h:328: p.Reset();
On 2015/03/26 10:07:10, Erik Corry wrote:
Why do we have to create a
Reviewers: jochen, Erik Corry Chromium.org,
Message:
ptal
Description:
two pass phantom collection
R=joc...@chromium.org, erikco...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/998253006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected
ok, looking better. please take another look
https://codereview.chromium.org/998253006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
+241,27 @@ bool FunctionTemplateInfo::IsTemplateFor(Map* map) {
// TODO(dcarney): CallOptimization duplicates this logic, merge.
-Object* FunctionTemplateInfo::GetCompatibleReceiver(Isolate* isolate,
-Object* receiver) {
+HandleObject
lgtm
https://codereview.chromium.org/1029383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1031803004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1036433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jochen (slow), Erik Corry Chromium.org,
Message:
ptal
Description:
fix disposal of phantom handles in GlobalValueMap
additionally, add a drive by fix to WeakCallbackInfo
R=joc...@chromium.org, erikco...@chromium.org
BUG=
Please review this at
lgtm
https://codereview.chromium.org/1009123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Message:
ptal
Description:
[turbofan] add non fixed slot constraint to register allocator
R=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1018853003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+224, -59
lgtm
https://codereview.chromium.org/1028553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1021183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
would be nice if we could share that info somehow. i'm sure this is not the
last time such a pattern will appear
https://codereview.chromium.org/1028563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
lgtm
https://codereview.chromium.org/1023123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1015983003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
okay, ptal
https://codereview.chromium.org/962613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1019563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1015643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/03/17 09:14:05, dcarney wrote:
lgtm
it would be preferred to pass the isolate in the messagecallback, would
that be
okay? if so, i'll prepare a cl to change the callback instead
https://codereview.chromium.org/1015643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http
It would work either way, I don't have strong opinion on that. I'd rather
incorporate error object passed as a separate parameter to MessageCallback
into
Message object and have MessageCallback accept single parameter. What's
the
advantage of passing Isolate as a separate parameter?
it's
On 2015/03/17 10:30:12, yurys wrote:
On 2015/03/17 10:25:25, dcarney wrote:
It would work either way, I don't have strong opinion on that. I'd
rather
incorporate error object passed as a separate parameter to
MessageCallback
into
Message object and have MessageCallback accept single
https://codereview.chromium.org/1016803002/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1016803002/diff/40001/src/objects-inl.h#newcode1898
src/objects-inl.h:1898: DCHECK(!val-IsPropertyCell()
!val-IsCell());
the overloaded setter for
https://codereview.chromium.org/1003663002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1003663002/diff/1/src/api.cc#newcode2678
src/api.cc:2678: bool Value::IsInt32() const { return
Utils::OpenHandle(this)-IsInt32(); }
i don't think v8 cares internally about this
lgtm
https://codereview.chromium.org/998283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1005693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1003663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
ptal - the handler-compiler change is hacky atm as i didn't want to deal
with
cross platform changes until you're okay with the lookup changes
Description:
add interceptors which do not mask existing properties
R=verwa...@chromium.org
BUG=
Please review
1 - 100 of 1319 matches
Mail list logo
