Re: [v8-dev] Changing Error Message and Respective Variables

2025-06-30 Thread Ellison Chen
Good to know, thanks for the clarification! I appreciate the thorough explanation! On Monday, June 30, 2025 at 4:47:13 AM UTC-4 ma...@chromium.org wrote: > In addition to Jakob's point, changing error messages is often more work > than we initially think, since dependencies (for V8, most import

Re: [v8-dev] Changing Error Message and Respective Variables

2025-06-30 Thread Marja Hölttä
In addition to Jakob's point, changing error messages is often more work than we initially think, since dependencies (for V8, most importantly, Chromium) depend on error messages being a certain string, and require changes, e.g., updating the tests, when we change error messages. That's not how the

Re: [v8-dev] Changing Error Message and Respective Variables

2025-06-30 Thread Jakob Kummerow
Frankly, I don't think this is worth anyone's time. "fallthru" is a fairly common alternative spelling; people may disagree on whether they prefer it over the official spelling or not, but it's not a typo, not a bug, and not causing confusion; so just leave it. If you want to contribute to V8, that

Re: [v8-dev] Changing Error Message and Respective Variables

2025-06-30 Thread Clemens Backes
As noted on the CL , I think renaming everything is the right fix. On Mon, Jun 30, 2025 at 10:19 AM Ellison Chen < jialiang.ellison.c...@gmail.com> wrote: > Hello, > > I'm new to the community and wanted to just change the spelling of a > fallthrough error message, se

[v8-dev] Changing Error Message and Respective Variables

2025-06-30 Thread Ellison Chen
Hello, I'm new to the community and wanted to just change the spelling of a fallthrough error message, seen in this issue in the Node.js repo which suggests that the spelling should be corrected upstream, to v8. I'm looking into changing the spelli