Patchset 3 (id:??) landed as
https://crrev.com/ef52836cd8c1340cf0c5054560fc936d6de1d25e
Cr-Commit-Position: refs/heads/master@{#30166}
https://codereview.chromium.org/1290013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1290013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
https://codereview.chromium.org/1290013002/diff/20001/test/mjsunit/harmony/new-target.js
File test/mjsunit/harmony/new-target.js (right):
https://codereview.chromium.org/1290013002/diff/20001/test/mjsunit/harmony/new-target.js#newcode390
test/mjsunit/harmony/new-target.js:390: assertThrows(funct
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1290013002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1290013002/40001
https://codereview.chromium.org/1290013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
lgtm
https://codereview.chromium.org/1290013002/diff/20001/test/mjsunit/harmony/new-target.js
File test/mjsunit/harmony/new-target.js (right):
https://codereview.chromium.org/1290013002/diff/20001/test/mjsunit/harmony/new-target.js#newcode390
test/mjsunit/harmony/new-target.js:390: assertThro
On 2015/08/13 00:45:56, adamk wrote:
On 2015/08/13 00:35:33, caitp wrote:
> On 2015/08/13 00:29:51, adamk wrote:
> > On 2015/08/12 23:58:04, adamk wrote:
> > > On 2015/08/12 23:51:42, caitp wrote:
> > > > On 2015/08/12 23:39:29, adamk wrote:
> > > > > Note that the preparser already (accidentally
On 2015/08/13 00:35:33, caitp wrote:
On 2015/08/13 00:29:51, adamk wrote:
> On 2015/08/12 23:58:04, adamk wrote:
> > On 2015/08/12 23:51:42, caitp wrote:
> > > On 2015/08/12 23:39:29, adamk wrote:
> > > > Note that the preparser already (accidentally) seems to throw an
error
> here,
> > > > be
On 2015/08/13 00:29:51, adamk wrote:
On 2015/08/12 23:58:04, adamk wrote:
> On 2015/08/12 23:51:42, caitp wrote:
> > On 2015/08/12 23:39:29, adamk wrote:
> > > Note that the preparser already (accidentally) seems to throw an
error
here,
> > > because its implementation of IsValidReferenceExpre
On 2015/08/12 23:58:04, adamk wrote:
On 2015/08/12 23:51:42, caitp wrote:
> On 2015/08/12 23:39:29, adamk wrote:
> > Note that the preparser already (accidentally) seems to throw an error
here,
> > because its implementation of IsValidReferenceExpression() is:
> >
> > bool IsValidReferenceExp
On 2015/08/12 23:51:42, caitp wrote:
On 2015/08/12 23:39:29, adamk wrote:
> Note that the preparser already (accidentally) seems to throw an error
here,
> because its implementation of IsValidReferenceExpression() is:
>
> bool IsValidReferenceExpression() const {
> return IsIdentifier()
On 2015/08/12 23:39:29, adamk wrote:
Note that the preparser already (accidentally) seems to throw an error
here,
because its implementation of IsValidReferenceExpression() is:
bool IsValidReferenceExpression() const {
return IsIdentifier() || IsProperty();
}
and NewTargetExpre
Note that the preparser already (accidentally) seems to throw an error here,
because its implementation of IsValidReferenceExpression() is:
bool IsValidReferenceExpression() const {
return IsIdentifier() || IsProperty();
}
and NewTargetExpression is a PreParserExpression::Default().
htt
12 matches
Mail list logo
