What is the use-case for building V8 with the v120_xp toolset? Is that
something
that we need to support?
When I wrote my fix I was unaware of how to detect which Windows SDK was
being
used. I have since learned how. You need to #include ntverp.h and then
test
VER_PRODUCTBUILD, as shown
lgtm.
While I agree that volatile has no useful meaning for multi-threading, it
does
prevents some wilder compiler optimizations, and in the absence of any other
synchronization primitives it might be better than nothing. I think it is
fine
to leave out 'volatile' here because the
Committed patchset #1 (id:1)
https://codereview.chromium.org/1228063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/b2ed25304e203bbd22d6b09db575980f6aecf30a
Cr-Commit-Position: refs/heads/master@{#29687}
https://codereview.chromium.org/1228063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1228063005/1
https://codereview.chromium.org/1228063005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
