[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-13 Thread binji
https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc#newcode1693 src/d8.cc:1693: if (base::NoBarrier_CompareAndSwap(join_called_, false, true) == false) { On 2015/07/13 at 06:08:53, jarin wrote:

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-13 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226143003/11 https://codereview.chromium.org/1226143003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-13 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #6 (id:11) https://codereview.chromium.org/1226143003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-13 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226143003/80001 https://codereview.chromium.org/1226143003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-13 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/4533) (exceeded global retry quota) https://codereview.chromium.org/1226143003/ -- -- v8-dev mailing list

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-13 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 6 (id:??) landed as https://crrev.com/7036a0b1b8206c9d971a28bc523c8d7a2d529e43 Cr-Commit-Position: refs/heads/master@{#29626} https://codereview.chromium.org/1226143003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-13 Thread jarin
lgtm https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc#newcode1693 src/d8.cc:1693: if (base::NoBarrier_CompareAndSwap(join_called_, false, true) == false) { It looks like join_called_ is

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-10 Thread jarin
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#newcode1703 src/d8.cc:1703: case STOPPED: Why do we want to retry when STOPPED? Actually, I am even confused why we are trying to go through the

[v8-dev] Re: d8: Fix some TSAN bugs (issue 1226143003 by bi...@chromium.org)

2015-07-10 Thread binji
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#newcode1703 src/d8.cc:1703: case STOPPED: On 2015/07/10 at 10:43:17, jarin wrote: Why do we want to retry when STOPPED? Actually, I am even