Re: [v8-users] Profiling: what is "LoadIC: A load IC from the snapshot"?

2018-03-01 Thread Andrew Wilcox
> > Depending on usage patterns, you might see a further speed boost if you > split your objects into two parts, where one has the same shape for all > objects and the other is type dependent > Oh interesting idea! Thanks! -- -- v8-users mailing list v8-users@googlegroups.com

Re: [v8-users] Profiling: what is "LoadIC: A load IC from the snapshot"?

2018-03-01 Thread Jakob Kummerow
Depending on usage patterns, you might see a further speed boost if you split your objects into two parts, where one has the same shape for all objects and the other is type dependent, roughly: class Thing { constructor(type, specific, ...) { this.type = type; this.other_common_field =

Re: [v8-users] Profiling: what is "LoadIC: A load IC from the snapshot"?

2018-03-01 Thread Andrew Wilcox
> > can anyone tell me what LoadIC is? > > > The thing that handles property loads (like foo.bar;). Thank you Jacob! Seeing it take 22% is rare. Is your app heavy on polymorphic property loads? Yes, I'm writing an interpreter and it was doing a *lot* of instanceof checks. Since I

Re: [v8-users] Profiling: what is "LoadIC: A load IC from the snapshot"?

2018-03-01 Thread Jakob Kummerow
The thing that handles property loads (like foo.bar;). Seeing it take 22% is rare. Is your app heavy on polymorphic property loads? On Thu, Mar 1, 2018 at 9:44 AM Andrew Wilcox wrote: > My prof output starts off with > > [JavaScript]: >ticks total nonlib name

Re: Re: [v8-users] mksnapshot and warm_up

2018-03-01 Thread ramonpf1950
Thanks for emailing me! No, I haven’t been hacked :) I signed up for a spam filtering service called BitBounce. To deliver your email to my inbox, please click the link below. Thanks! https://bitbounce.com/pay_bitbounce_fee/4119332566 BitBounce is a product by: Turing Technology, Inc.

[v8-users] Profiling: what is "LoadIC: A load IC from the snapshot"?

2018-03-01 Thread Andrew Wilcox
My prof output starts off with [JavaScript]: ticks total nonlib name 12065 22.7% 22.7% LoadIC: A load IC from the snapshot 27325.1%5.1% Builtin: StrictEqual and I was wondering, can anyone tell me what LoadIC is? Thanks! Andrew -- -- v8-users mailing list

Re: [v8-users] mksnapshot and warm_up

2018-03-01 Thread 'Jakob Gruber' via v8-users
AFAIK that's correct. The polluted warmup context is thrown out, and a second clean context (with the now-compiled code) is serialized into the warmed up snapshot. On Thu, Mar 1, 2018 at 5:31 PM, Johannes Rieken wrote: > Great! Thanks for the speedy reply. Looking at

Re: Re: [v8-users] mksnapshot and warm_up

2018-03-01 Thread ramonpf1950
Thanks for emailing me! No, I haven’t been hacked :) I signed up for a spam filtering service called BitBounce. To deliver your email to my inbox, please click the link below. Thanks! https://bitbounce.com/pay_bitbounce_fee/332072661 BitBounce is a product by: Turing Technology, Inc.

Re: [v8-users] mksnapshot and warm_up

2018-03-01 Thread Johannes Rieken
Great! Thanks for the speedy reply. Looking at https://cs.chromium.org/chromium/src/v8/test/cctest/test-serialize.cc?type=cs=CustomSnapshotDataBlobWithWarmup=1167 makes me think/hope that functions are being compiled but state isn't changed (e.g. the assignment to `a` isn't persistent). Is

Re: [v8-users] mksnapshot and warm_up

2018-03-01 Thread 'Jakob Gruber' via v8-users
On Thu, Mar 1, 2018 at 4:43 PM, Johannes Rieken wrote: > > Hey, > > Can someone help me understand what the difference between a warm and cold > snapshot is? I stumbled over `WarmUpSnapshotDataBlob` but I am not > entirely sure how to make use of them via the

[v8-users] mksnapshot and warm_up

2018-03-01 Thread Johannes Rieken
Hey, Can someone help me understand what the difference between a warm and cold snapshot is? I stumbled over `WarmUpSnapshotDataBlob` but I am not entirely sure how to make use of them via the mksnapshot-tools and what the sequence would be. Do I begin with a custom snapshot and then