It is primarily a perf patch, where str.repeat(2^20), etc. no longer hangs
the engine's execution thread.
I'm wanting to assert the following two things:
1. Large numbers as arguments must not hang the engine in the normal case.
The patch provides a reduction in the worst case of algorithmic
And why would anyone care how long it takes to repeat a string a million
times? Especially if that string is empty?
Don't make the test suite slower for this. Ensure correctness, and leave it
at that.
On Thu, Oct 2, 2014 at 9:22 AM, Isiah Meadows impinb...@gmail.com wrote:
It is primarily a
I'll just leave it out, then.
--
--
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
---
You received this message because you are subscribed to the Google Groups
v8-users group.
To unsubscribe from this group and stop receiving emails from it, send an
I don't understand what you're saying. Do you mean your testcase should,
when all is well, finish in a second or two? That's much too slow. Or do
you mean that after 1-2 seconds it would be OK to cancel it and treat it as
a failure, because in the good case it finishes much faster? As I said
On Fri, Sep 26, 2014 at 3:18 PM, Isiah Meadows impinb...@gmail.com wrote:
On Thursday, September 25, 2014 2:01:03 PM UTC-4, Jakob Kummerow wrote:
That depends entirely on the kind of performance delta we're talking
about.
If a particular testcase went from actually hanging (endless loop,
What I need to do for a specific unit test is to run a specific method +
arguments, and if it takes too long, stop the call mid-cycle and fail the
test. This is for a performance-related unit test for my patch (which is a
perf patch itself, anyways). Is this possible, and if so, how would I do
