And why would anyone care how long it takes to repeat a string a million times? Especially if that string is empty?
Don't make the test suite slower for this. Ensure correctness, and leave it at that. On Thu, Oct 2, 2014 at 9:22 AM, Isiah Meadows <impinb...@gmail.com> wrote: > It is primarily a perf patch, where str.repeat(2^20), etc. no longer hangs > the engine's execution thread. > > I'm wanting to assert the following two things: > 1. Large numbers as arguments must not hang the engine in the normal case. > The patch provides a reduction in the worst case of algorithmic runtime > complexity. > 2. Repeating an empty string should be near instantaneous. The patch also > includes a special case where repeating an empty string should be near > instantaneous, regardless of the number of repeats. This case should take > no longer than a few milliseconds on an old, excessively bogged down > machine (even to the point the desktop is hanging), almost ready to fry > itself. > On Sep 29, 2014 12:11 PM, "Jakob Kummerow" <jkumme...@chromium.org> wrote: > >> I don't understand what you're saying. Do you mean your testcase should, >> when all is well, finish in a second or two? That's much too slow. Or do >> you mean that after 1-2 seconds it would be OK to cancel it and treat it as >> a failure, because in the good case it finishes much faster? As I said >> before, there's no need to test this specifically, just make sure all >> affected code paths are tested for correctness. >> >> Can you provide more detail about what precisely it is that you're trying >> to do? I'm getting a bit tired of the guesswork. >> >> >> On Mon, Sep 29, 2014 at 5:42 PM, Isiah Meadows <impinb...@gmail.com> >> wrote: >> >>> Problem then, it should take no more than a second or two. Basically it >>> is a "this should not hang the engine" test. >>> On Sep 26, 2014 9:56 AM, "Jakob Kummerow" <jkumme...@chromium.org> >>> wrote: >>> >>>> On Fri, Sep 26, 2014 at 3:18 PM, Isiah Meadows <impinb...@gmail.com> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Thursday, September 25, 2014 2:01:03 PM UTC-4, Jakob Kummerow wrote: >>>>>> >>>>>> That depends entirely on the kind of performance delta we're talking >>>>>> about. >>>>>> >>>>>> If a particular testcase went from actually hanging (endless loop, or >>>>>> running for hours) to finishing quickly (say, in 1 millisecond), then by >>>>>> all means land that testcase. (You don't have to detect the hang >>>>>> yourself, >>>>>> the test driver already has a timeout for each test.) >>>>>> >>>>> >>>>> Okay. That's pretty much what I needed. My test case would be for the >>>>> former case there (actually hanging). I was more looking for a specific >>>>> case that shouldn't hang. How long is the timeout? >>>>> >>>> >>>> It's chosen dynamically based on a variety of factors, IIRC between a >>>> couple seconds and a few minutes. Do not depend on it. Make sure your >>>> testcase finishes fast (1 millisecond is a good target to aim for). >>>> >>> -- >> > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
