Re: [v8-users] Farewell Callee

I just saw that node.js/nan also uses Callee() so we should try to figure out a way to keep it On Fri, Dec 11, 2015 at 11:20 AM Enrico Pertoso wrote: > I'm reverting in the meantime. > > > On Fri, Dec 11, 2015 at 11:15 AM, Toon Verwaest > wrote: >

Re: [v8-users] Farewell Callee

On Fri, Dec 11, 2015 at 11:23 AM, Jochen Eisinger wrote: > I just saw that node.js/nan also uses Callee() so we should try to figure out > a way to keep it FWIW, node.js core doesn't use .Callee() and I don't think there are many (if any) add-ons that use the nan wrapper.

Re: [v8-users] Farewell Callee

I think Jochen's solution would be better in the long term. Keeping Callee() and instantiating a FunctionTemplate if it gets called seems slightly more complex. In the meantime, should I revert the change (marking Callee as deprecated or deprecate soon)? On Friday, December 11, 2015 at

Re: [v8-users] Farewell Callee

I'm reverting in the meantime. On Fri, Dec 11, 2015 at 11:15 AM, Toon Verwaest wrote: > If embedders don't want to have multiple Callees instantiated from the > same FunctionTemplate, Jochen's solution works. If that's the case, they > could also just mark the

Re: [v8-users] Farewell Callee

Mmh, it doesn't seem possible to instantiated non-caching function-templates multiple times. Nevermind then ;) On Fri, Dec 11, 2015 at 11:15 AM Toon Verwaest wrote: > If embedders don't want to have multiple Callees instantiated from the > same FunctionTemplate, Jochen's

Re: [v8-users] Farewell Callee

If embedders don't want to have multiple Callees instantiated from the same FunctionTemplate, Jochen's solution works. If that's the case, they could also just mark the function-template as caching, and "reinstantiate the template" in the context. That will return the cached function without

Re: [v8-users] Farewell Callee

Update: we reverted the cl for now, so Callee() is back. On Friday, December 11, 2015 at 11:55:07 AM UTC+1, Ben Noordhuis wrote: > > On Fri, Dec 11, 2015 at 11:23 AM, Jochen Eisinger > wrote: > > I just saw that node.js/nan also uses Callee() so we should try to > figure

Re: [v8-users] Find End of Script Execution in V8

Hi Ben, Thanks for your clear explanation. Is there a way to register a hook to a said function. (example a function with name f1()) and get a callback everytime it starts and ends execution. On Friday, December 11, 2015 at 4:25:51 PM UTC+1, Ben Noordhuis wrote: > > On Fri, Dec 11, 2015 at

Re: [v8-users] Find End of Script Execution in V8

On Fri, Dec 11, 2015 at 2:08 PM, Deepak Subramanian wrote: > Hi Ben, > > I found this q very interesting. Could you give me an example of a > AddCallCompletedCallback() ? > > I mean I see it uses a param CallCompletedCallback. Is this a c function > pointer ? what are the

Re: [v8-users] Find End of Script Execution in V8

On Fri, Dec 11, 2015 at 4:53 PM, Deepak Subramanian wrote: > Hi Ben, > > Thanks for your clear explanation. > > Is there a way to register a hook to a said function. (example a function > with name f1()) and get a callback everytime it starts and ends execution. For a

Re: [v8-users] Profiler: Application crash in HandleProfilerSignal

This seems only a problem with debug build. Optimized build works fine. On Friday, December 11, 2015 at 2:05:20 PM UTC-8, Jane Chen wrote: > > 3.24 crashes too. Same JavaScript query, but different stack: > > C stack trace === > > 1: V8_Fatal > 2:

Re: [v8-users] Profiler: Application crash in HandleProfilerSignal

I am seeing a SIGILL crash too with my embedding app during profiling. Here's the stack: Thread [134] (Suspended: Signal 'SIGILL' received. Description: Illegal instruction.) 40 v8::base::OS::Abort() /space/projects/v8-git/v8/src/base/platform/platform-posix.cc:229 0x764bcd11

Re: [v8-users] Profiler: Application crash in HandleProfilerSignal

3.24 crashes too. Same JavaScript query, but different stack: C stack trace === 1: V8_Fatal 2: v8::internal::SafeStackFrameIterator::Advance() 3: v8::internal::SafeStackFrameIterator::SafeStackFrameIterator(v8::internal::Isolate*, unsigned char*, unsigned

Re: [v8-users] Farewell Callee

First, I'm really impressed with this group's responsiveness. Awesome! Second, I apologize if I gave folks extra work to do -- my intent was simply to give a heads up to other embedders. As it turns out, I was able to get rid of my two Callee uses. Jochen's suggestion caused a neuron to fire