Re: [v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Adam Klein 
LGTM3!

On Fri, Feb 9, 2018 at 12:52 PM, Sathya Gunasekaran 
wrote:

> LGTM
>
> On Fri, Feb 9, 2018 at 8:36 AM, Benedikt Meurer 
> wrote:
>
>> LGTM
>>
>>
>> Mathias Bynens  schrieb am Fr., 9. Feb. 2018,
>> 16:36:
>>
>>> Contact emails math...@chromium.org Spec https://github.com/tc39/propos
>>> al-string-left-right-trim Summary Until now,
>>> String.prototype.{trimLeft,trimRight} were non-standard language
>>> extensions, required for Web compatibility. The Stage 3 proposal at
>>> https://github.com/tc39/proposal-string-left-right-trim standardizes
>>> this functionality as String.prototype.{trimStart,trimEnd}, and defines
>>> String.prototype.{trimLeft,trimRight} as aliases for backwards
>>> compatibility. Vendor signals Firefox: Public support Edge: Public
>>> support Safari: In development Web developers: Positive Compatibility
>>> risk
>>> There could be a compatibility risk, but that seems unlikely. We won’t
>>> know for sure until we try shipping it. Ongoing technical constraints
>>> None Will this feature be supported on all six Blink platforms
>>> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
>>> Yes
>>> Tracking bug
>>> https://bugs.chromium.org/p/v8/issues/detail?id=6530 Link to entry on
>>> the Chrome Platform Status https://www.chromestatus.com/f
>>> eatures/479006651936 Requesting approval to ship? Yes
>>>
>>> Note that since this is a V8/JS feature, this post is just an FYI to
>>> blink-dev — no signoff from Blink API owners is required.
>>>
>>> --
>>> --
>>> v8-users mailing list
>>> v8-users@googlegroups.com
>>> http://groups.google.com/group/v8-users
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "v8-users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to v8-users+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>>
>>
>>
>> * •  *
>> *Benedikt Meurer** •  **Google Germany GmbH*
>> * •  *Erika-Mann-Str. 33
>> 
>> * •
>> *80636
>> Munich
>> 
>>
>>  •
>> 
>> bmeu...@google.com
>>
>>
>> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
>>
>> Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft:
>> Hamburg
>>
>> Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
>> leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
>> löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is
>> confidential. If you are not the right addressee please do not forward it,
>> please inform the sender, and please erase this e-mail including any
>> attachments. Thanks.
>>
>> --
>> --
>> v8-users mailing list
>> v8-users@googlegroups.com
>> http://groups.google.com/group/v8-users
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "v8-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to v8-users+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] --print-code does not work

2018-02-09 Thread Jakob Kummerow 
If --print-opt-code prints nothing, then probably your function isn't
getting optimized. Try calling it more often.

--print-code is "technically correct" in the sense that it prints all of
the unoptimized machine code that V8 doesn't generate any more ;-)
(We should remove the flag.)


On Fri, Feb 9, 2018 at 1:18 AM Istvan Tabanyi  wrote:

> Hi,
>
> I compiled v8 from sources successfully, but --print-code/--print-opt-code
> gives me no output at all.
> --print-bytecode works fine, --print-all-code prints something, but the
> actual code is definitely not in the output(Created a simple function with
> unique name, called in a loop, grepped for it and nothing)
>
> Tried release and debug builds, also with custom options like this:
> gn gen out.gn/x64.debug --args='is_debug=true target_cpu="x64"
> v8_target_cpu="x64" v8_enable_disassembler=true'
>
> I tried to look for tutorials on this topic, but most of it really
> outdated and using make/gyp.
> Can someone give me some tips about this? And sorry if this is not the
> right place to ask questions like this.
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Sathya Gunasekaran 
LGTM

On Fri, Feb 9, 2018 at 8:36 AM, Benedikt Meurer 
wrote:

> LGTM
>
>
> Mathias Bynens  schrieb am Fr., 9. Feb. 2018, 16:36:
>
>> Contact emails math...@chromium.org Spec https://github.com/tc39/
>> proposal-string-left-right-trim Summary Until now,
>> String.prototype.{trimLeft,trimRight} were non-standard language
>> extensions, required for Web compatibility. The Stage 3 proposal at
>> https://github.com/tc39/proposal-string-left-right-trim standardizes
>> this functionality as String.prototype.{trimStart,trimEnd}, and defines
>> String.prototype.{trimLeft,trimRight} as aliases for backwards
>> compatibility. Vendor signals Firefox: Public support Edge: Public
>> support Safari: In development Web developers: Positive Compatibility
>> risk
>> There could be a compatibility risk, but that seems unlikely. We won’t
>> know for sure until we try shipping it. Ongoing technical constraints
>> None Will this feature be supported on all six Blink platforms (Windows,
>> Mac, Linux, Chrome OS, Android, and Android WebView)?
>> Yes
>> Tracking bug
>> https://bugs.chromium.org/p/v8/issues/detail?id=6530 Link to entry on
>> the Chrome Platform Status https://www.chromestatus.com/
>> features/479006651936 Requesting approval to ship? Yes
>>
>> Note that since this is a V8/JS feature, this post is just an FYI to
>> blink-dev — no signoff from Blink API owners is required.
>>
>> --
>> --
>> v8-users mailing list
>> v8-users@googlegroups.com
>> http://groups.google.com/group/v8-users
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "v8-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to v8-users+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
>
>
>
> * •  *
> *Benedikt Meurer** •  **Google Germany GmbH*
> * •  *Erika-Mann-Str. 33
> 
> * •
> *80636
> Munich
> 
>
>  •  bmeu...@google.com
>
>
> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
>
> Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft:
> Hamburg
>
> Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
> leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
> löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is
> confidential. If you are not the right addressee please do not forward it,
> please inform the sender, and please erase this e-mail including any
> attachments. Thanks.
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Benedikt Meurer 
LGTM

Mathias Bynens  schrieb am Fr., 9. Feb. 2018, 16:36:

> Contact emails math...@chromium.org Spec
> https://github.com/tc39/proposal-string-left-right-trim Summary Until
> now, String.prototype.{trimLeft,trimRight} were non-standard language
> extensions, required for Web compatibility. The Stage 3 proposal at
> https://github.com/tc39/proposal-string-left-right-trim standardizes this
> functionality as String.prototype.{trimStart,trimEnd}, and defines
> String.prototype.{trimLeft,trimRight} as aliases for backwards
> compatibility. Vendor signals Firefox: Public support Edge: Public
> support Safari: In development Web developers: Positive Compatibility risk
> There could be a compatibility risk, but that seems unlikely. We won’t
> know for sure until we try shipping it. Ongoing technical constraints
> None Will this feature be supported on all six Blink platforms (Windows,
> Mac, Linux, Chrome OS, Android, and Android WebView)?
> Yes
> Tracking bug
> https://bugs.chromium.org/p/v8/issues/detail?id=6530 Link to entry on the
> Chrome Platform Status
> https://www.chromestatus.com/features/479006651936 Requesting
> approval to ship? Yes
>
> Note that since this is a V8/JS feature, this post is just an FYI to
> blink-dev — no signoff from Blink API owners is required.
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 



* •  *
*Benedikt Meurer** •  **Google Germany GmbH*
* •  *Erika-Mann-Str. 33

* •  *80636 Munich


 •  bmeu...@google.com


Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft:
Hamburg

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is
confidential. If you are not the right addressee please do not forward it,
please inform the sender, and please erase this e-mail including any
attachments. Thanks.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Mathias Bynens 
Contact emails math...@chromium.org Spec
https://github.com/tc39/proposal-string-left-right-trim Summary Until now,
String.prototype.{trimLeft,trimRight} were non-standard language
extensions, required for Web compatibility. The Stage 3 proposal at
https://github.com/tc39/proposal-string-left-right-trim standardizes this
functionality as String.prototype.{trimStart,trimEnd}, and defines
String.prototype.{trimLeft,trimRight} as aliases for backwards
compatibility. Vendor signals Firefox: Public support Edge: Public support
Safari: In development Web developers: Positive Compatibility risk
There could be a compatibility risk, but that seems unlikely. We won’t know
for sure until we try shipping it. Ongoing technical constraints
None Will this feature be supported on all six Blink platforms (Windows,
Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes
Tracking bug
https://bugs.chromium.org/p/v8/issues/detail?id=6530 Link to entry on the
Chrome Platform Status
https://www.chromestatus.com/features/479006651936 Requesting approval
to ship? Yes

Note that since this is a V8/JS feature, this post is just an FYI to
blink-dev — no signoff from Blink API owners is required.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[v8-users] --print-code does not work

2018-02-09 Thread Istvan Tabanyi 
Hi,

I compiled v8 from sources successfully, but --print-code/--print-opt-code 
gives me no output at all.
--print-bytecode works fine, --print-all-code prints something, but the 
actual code is definitely not in the output(Created a simple function with 
unique name, called in a loop, grepped for it and nothing)

Tried release and debug builds, also with custom options like this:
gn gen out.gn/x64.debug --args='is_debug=true target_cpu="x64" 
v8_target_cpu="x64" v8_enable_disassembler=true'

I tried to look for tutorials on this topic, but most of it really outdated 
and using make/gyp.
Can someone give me some tips about this? And sorry if this is not the 
right place to ask questions like this.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.