Re: [v8-users] Error graph-builder-tester.h:172:56: error: no matching function for call to 'v8::internal::compiler::SimplifiedOperatorBuilder::ChangeFloat64ToTagged()' when trying to build V8 with GC

2017-08-06 Thread Georgi Sotirov
> > GCC 4.8 is what ships in Ubuntu Trusty, which is still our main > development platform. Usually ensuring that older toolchains are still > supported is more difficult (and hence more important) than supporting > newer toolchains. > Most people build with the bundled clang; GCC support is

Re: [v8-users] Error graph-builder-tester.h:172:56: error: no matching function for call to 'v8::internal::compiler::SimplifiedOperatorBuilder::ChangeFloat64ToTagged()' when trying to build V8 with GC

2017-08-02 Thread Jakob Kummerow
On Wed, Aug 2, 2017 at 1:04 PM, Georgi Sotirov wrote: > Yes, sure. We have gcc-4.8 bots on our waterfall and they're happy. Feel >> free to submit a patch for >> gcc-7.1 support :-) >> > > GCC 4.8 is at least 4 years old and as I

Re: [v8-users] Error graph-builder-tester.h:172:56: error: no matching function for call to 'v8::internal::compiler::SimplifiedOperatorBuilder::ChangeFloat64ToTagged()' when trying to build V8 with GC

2017-08-02 Thread Georgi Sotirov
> Feel free to delete the offending function > (in test/cctest/compiler/graph-builder-tester.h:171-173), it doesn't seem > to be used (which is presumably why clang doesn't complain here). > Sure, I did it and build continues, but isn't this supposed to be fixed upstream? I though V8 is

Re: [v8-users] Error graph-builder-tester.h:172:56: error: no matching function for call to 'v8::internal::compiler::SimplifiedOperatorBuilder::ChangeFloat64ToTagged()' when trying to build V8 with GC

2017-08-01 Thread Jakob Kummerow
Feel free to delete the offending function (in test/cctest/compiler/graph-builder-tester.h:171-173), it doesn't seem to be used (which is presumably why clang doesn't complain here). Also, next time, please indicate the version of V8 that you're compiling. On Tue, Aug 1, 2017 at 8:40 AM, Georgi