Re: [Valgrind-users] identifying error numbers for --vgdb-error

2012-02-14 Thread Rob
One thing that might be relevant is that errors already have a 32 bit value that identifies them uniquely.  struct _Error :: unique You can see them in the XML output, eg ./vg-in-place --xml=yes --xml-fd=1 memcheck/tests/errs1 I would prefer to use them, rather than add yet another kind of

Re: [Valgrind-users] identifying error numbers for --vgdb-error

2012-02-14 Thread Julian Seward
Hmm, this doesn't sound like it's going to be simple to fix in a clean way. For the moment, can we do the incremental fix of taking Philippe's patch (with the off-by-one fixed) ? That's a very simple patch and uncontroversial patch. (Maybe should also backport it for 3.7.1 ?) J On Tuesday,

Re: [Valgrind-users] identifying error numbers for --vgdb-error

2012-02-14 Thread Philippe Waroquiers
On Tue, 2012-02-14 at 13:54 +, Rob wrote: One thing that might be relevant is that errors already have a 32 bit value that identifies them uniquely. struct _Error :: unique You can see them in the XML output, eg ./vg-in-place --xml=yes --xml-fd=1 memcheck/tests/errs1 I would

Re: [Valgrind-users] identifying error numbers for --vgdb-error

2012-02-14 Thread Rob
Hmm, this doesn't sound like it's going to be simple to fix in a clean way. For the moment, can we do the incremental fix of taking Philippe's patch (with the off-by-one fixed) ? That's a very simple patch and uncontroversial patch. (Maybe should also backport it for 3.7.1 ?) Sounds good

Re: [Valgrind-users] identifying error numbers for --vgdb-error

2012-02-14 Thread Philippe Waroquiers
On Tue, 2012-02-14 at 23:52 +0100, Julian Seward wrote: Hmm, this doesn't sound like it's going to be simple to fix in a clean way. For the moment, can we do the incremental fix of taking Philippe's patch (with the off-by-one fixed) ? That's a very simple patch and uncontroversial patch.

Re: [Valgrind-users] identifying error numbers for --vgdb-error

2012-02-10 Thread Philippe Waroquiers
On Fri, 2012-02-10 at 16:01 +, Rob wrote: Thanks for the patch. I have manually applied it to 3.7.0 (not svn) and it is a big improvement. The number seems to be offset by 1 from what I would expect though, eg. --vgdb-error=5 stops after detecting 6 errors. Thanks for the feedback.

[Valgrind-users] identifying error numbers for --vgdb-error

2012-02-09 Thread Rob
The gdbserver is a great new feature but I am having trouble getting it to stop on the desired error. If I have previously run valgrind (eg. overnight) and have the output, I can't seem to determine the correct error count to cause a subsequent run to stop at a particular error.  The count of