Hmm, this doesn't sound like it's going to be simple to fix in a clean way.
For the moment, can we do the incremental fix of taking Philippe's patch (with the off-by-one fixed) ? That's a very simple patch and uncontroversial patch. (Maybe should also backport it for 3.7.1 ?) J On Tuesday, February 14, 2012, Rob wrote: > > One thing that might be relevant is that errors already have a > > 32 bit value that identifies them uniquely. "struct _Error :: unique" > > You can see them in the XML output, eg > > > > ./vg-in-place --xml=yes --xml-fd=1 memcheck/tests/errs1 > > > > I would prefer to use them, rather than add yet another kind of > > error-counter mechanism. But the problem is now to show the user > > what --vgdb-error value is required for each error. The simple > > thing to do is to print a line > > > > Use --vgdb-error=<unique> to make the GDB server stop at this error > > > > Problem is I don't really want to add printing of such lines by > > default. Is it possible that we can make printing of them conditional > > on some other command line option that must be present in order to > > use the gdbserver? > > > > J > > Yes, allowing the <unique/> numbers in place of a count would be good. It > wouldn't necessarily have to print the full usage method above as this > could be documented in the manual. How about appending the numbers at the > end of each error line, either by default or with an option? > > ==14600== Syscall param write(buf) points to uninitialised byte(s) > (uid=0x2f9) > > In my usage scenario I wouldn't normally be using the gdb server, only for > specific reruns. I would therefore have the above output turned on all > the time, just in case I need it later, assuming it weren't too verbose. > > thanks, > Rob > > --------------------------------------------------------------------------- > --- Keep Your Developer Skills Current with LearnDevNow! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-d2d > _______________________________________________ > Valgrind-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/valgrind-users ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Valgrind-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/valgrind-users
