Re: [vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-20 Thread Klaus Schmidinger 

On 20.03.2013 18:02, Paul Menzel wrote:

Am Sonntag, den 17.03.2013, 18:06 +0100 schrieb Klaus Schmidinger:

On 17.03.2013 18:00, Carsten Koch wrote:

On 03/17/13 13:00, Klaus Schmidinger wrote:

On 17.03.2013 12:46, Ville Skyttä wrote:

Hello,

Should probably have spoken earlier, but is there any particular reason
for the ugly and hard to read Makefile variable names LCLBLD and PLGCFG?
I suppose they're short for LOCALBUILD and PLUGINCONFIG, but why do they
have to be short for anything, it's not like we're running out of space
for their names anywhere, is it? Besides, I don't think LCLBLD describes
what its effects are very well, INPLACE would sounds better to me.

The ship may already have sailed for plgcfg in vdr.pc as it's being used
by many plugin Makefiles already, but I believe the attached patches
should be safe for 2.0.0.


I'm afraid it's too late for that.


I do not understand why it should be too late.
2.0 is not out yet.


But we're in the final testing phase.
Besides, Ville's patch also touched the Makefiles of plugins - and
plugin authors and distribution managers react very intense when they
have to modify their files ;-).


If I am not mistaken, Ville’s issue was that the names were not clear.
Could a comment be added to the Makefile what the meaning is then. That
should not break anything.


Something like this?

# Use 'make LCLBLD=1' to build locale and plugin files under the source 
directory:
ifdef LCLBLD
...

# Use this if you want to have a central place where you configure compile time
# parameters for plugins:
#PLGCFG = $(CONFDIR)/plugins.mk

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-20 Thread Paul Menzel 
Am Sonntag, den 17.03.2013, 18:06 +0100 schrieb Klaus Schmidinger:
> On 17.03.2013 18:00, Carsten Koch wrote:
> > On 03/17/13 13:00, Klaus Schmidinger wrote:
> >> On 17.03.2013 12:46, Ville Skyttä wrote:
> >>> Hello,
> >>>
> >>> Should probably have spoken earlier, but is there any particular reason
> >>> for the ugly and hard to read Makefile variable names LCLBLD and PLGCFG?
> >>> I suppose they're short for LOCALBUILD and PLUGINCONFIG, but why do they
> >>> have to be short for anything, it's not like we're running out of space
> >>> for their names anywhere, is it? Besides, I don't think LCLBLD describes
> >>> what its effects are very well, INPLACE would sounds better to me.
> >>>
> >>> The ship may already have sailed for plgcfg in vdr.pc as it's being used
> >>> by many plugin Makefiles already, but I believe the attached patches
> >>> should be safe for 2.0.0.
> >>
> >> I'm afraid it's too late for that.
> >
> > I do not understand why it should be too late.
> > 2.0 is not out yet.
> 
> But we're in the final testing phase.
> Besides, Ville's patch also touched the Makefiles of plugins - and
> plugin authors and distribution managers react very intense when they
> have to modify their files ;-).

If I am not mistaken, Ville’s issue was that the names were not clear.
Could a comment be added to the Makefile what the meaning is then. That
should not break anything.

[…]


Thanks,

Paul


signature.asc
Description: This is a digitally signed message part
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-20 Thread Manuel Reimer 

Carsten Koch wrote:

But if they really cannot have readable names,
at least I would not provide a default, but  let
the makefile issue a message that they must
be set (as I suggested in the other thread).


They don't have to be set, so why should the Makefile issue a message?

Yours

Manuel

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-17 Thread Klaus Schmidinger 

On 17.03.2013 18:00, Carsten Koch wrote:

On 03/17/13 13:00, Klaus Schmidinger wrote:

On 17.03.2013 12:46, Ville Skyttä wrote:

Hello,

Should probably have spoken earlier, but is there any particular reason
for the ugly and hard to read Makefile variable names LCLBLD and PLGCFG?
I suppose they're short for LOCALBUILD and PLUGINCONFIG, but why do they
have to be short for anything, it's not like we're running out of space
for their names anywhere, is it? Besides, I don't think LCLBLD describes
what its effects are very well, INPLACE would sounds better to me.

The ship may already have sailed for plgcfg in vdr.pc as it's being used
by many plugin Makefiles already, but I believe the attached patches
should be safe for 2.0.0.


I'm afraid it's too late for that.


I do not understand why it should be too late.
2.0 is not out yet.


But we're in the final testing phase.
Besides, Ville's patch also touched the Makefiles of plugins - and
plugin authors and distribution managers react very intense when they
have to modify their files ;-).


But if they really cannot have readable names,
at least I would not provide a default, but  let
the makefile issue a message that they must
be set (as I suggested in the other thread).


Sorry, no more changes for version 2.0.
Just bugfixes, if anything is really broken.

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-17 Thread Carsten Koch 

On 03/17/13 13:00, Klaus Schmidinger wrote:

On 17.03.2013 12:46, Ville Skyttä wrote:

Hello,

Should probably have spoken earlier, but is there any particular reason
for the ugly and hard to read Makefile variable names LCLBLD and PLGCFG?
I suppose they're short for LOCALBUILD and PLUGINCONFIG, but why do they
have to be short for anything, it's not like we're running out of space
for their names anywhere, is it? Besides, I don't think LCLBLD describes
what its effects are very well, INPLACE would sounds better to me.

The ship may already have sailed for plgcfg in vdr.pc as it's being used
by many plugin Makefiles already, but I believe the attached patches
should be safe for 2.0.0.


I'm afraid it's too late for that.


I do not understand why it should be too late.
2.0 is not out yet.

But if they really cannot have readable names,
at least I would not provide a default, but  let
the makefile issue a message that they must
be set (as I suggested in the other thread).

Carsten.


___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-17 Thread Ville Skyttä 
On 2013-03-17 14:00, Klaus Schmidinger wrote:

> I'm afraid it's too late for that.

HWLLBDCLLBTHVTRWY

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-17 Thread Klaus Schmidinger 

On 17.03.2013 12:46, Ville Skyttä wrote:

Hello,

Should probably have spoken earlier, but is there any particular reason
for the ugly and hard to read Makefile variable names LCLBLD and PLGCFG?
I suppose they're short for LOCALBUILD and PLUGINCONFIG, but why do they
have to be short for anything, it's not like we're running out of space
for their names anywhere, is it? Besides, I don't think LCLBLD describes
what its effects are very well, INPLACE would sounds better to me.

The ship may already have sailed for plgcfg in vdr.pc as it's being used
by many plugin Makefiles already, but I believe the attached patches
should be safe for 2.0.0.


I'm afraid it's too late for that.

Sorry for the time you wasted - you should have asked first.

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

[vdr] Makefile variable names LCLBLD and PLGCFG

2013-03-17 Thread Ville Skyttä 
Hello,

Should probably have spoken earlier, but is there any particular reason
for the ugly and hard to read Makefile variable names LCLBLD and PLGCFG?
I suppose they're short for LOCALBUILD and PLUGINCONFIG, but why do they
have to be short for anything, it's not like we're running out of space
for their names anywhere, is it? Besides, I don't think LCLBLD describes
what its effects are very well, INPLACE would sounds better to me.

The ship may already have sailed for plgcfg in vdr.pc as it's being used
by many plugin Makefiles already, but I believe the attached patches
should be safe for 2.0.0.
>From 67899a6591b4eb80198a457ae6cd1a75f11fbd7b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Skytt=C3=A4?= 
Date: Sun, 17 Mar 2013 13:38:45 +0200
Subject: [PATCH 1/2] Rename LCLBLD to INPLACE.

---
 INSTALL  | 2 +-
 Make.config.template | 4 ++--
 Makefile | 2 +-
 UPDATE-2.0.0 | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/INSTALL b/INSTALL
index dd0c999..8ad72ed 100644
--- a/INSTALL
+++ b/INSTALL
@@ -385,7 +385,7 @@ channels, remote control keys, timers etc. By default these files are
 spread around the system according to the FHS ("File system Hierarchy Standard").
 If you prefer to have VDR built to run locally under the VDR source tree,
 you can copy the file Make.config.template to Make.config and set the parameter
-LCLBLD=1. If you also want to have all data files under one single directory,
+INPLACE=1. If you also want to have all data files under one single directory,
 set ONEDIR=1 in Make.config.
 
 For starters just copy all *.conf files from the VDR directory into your
diff --git a/Make.config.template b/Make.config.template
index 2bc0a8f..40cfefe 100644
--- a/Make.config.template
+++ b/Make.config.template
@@ -42,8 +42,8 @@ endif
 
 # Overrides for preset/legacy configurations:
 
-# Use 'make LCLBLD=1' to build locale and plugin files under the source directory:
-ifdef LCLBLD
+# Use 'make INPLACE=1' to build locale and plugin files under the source directory:
+ifdef INPLACE
 LOCDIR   = $(CWD)/locale
 PLUGINDIR= $(CWD)/PLUGINS
 ifndef PLUGIN # don't overwrite for plugins with old makefiles
diff --git a/Makefile b/Makefile
index d24d08f..91506e2 100644
--- a/Makefile
+++ b/Makefile
@@ -219,7 +219,7 @@ plugins: include-dir vdr.pc
 	# New Makefile\
 	INCLUDES="-I$(CWD)/include"\
 	$(MAKE) --no-print-directory -C "$(PLUGINDIR)/src/$$i" VDRDIR="$(CWD)" || failed="$$failed $$i";\
-	if [ -n "$(LCLBLD)" ] ; then\
+	if [ -n "$(INPLACE)" ] ; then\
 	   (cd $(PLUGINDIR)/src/$$i; for l in `find -name 'libvdr-*.so' -o -name 'lib$$i-*.so'`; do install $$l $(LIBDIR)/`basename $$l`.$(APIVERSION); done);\
 	   if [ -d $(PLUGINDIR)/src/$$i/po ]; then\
 	  for l in `ls $(PLUGINDIR)/src/$$i/po/*.mo`; do\
diff --git a/UPDATE-2.0.0 b/UPDATE-2.0.0
index c24fcb0..6f9144f 100644
--- a/UPDATE-2.0.0
+++ b/UPDATE-2.0.0
@@ -461,7 +461,7 @@ Misc:
 - By default VDR is now built according to the FHS ("File system Hierarchy Standard"),
   and a plain "make" in the VDR source directory just builds everything, but doesn't
   copy it to ./PLUGINS/lib and ./locale any more. You can use a Make.config file
-  (copied from Make.config.template) and set the parameter LCLBLD=1 to have everything
+  (copied from Make.config.template) and set the parameter INPLACE=1 to have everything
   built and installed under the VDR source tree (as was the default in previous
   versions). If you already have your own Make.config file, you may want to copy the
   new Make.config.template and adapt it to your needs. If you don't want VDR's data
-- 
1.7.11.7

>From 79a900a9995c1d401543e2804027cc019b5f7375 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Skytt=C3=A4?= 
Date: Sun, 17 Mar 2013 13:43:40 +0200
Subject: [PATCH 2/2] Rename PLGCFG to PLUGINCONFIG.

---
 Make.config.template | 2 +-
 Makefile | 2 +-
 PLUGINS/src/dvbhddevice/Makefile | 4 ++--
 PLUGINS/src/dvbsddevice/Makefile | 4 ++--
 PLUGINS/src/epgtableid0/Makefile | 4 ++--
 PLUGINS/src/hello/Makefile   | 4 ++--
 PLUGINS/src/osddemo/Makefile | 4 ++--
 PLUGINS/src/pictures/Makefile| 4 ++--
 PLUGINS/src/rcu/Makefile | 4 ++--
 PLUGINS/src/servicedemo/Makefile | 4 ++--
 PLUGINS/src/skincurses/Makefile  | 4 ++--
 PLUGINS/src/status/Makefile  | 4 ++--
 PLUGINS/src/svdrpdemo/Makefile   | 4 ++--
 newplugin| 4 ++--
 14 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/Make.config.template b/Make.config.template
index 40cfefe..8a04fd7 100644
--- a/Make.config.template
+++ b/Make.config.template
@@ -62,7 +62,7 @@ endif
 
 # Use this if you want to have a central place where you configure compile time
 # parameters for plugins:
-#PLGCFG = $(CONFDIR)/plugins.mk
+#PLUGINCONFIG = $(CONFDIR)/plugins.mk
 
 ### The remote control:
 
diff --git a/Makefile b/Makefile
index 91506e2..a881b03 100644
--- a/Makefile
+++ b/Makef