Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-11 Thread Klaus Schmidinger
On 12/11/2007 01:09 PM, Darren Salt wrote: > I demand that Klaus Schmidinger may or may not have written... > > [snip; FD_CLOEXEC] >> Why is this suddenly such a big problem? >> If a plugin wants to run an external program it can simply use >> SystemExec(). > >> Besides, as Darren Salt pointed ou

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-11 Thread Darren Salt
I demand that Klaus Schmidinger may or may not have written... [snip; FD_CLOEXEC] > Why is this suddenly such a big problem? > If a plugin wants to run an external program it can simply use > SystemExec(). > Besides, as Darren Salt pointed out, this flag is apparently only available > in the very

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-11 Thread Klaus Schmidinger
On 12/11/2007 08:39 AM, Deti Fliegl wrote: > Klaus Schmidinger wrote: >> Plugins can call SystemExec() just as well when the want to execute >> an external program. > Yes, but would you point every single developer on this issue? > >> IMHO it is no feasible solution to expect every file handle to

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Deti Fliegl
Klaus Schmidinger wrote: > Plugins can call SystemExec() just as well when the want to execute > an external program. Yes, but would you point every single developer on this issue? > IMHO it is no feasible solution to expect every file handle to > be opened with FD_CLOEXEC. Even if VDR itself woul

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Darren Salt
I demand that Deti Fliegl may or may not have written... > Anssi Hannula wrote: >> Deti Fliegl wrote: >>> Klaus Schmidinger wrote: Doesn't SystemExec() (see tools.c) take care of this? >>> Yes you are right - it takes care internally but not for plugins like >>> dvdswitch etc. In order to fi

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Klaus Schmidinger
On 12/10/07 21:07, Deti Fliegl wrote: > Klaus Schmidinger wrote: >> Doesn't SystemExec() (see tools.c) take care of this? > Yes you are right - it takes care internally but not for plugins like > dvdswitch etc. In order to fix this problem you could patch every single > plugin or just set the rig

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Deti Fliegl
Deti Fliegl wrote: > Anssi Hannula wrote: >> Deti Fliegl wrote: >>> Klaus Schmidinger wrote: Doesn't SystemExec() (see tools.c) take care of this? >>> Yes you are right - it takes care internally but not for plugins like >>> dvdswitch etc. In order to fix this problem you could patch every si

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Deti Fliegl
Anssi Hannula wrote: > Deti Fliegl wrote: >> Klaus Schmidinger wrote: >>> Doesn't SystemExec() (see tools.c) take care of this? >> Yes you are right - it takes care internally but not for plugins like >> dvdswitch etc. In order to fix this problem you could patch every single >> plugin or just se

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Anssi Hannula
Deti Fliegl wrote: > Klaus Schmidinger wrote: >> Doesn't SystemExec() (see tools.c) take care of this? > Yes you are right - it takes care internally but not for plugins like > dvdswitch etc. In order to fix this problem you could patch every single > plugin or just set the right file descriptor

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Deti Fliegl
Klaus Schmidinger wrote: > Doesn't SystemExec() (see tools.c) take care of this? Yes you are right - it takes care internally but not for plugins like dvdswitch etc. In order to fix this problem you could patch every single plugin or just set the right file descriptor flag once. I think the latt

Re: [vdr] [patch] avoid inheritance of file descriptors

2007-12-10 Thread Klaus Schmidinger
On 12/10/07 15:28, Deti Fliegl wrote: > Hi, > > I think there is a problem in calling external programs from plugins. If > such a program takes some while for execution (even in background) it > gets inherited all file descriptors of VDR. This prevents vdr from > zapping to another channel or e