[vdsm] blame and shame

2012-12-13 Thread Antoni Segura Puimedon
Hi list! Since I'm doing lately and I plan to continue to do patches to improve pep8 compliance for the whole vdsm codebase, and a lot of that is E126, E127 and E128, that deal with whitespaces, I have added to my ~/.gitconfig [alias] bl = blame -w Which ignores whitespaces for the blame on

Re: [vdsm] Host bios information

2012-12-13 Thread Shu Ming
After a quick review of the wiki page, it was stated that dmidecode gave too much informations. Only five fields will be displayed in the hardware tab, Manufactory, Version, Family, UUID and serial number. For Family, it is mean the CPU core's family. And it confuses me a bit with the CPU

Re: [vdsm] blame and shame

2012-12-13 Thread Saggi Mizrahi
I kind of like the fact that I will not be blamed for all the stuff I broke. :( - Original Message - From: Antoni Segura Puimedon asegu...@redhat.com To: vdsm-devel@lists.fedorahosted.org Sent: Thursday, December 13, 2012 10:34:52 AM Subject: [vdsm] blame and shame Hi list!

Re: [vdsm] Host bios information

2012-12-13 Thread Ayal Baron
- Original Message - I think that for the new current XML-RPC API it's OK to add it to the getVdsCaps() verb. For the new API I suggest moving it to it's own API. The smaller the APIs the easier they are to deprecate and support. I quite doubt the fields in getBiosInfo() will change

Re: [vdsm] Request for consideration during the API revamp

2012-12-13 Thread Saggi Mizrahi
Since I assume vdsClient will use libvdsm. It should have all the constants defined. I do like Adam's suggestion about making vdsClient auto-generated as well. vdsClient is currently very annoying to maintain. I would also like to propose changing the name of the executable to vdsm_cli. It would

Re: [vdsm] Host bios information

2012-12-13 Thread Saggi Mizrahi
- Original Message - From: Ayal Baron aba...@redhat.com To: Saggi Mizrahi smizr...@redhat.com Cc: VDSM Project Development vdsm-devel@lists.fedorahosted.org, Shu Ming shum...@linux.vnet.ibm.com Sent: Thursday, December 13, 2012 11:30:56 AM Subject: Re: [vdsm] Host bios information