Re: [vdsm] PEP8 in VDSM code

2012-03-25 Thread Itamar Heim
On 03/22/2012 10:18 PM, Saggi Mizrahi wrote: I suggest having pep8 a must for patch submission in VDSM. http://www.python.org/dev/peps/pep-0008/ Currently there are a few people policing these rules in reviews but I suggest we make it automatic. Unless someone objects I will put a gerrit hook

Re: [vdsm] PEP8 in VDSM code

2012-03-25 Thread Ayal Baron
- Original Message - > On Thu, Mar 22, 2012 at 04:18:10PM -0400, Saggi Mizrahi wrote: > > I suggest having pep8 a must for patch submission in VDSM. > > http://www.python.org/dev/peps/pep-0008/ > > > > Currently there are a few people policing these rules in reviews > > but I suggest we

Re: [vdsm] PEP8 in VDSM code

2012-03-25 Thread Dan Kenigsberg
On Thu, Mar 22, 2012 at 04:18:10PM -0400, Saggi Mizrahi wrote: > I suggest having pep8 a must for patch submission in VDSM. > http://www.python.org/dev/peps/pep-0008/ > > Currently there are a few people policing these rules in reviews but I > suggest we make it automatic. > > Unless someone obj