Re: [vdsm] PEP8 in VDSM code

2012-03-26 Thread Saggi Mizrahi
The reason I wanted a gerrit hook is to avoid putting a -1 until VDSM is clean of errors. It's supposed to be a transitional state. - Original Message - > From: "Itamar Heim" > To: "Ewoud Kohl van Wijngaarden" > Cc: vdsm-devel@lists.fedorahosted.org > Sent: Monday, March 26, 2012 5:52:1

Re: [vdsm] PEP8 in VDSM code

2012-03-26 Thread Itamar Heim
On 03/26/2012 11:26 AM, Ewoud Kohl van Wijngaarden wrote: On Mon, Mar 26, 2012 at 04:57:24AM -0400, Ayal Baron wrote: I'd rather avoid gerrit hooks if possible to use a jenkins job to validate this to keep the gerrit deployment as simple to maintain/upgrade as possible. But that's the wrong pl

Re: [vdsm] PEP8 in VDSM code

2012-03-26 Thread Ewoud Kohl van Wijngaarden
On Mon, Mar 26, 2012 at 04:57:24AM -0400, Ayal Baron wrote: > > I'd rather avoid gerrit hooks if possible to use a jenkins job to > > validate this to keep the gerrit deployment as simple to > > maintain/upgrade as possible. > > But that's the wrong place to be doing it. > Jenkins periodically poll

Re: [vdsm] PEP8 in VDSM code

2012-03-26 Thread Ayal Baron
- Original Message - > On 03/22/2012 10:18 PM, Saggi Mizrahi wrote: > > I suggest having pep8 a must for patch submission in VDSM. > > http://www.python.org/dev/peps/pep-0008/ > > > > Currently there are a few people policing these rules in reviews > > but I suggest we make it automatic.