Re: [vdsm] minutes: today's call
On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote: On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote: On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote: Hi all, I would like to discuss the following on today's call: 1. Gerrit vs. mailing list Gerrit is an inhibiter for some contributors. One approach to solve this improve gerrit: - Gerrit should send the patch when it notified of a change. This may attract more reviewers. I'm happy to inform that Gal has sent a patch for this to upstream gerrit: https://gerrit-review.googlesource.com/#/c/34861/ Add unified diff to newchange mail template. - comments should be posted with their context and for this one, too: https://gerrit-review.googlesource.com/#/c/34862/ - pick up a patch/comment from the mailing list I hope we can fix another annoying behaviour of gerrit: a comment to a change set says how many inline comments are there, but it does not tell which comments are they (hopefully with a link to the comment). What else would we want to talk about today? - state of Adam's REST patches review - Hunt Xu's ifconfig patch (very wanted, blocked on a missing unit test) - Saggi's betterPopen - ? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] RFD: NEW API getAllTasks
The current APIs for retrieving all task information do not actually return all task information. I would like to introduce a new API that corrects this and other issues with the current API while preserving backwards compatibility with ovirt-engine for as long as is necessary. The current APIs: getAllTasksInfo(spUUID=None, options = None): - Returns a dictionary that maps a task UUID to a task verb. - Despite having 'all' in the name, this API only returns tasks that have an 'spm' tag. - This call returns only one piece of information for each task. - The spUUID parameter is deprecated and ignored. getAllTasksStatuses(spUUID=None, options = None): - Returns a dictionary of task status information. - Despite having 'all' in the name, this API only returns tasks that have an 'spm' tag. - The spUUID parameter is deprecated and ignored. I propose the following new API: getAllTasks(tag=None, options=None): - Returns a dictionary of task information. The info from both of the above functions would be merged into a single result set. - If tag is None, all tasks are returned. otherwise, only tasks matching the tag are returned. - The spUUID parameter is dropped. options is for future extension and is currently not used. This new API includes all functionality that is available in the old calls. In the future, ovirt-engine could switch to this API and preserve the current semantics by passing tag='spm' to getAllTasks. Meanwhile, API users that really want all tasks (gluster and the REST API) can get what they need. Thoughts on this idea? -- Adam Litke a...@us.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] gerrit problem when reviewing VDSM code
Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? -- Shu Mingshum...@linux.vnet.ibm.com IBM China Systems and Technology Laboratory ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] gerrit problem when reviewing VDSM code
On 05/08/2012 04:50 AM, Shu Ming wrote: Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? just changed in gerrit the context to show you 'whole file' rather than '10 lines'? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
