Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-29 Thread Ayal Baron
- Original Message - top posting since there was a long thread on this anyway. some questions/comments: 1. about the CIDs - it sounds like the engine needs to persist this info, so it can resume normally in case of a failure/restart (this is different than today, when the

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-28 Thread Livnat Peer
: Re: [vdsm] [Engine-devel] [RFC] New Connection Management API On 26/01/12 21:21, Saggi Mizrahi wrote: - Original Message - From: Adam Litke a...@us.ibm.com To: Saggi Mizrahi smizr...@redhat.com Cc: Livnat Peer lp...@redhat.com, engine-de...@ovirt.org, vdsm-devel

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-28 Thread Livnat Peer
On 28/01/12 04:50, Itamar Heim wrote: top posting since there was a long thread on this anyway. some questions/comments: 1. about the CIDs - it sounds like the engine needs to persist this info, so it can resume normally in case of a failure/restart (this is different than today, when the

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-28 Thread Juan Hernandez
On 01/26/2012 03:01 PM, Adam Litke wrote: On Thu, Jan 26, 2012 at 12:22:42PM +0200, Livnat Peer wrote: On 25/01/12 23:35, Saggi Mizrahi wrote: About the clear all verb. No. Just loop, find the connections YOU OWN and clean them. Even though you don't want to support multiple clients to VDSM

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-27 Thread Itamar Heim
top posting since there was a long thread on this anyway. some questions/comments: 1. about the CIDs - it sounds like the engine needs to persist this info, so it can resume normally in case of a failure/restart (this is different than today, when the persisted info is the connection details,

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Adam Litke
On Thu, Jan 26, 2012 at 12:22:42PM +0200, Livnat Peer wrote: On 25/01/12 23:35, Saggi Mizrahi wrote: SNIP This is mail was getting way too long. About the clear all verb. No. Just loop, find the connections YOU OWN and clean them. Even though you don't want to support multiple

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Yaniv Kaul
On 01/26/2012 04:21 PM, Juan Hernandez wrote: On 01/26/2012 03:01 PM, Adam Litke wrote: On Thu, Jan 26, 2012 at 12:22:42PM +0200, Livnat Peer wrote: On 25/01/12 23:35, Saggi Mizrahi wrote: About the clear all verb. No. Just loop, find the connections YOU OWN and clean them. Even though you

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Saggi Mizrahi
snip Again trying to sum up and address all comments Clear all: == My opinions is still to not implement it. Even though it might generate a bit more traffic premature optimization is bad and there are other reasons we can improve VDSM command overhead without doing this. In any case

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Adam Litke
On Thu, Jan 26, 2012 at 10:00:57AM -0500, Saggi Mizrahi wrote: snip Again trying to sum up and address all comments Clear all: == My opinions is still to not implement it. Even though it might generate a bit more traffic premature optimization is bad and there are other reasons

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Saggi Mizrahi
- Original Message - From: Adam Litke a...@us.ibm.com To: Saggi Mizrahi smizr...@redhat.com Cc: Livnat Peer lp...@redhat.com, engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org Sent: Thursday, January 26, 2012 1:58:40 PM Subject: Re: [vdsm] [Engine-devel] [RFC] New

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Livnat Peer
On 26/01/12 17:00, Saggi Mizrahi wrote: snip Again trying to sum up and address all comments Clear all: == My opinions is still to not implement it. Even though it might generate a bit more traffic premature optimization is bad and there are other reasons we can improve VDSM

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Saggi Mizrahi
- Original Message - From: Livnat Peer lp...@redhat.com To: Saggi Mizrahi smizr...@redhat.com Cc: vdsm-devel@lists.fedorahosted.org, engine-de...@ovirt.org Sent: Thursday, January 26, 2012 3:03:39 PM Subject: Re: [Engine-devel] [RFC] New Connection Management API On 26/01/12

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-26 Thread Saggi Mizrahi
, 2012 1:58:40 PM Subject: Re: [vdsm] [Engine-devel] [RFC] New Connection Management API On Thu, Jan 26, 2012 at 10:00:57AM -0500, Saggi Mizrahi wrote: snip Again trying to sum up and address all comments Clear all: == My opinions is still to not implement it. Even though

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-25 Thread Saggi Mizrahi
- Original Message - From: Livnat Peer lp...@redhat.com To: Saggi Mizrahi smizr...@redhat.com Cc: vdsm-devel@lists.fedorahosted.org, engine-de...@ovirt.org Sent: Tuesday, January 24, 2012 12:43:39 PM Subject: Re: [Engine-devel] [RFC] New Connection Management API On 23/01/12

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-25 Thread Livnat Peer
On 25/01/12 16:20, Adam Litke wrote: On Mon, Jan 23, 2012 at 04:54:10PM -0500, Saggi Mizrahi wrote: Nitty Gritty: This seems like a good API but I have some suggestions with respect to API naming: manageStorageServer === Could we name this manageStorageConnection or

Re: [vdsm] [Engine-devel] [RFC] New Connection Management API

2012-01-25 Thread Saggi Mizrahi
SNIP This is mail was getting way too long. About the clear all verb. No. Just loop, find the connections YOU OWN and clean them. Even though you don't want to support multiple clients to VDSM API doesn't mean the engine shouldn't behave like a proper citizen. It's the same reason why VDSM