Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-17 Thread Itamar Heim 

On 10/16/2012 09:31 AM, Livnat Peer wrote:

On 16/10/12 08:52, Mike Kolesnik wrote:

- Original Message -

On 10/10/12 16:47, Igor Lvovsky wrote:

   Hi everyone,
As you know vdsm has hooks mechanism and we already support dozen
of hooks for different needs.
Now it's a network's time.
We would like to get your comments regarding our proposition for
network related hooks.

In general we are planning to prepare framework for future support
of bunch network related hooks.
Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].

Below you can find the additional hooks list that we propose:



Many of the API calls bellow are deprecated. Why do we want to add
hooks
before/after to deprecated APIs?


They are actually still very much in use with the REST API.



Deprecate does not mean not in use but not using it going forward.

Today if a user is using 3.1 cluster/DC in the UI or the setupNetwork
API (which is the recommended way to configure your network in 3.1 and
in future versions) the hooks for add/edit-Network won't get activated
and that is confusing to the users (and the developers).


Perhaps we should address just the logical entry points instead of specific 
commands.
A command such as setup networks can trigger multiple logical events in which 
hooks can be planted (same goes for edit network in a smaller scale).



What you are suggesting above is to deviate from the current hook
mechanism we have in VDSM and add some logic to where/when we activate
hooks.

That's an interesting suggestion, I suggest to write a wiki page and
start thinking of the implementation implications of it.
Since I like the idea I'll work with you on the wiki and we'll see if we
can get something more useful to the users and send a formal proposal.



question is there is any high demand/priority for network hooks other 
than hotplug nic, and do we have a clear vision of a stable api for them.


one thing to consider is allowing to define custom properties at logical 
network and virtual nic level though.

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-16 Thread Mike Kolesnik 
- Original Message -
 Hi everyone,
 As you know vdsm has hooks mechanism and we already support dozen of
 hooks for different needs.
 Now it's a network's time.
 We would like to get your comments regarding our proposition for
 network related hooks.
 
 In general we are planning to prepare framework for future support of
 bunch network related hooks.
 Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
 
 Below you can find the additional hooks list that we propose:
 
 Note: In the first stage we can implement these hooks without any
 parameters, just to provide an entry point
  for simple hooks.

Will the admin be able to supply a sort of free-text custom properties field 
which will be passed to the hook?

If so, at what level (in the engine entities) should it be defined?
Host NIC seems to make the most sense as this is where you actually pass this 
info, but perhaps it should be defined on a higher level?

 
 Networks manipulation:
 - before_add_network(conf={}, customProperty={})
 - after_add_network(conf={}, customProperty={})
 - before_del_network(conf={}, customProperty={})
 - after_del_network(conf={}, customProperty={})
 - before_edit_network(conf={}, customProperty={})
 - after_edit_network(conf={}, customProperty={})
 - TBD
 
 Bondings manipulations:
 - before_add_bond(conf={}, customProperty={})
 - after_add_bond(conf={}, customProperty={})
 - before_del_bond(conf={}, customProperty={})
 - after_del_bond(conf={}, customProperty={})
 - before_edit_bond(conf={}, customProperty={})
 - after_edit_bond(conf={}, customProperty={})
 - TBD
 
 General purpose:
 - before_persist_network
 - after_persist_network
 
 
 Now we just need to figure out the use cases.
 
 Your input more than welcome...
 
 [1] http://gerrit.ovirt.org/#/c/7224/   - Adding hooks support for
 NIC hotplug
 [2] http://gerrit.ovirt.org/#/c/7547/   - Hook: Cisco VM-FEX support
 
 
 Regards,
 Igor Lvovsky
 ___
 Engine-devel mailing list
 engine-de...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-16 Thread Livnat Peer 
On 10/10/12 16:47, Igor Lvovsky wrote:
   Hi everyone,
 As you know vdsm has hooks mechanism and we already support dozen of hooks 
 for different needs.
 Now it's a network's time.
 We would like to get your comments regarding our proposition for network 
 related hooks.
 
 In general we are planning to prepare framework for future support of bunch 
 network related hooks.
 Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
 
 Below you can find the additional hooks list that we propose:
 

Many of the API calls bellow are deprecated. Why do we want to add hooks
before/after to deprecated APIs?

 Note: In the first stage we can implement these hooks without any parameters, 
 just to provide an entry point
  for simple hooks.
 
 Networks manipulation:
 - before_add_network(conf={}, customProperty={})
 - after_add_network(conf={}, customProperty={})
 - before_del_network(conf={}, customProperty={})
 - after_del_network(conf={}, customProperty={})
 - before_edit_network(conf={}, customProperty={})
 - after_edit_network(conf={}, customProperty={})
 - TBD
 
 Bondings manipulations:
 - before_add_bond(conf={}, customProperty={})
 - after_add_bond(conf={}, customProperty={})
 - before_del_bond(conf={}, customProperty={})
 - after_del_bond(conf={}, customProperty={})
 - before_edit_bond(conf={}, customProperty={})
 - after_edit_bond(conf={}, customProperty={})
 - TBD
 
 General purpose:
 - before_persist_network
 - after_persist_network
 
 
 Now we just need to figure out the use cases.
 
 Your input more than welcome...
 
 [1] http://gerrit.ovirt.org/#/c/7224/   - Adding hooks support for NIC hotplug
 [2] http://gerrit.ovirt.org/#/c/7547/   - Hook: Cisco VM-FEX support
 
 
 Regards,
 Igor Lvovsky
 ___
 Engine-devel mailing list
 engine-de...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-16 Thread Mike Kolesnik 
- Original Message -
 On 10/10/12 16:47, Igor Lvovsky wrote:
Hi everyone,
  As you know vdsm has hooks mechanism and we already support dozen
  of hooks for different needs.
  Now it's a network's time.
  We would like to get your comments regarding our proposition for
  network related hooks.
  
  In general we are planning to prepare framework for future support
  of bunch network related hooks.
  Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
  
  Below you can find the additional hooks list that we propose:
  
 
 Many of the API calls bellow are deprecated. Why do we want to add
 hooks
 before/after to deprecated APIs?

They are actually still very much in use with the REST API.

Perhaps we should address just the logical entry points instead of specific 
commands.
A command such as setup networks can trigger multiple logical events in which 
hooks can be planted (same goes for edit network in a smaller scale).

 
  Note: In the first stage we can implement these hooks without any
  parameters, just to provide an entry point
   for simple hooks.
  
  Networks manipulation:
  - before_add_network(conf={}, customProperty={})
  - after_add_network(conf={}, customProperty={})
  - before_del_network(conf={}, customProperty={})
  - after_del_network(conf={}, customProperty={})
  - before_edit_network(conf={}, customProperty={})
  - after_edit_network(conf={}, customProperty={})
  - TBD
  
  Bondings manipulations:
  - before_add_bond(conf={}, customProperty={})
  - after_add_bond(conf={}, customProperty={})
  - before_del_bond(conf={}, customProperty={})
  - after_del_bond(conf={}, customProperty={})
  - before_edit_bond(conf={}, customProperty={})
  - after_edit_bond(conf={}, customProperty={})
  - TBD
  
  General purpose:
  - before_persist_network
  - after_persist_network
  
  
  Now we just need to figure out the use cases.
  
  Your input more than welcome...
  
  [1] http://gerrit.ovirt.org/#/c/7224/   - Adding hooks support for
  NIC hotplug
  [2] http://gerrit.ovirt.org/#/c/7547/   - Hook: Cisco VM-FEX
  support
  
  
  Regards,
  Igor Lvovsky
  ___
  Engine-devel mailing list
  engine-de...@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/engine-devel
  
 
 ___
 Engine-devel mailing list
 engine-de...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-16 Thread Livnat Peer 
On 16/10/12 08:52, Mike Kolesnik wrote:
 - Original Message -
 On 10/10/12 16:47, Igor Lvovsky wrote:
   Hi everyone,
 As you know vdsm has hooks mechanism and we already support dozen
 of hooks for different needs.
 Now it's a network's time.
 We would like to get your comments regarding our proposition for
 network related hooks.

 In general we are planning to prepare framework for future support
 of bunch network related hooks.
 Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].

 Below you can find the additional hooks list that we propose:


 Many of the API calls bellow are deprecated. Why do we want to add
 hooks
 before/after to deprecated APIs?
 
 They are actually still very much in use with the REST API.
 

Deprecate does not mean not in use but not using it going forward.

Today if a user is using 3.1 cluster/DC in the UI or the setupNetwork
API (which is the recommended way to configure your network in 3.1 and
in future versions) the hooks for add/edit-Network won't get activated
and that is confusing to the users (and the developers).

 Perhaps we should address just the logical entry points instead of specific 
 commands.
 A command such as setup networks can trigger multiple logical events in which 
 hooks can be planted (same goes for edit network in a smaller scale).
 

What you are suggesting above is to deviate from the current hook
mechanism we have in VDSM and add some logic to where/when we activate
hooks.

That's an interesting suggestion, I suggest to write a wiki page and
start thinking of the implementation implications of it.
Since I like the idea I'll work with you on the wiki and we'll see if we
can get something more useful to the users and send a formal proposal.

Livnat


 Note: In the first stage we can implement these hooks without any
 parameters, just to provide an entry point
  for simple hooks.

 Networks manipulation:
 - before_add_network(conf={}, customProperty={})
 - after_add_network(conf={}, customProperty={})
 - before_del_network(conf={}, customProperty={})
 - after_del_network(conf={}, customProperty={})
 - before_edit_network(conf={}, customProperty={})
 - after_edit_network(conf={}, customProperty={})
 - TBD

 Bondings manipulations:
 - before_add_bond(conf={}, customProperty={})
 - after_add_bond(conf={}, customProperty={})
 - before_del_bond(conf={}, customProperty={})
 - after_del_bond(conf={}, customProperty={})
 - before_edit_bond(conf={}, customProperty={})
 - after_edit_bond(conf={}, customProperty={})
 - TBD

 General purpose:
 - before_persist_network
 - after_persist_network


 Now we just need to figure out the use cases.

 Your input more than welcome...

 [1] http://gerrit.ovirt.org/#/c/7224/   - Adding hooks support for
 NIC hotplug
 [2] http://gerrit.ovirt.org/#/c/7547/   - Hook: Cisco VM-FEX
 support


 Regards,
 Igor Lvovsky
 ___
 Engine-devel mailing list
 engine-de...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel


 ___
 Engine-devel mailing list
 engine-de...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel


___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-10 Thread Yaniv Kaul 

On 10/10/2012 04:47 PM, Igor Lvovsky wrote:

   Hi everyone,
As you know vdsm has hooks mechanism and we already support dozen of hooks for 
different needs.
Now it's a network's time.
We would like to get your comments regarding our proposition for network 
related hooks.

In general we are planning to prepare framework for future support of bunch 
network related hooks.
Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].

Below you can find the additional hooks list that we propose:

Note: In the first stage we can implement these hooks without any parameters, 
just to provide an entry point
  for simple hooks.

Networks manipulation:
- before_add_network(conf={}, customProperty={})
- after_add_network(conf={}, customProperty={})
- before_del_network(conf={}, customProperty={})
- after_del_network(conf={}, customProperty={})
- before_edit_network(conf={}, customProperty={})
- after_edit_network(conf={}, customProperty={})
- TBD

Bondings manipulations:


Bond might be interesting because it may require switch configuration - 
but so will VLAN changes, so perhaps triggers in VLAN changes are 
worthwhile as well.

Y.


- before_add_bond(conf={}, customProperty={})
- after_add_bond(conf={}, customProperty={})
- before_del_bond(conf={}, customProperty={})
- after_del_bond(conf={}, customProperty={})
- before_edit_bond(conf={}, customProperty={})
- after_edit_bond(conf={}, customProperty={})
- TBD

General purpose:
- before_persist_network
- after_persist_network


Now we just need to figure out the use cases.

Your input more than welcome...

[1] http://gerrit.ovirt.org/#/c/7224/   - Adding hooks support for NIC hotplug
[2] http://gerrit.ovirt.org/#/c/7547/   - Hook: Cisco VM-FEX support


Regards,
 Igor Lvovsky
___
Engine-devel mailing list
engine-de...@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-10 Thread Igor Lvovsky 


- Original Message -
 From: Yaniv Kaul yk...@redhat.com
 To: Igor Lvovsky ilvov...@redhat.com
 Cc: vdsm-devel vdsm-devel@lists.fedorahosted.org, engine-devel 
 engine-de...@ovirt.org, Dan Yasny
 dya...@redhat.com
 Sent: Wednesday, October 10, 2012 4:53:19 PM
 Subject: Re: [Engine-devel] Network related hooks in vdsm
 
 On 10/10/2012 04:47 PM, Igor Lvovsky wrote:
 Hi everyone,
  As you know vdsm has hooks mechanism and we already support dozen
  of hooks for different needs.
  Now it's a network's time.
  We would like to get your comments regarding our proposition for
  network related hooks.
 
  In general we are planning to prepare framework for future support
  of bunch network related hooks.
  Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
 
  Below you can find the additional hooks list that we propose:
 
  Note: In the first stage we can implement these hooks without any
  parameters, just to provide an entry point
for simple hooks.
 
  Networks manipulation:
  - before_add_network(conf={}, customProperty={})
  - after_add_network(conf={}, customProperty={})
  - before_del_network(conf={}, customProperty={})
  - after_del_network(conf={}, customProperty={})
  - before_edit_network(conf={}, customProperty={})
  - after_edit_network(conf={}, customProperty={})
  - TBD
 
  Bondings manipulations:
 
 Bond might be interesting because it may require switch configuration
 -
 but so will VLAN changes, so perhaps triggers in VLAN changes are
 worthwhile as well.

You are right, but in our implementation VLAN changes are part of network 
manipulation.
So, it's already covered by list above

 Y.
 
  - before_add_bond(conf={}, customProperty={})
  - after_add_bond(conf={}, customProperty={})
  - before_del_bond(conf={}, customProperty={})
  - after_del_bond(conf={}, customProperty={})
  - before_edit_bond(conf={}, customProperty={})
  - after_edit_bond(conf={}, customProperty={})
  - TBD
 
  General purpose:
  - before_persist_network
  - after_persist_network
 
 
  Now we just need to figure out the use cases.
 
  Your input more than welcome...
 
  [1] http://gerrit.ovirt.org/#/c/7224/   - Adding hooks support for
  NIC hotplug
  [2] http://gerrit.ovirt.org/#/c/7547/   - Hook: Cisco VM-FEX
  support
 
 
  Regards,
   Igor Lvovsky
  ___
  Engine-devel mailing list
  engine-de...@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/engine-devel
 
 
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] [Engine-devel] Network related hooks in vdsm

2012-10-10 Thread Andrew Cathrow 


- Original Message -
 From: Yaniv Kaul yk...@redhat.com
 To: Igor Lvovsky ilvov...@redhat.com
 Cc: Dan Yasny dya...@redhat.com, engine-devel engine-de...@ovirt.org, 
 vdsm-devel
 vdsm-devel@lists.fedorahosted.org
 Sent: Wednesday, October 10, 2012 10:53:19 AM
 Subject: Re: [Engine-devel] Network related hooks in vdsm
 
 On 10/10/2012 04:47 PM, Igor Lvovsky wrote:
 Hi everyone,
  As you know vdsm has hooks mechanism and we already support dozen
  of hooks for different needs.
  Now it's a network's time.
  We would like to get your comments regarding our proposition for
  network related hooks.
 
  In general we are planning to prepare framework for future support
  of bunch network related hooks.
  Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
 
  Below you can find the additional hooks list that we propose:
 
  Note: In the first stage we can implement these hooks without any
  parameters, just to provide an entry point
for simple hooks.
 
  Networks manipulation:
  - before_add_network(conf={}, customProperty={})
  - after_add_network(conf={}, customProperty={})
  - before_del_network(conf={}, customProperty={})
  - after_del_network(conf={}, customProperty={})
  - before_edit_network(conf={}, customProperty={})
  - after_edit_network(conf={}, customProperty={})
  - TBD
 
  Bondings manipulations:
 
 Bond might be interesting because it may require switch configuration
 -
 but so will VLAN changes, so perhaps triggers in VLAN changes are
 worthwhile as well.
 Y.
 
  - before_add_bond(conf={}, customProperty={})
  - after_add_bond(conf={}, customProperty={})
  - before_del_bond(conf={}, customProperty={})
  - after_del_bond(conf={}, customProperty={})
  - before_edit_bond(conf={}, customProperty={})
  - after_edit_bond(conf={}, customProperty={})
  - TBD
 
  General purpose:
  - before_persist_network
  - after_persist_network

What about some way of doing a push that's not tied to an event - if we want to 
push something



 
 
  Now we just need to figure out the use cases.
 
  Your input more than welcome...
 
  [1] http://gerrit.ovirt.org/#/c/7224/   - Adding hooks support for
  NIC hotplug
  [2] http://gerrit.ovirt.org/#/c/7547/   - Hook: Cisco VM-FEX
  support
 
 
  Regards,
   Igor Lvovsky
  ___
  Engine-devel mailing list
  engine-de...@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/engine-devel
 
 ___
 Engine-devel mailing list
 engine-de...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel