subject:"\[vdsm\] stale gerrit patches"

Re: [vdsm] stale gerrit patches

2013-10-09 Thread Dave Neary

Hi,

On 09/23/2013 12:36 PM, Itamar Heim wrote:
 we have some very old gerrit patches.
 I'm for abandoning patches which were not touched over 60 days (to begin
 with, I think the number should actually be lower).
 they can always be re-opened by any interested party post their closure.
 
 i.e., looking at gerrit, the patch list should actually get attention,
 and not be a few worth looking at, with a lot of old patches

I'm coming late to this discussion, but I see that there were some
dissenting views from people who want maintainers to be able to store
in-progress patches in Gerrit.

I am all in favour of treating Gerrit like we treat a bug tracker. If
something is opened in the bug tracker, it should be a bug, an open bug
is something to be fixed or closed, not to be left indefinitely. An open
patch needs to be rejected, reviewed, revised or committed. I don't
think Gerrit is the place for in-progress patches (use private branches
for that).

Cheers,
Dave.

-- 
Dave Neary - Community Action and Impact
Open Source and Standards, Red Hat - http://community.redhat.com
Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-24 Thread Alon Bar-Lev

- Original Message -
 From: Ayal Baron aba...@redhat.com
 To: Alon Bar-Lev alo...@redhat.com
 Cc: Itamar Heim ih...@redhat.com, engine-devel 
 engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
 Sent: Tuesday, September 24, 2013 12:21:23 AM
 Subject: Re: [vdsm] stale gerrit patches

 - Original Message -

  - Original Message -
   From: Itamar Heim ih...@redhat.com
   To: Alon Bar-Lev alo...@redhat.com
   Cc: David Caro dcaro...@redhat.com, engine-devel
   engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
   Sent: Monday, September 23, 2013 1:54:39 PM
   Subject: Re: [vdsm] stale gerrit patches

   On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:

- Original Message -
From: Itamar Heim ih...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: David Caro dcaro...@redhat.com, engine-devel
engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:50:35 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

- Original Message -
From: Itamar Heim ih...@redhat.com
To: David Caro dcaro...@redhat.com
Cc: engine-devel engine-de...@ovirt.org,
vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:47:47 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:46 PM, David Caro wrote:
On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60 days (to
begin with, I think the number should actually be lower).
they can always be re-opened by any interested party post their
closure.

i.e., looking at gerrit, the patch list should actually get
attention,
and not be a few worth looking at, with a lot of old patches

thoughts?

Thanks,
  Itamar
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

It might helpful to have a cron-like script that checks the age of
the
posts and first notifies the sender, the reviewers and the
maintainer,
and if the patch is not updated in a certain period just abandons
it.

yep - warn after X days via email to just owner (or all subscribed
to
the patch), and close if no activity for X+14 days or something like
that.

This will be annoying.

And there are patches that pending with good reason.

pending for 60 days with zero activity on them (no comment, no rebase,
nothing)?

http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:independent_deployments,n,z

   so how does it help us to have these patches, some without any comment
   from any reviewer.
   lets get them reviewed and decide one way or the other, rather than let
   them get old and stay forever

  Again... maintainer can close these if he likes.
  Owner can close these if he likes.

 right, but why?
 a patch without activity being abandoned might actually spur someone into
 motion (rebasing and resubmitting, prodding maintainers etc).
 I'm +1 for automatically abandoning old patches.

I do not understand why maintainer should not have human interaction with its 
contributers.

  The problem is that maintainers avoid closing.
  And that there are people who submitted patches without CC anyone and gone.

  So a simple logic can be applied after we add metadata into tree:

  1. If no maintainer is CCed on change, close that change within short cycle
  (can be even a week).
  2. Maintainer to close patches that have no interest in.

Maintainers can close patches that are no interest nor progress.

Alon

  ___
  vdsm-devel mailing list
  vdsm-devel@lists.fedorahosted.org
  https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-24 Thread Ayal Baron

- Original Message -

 - Original Message -
  From: Ayal Baron aba...@redhat.com
  To: Alon Bar-Lev alo...@redhat.com
  Cc: Itamar Heim ih...@redhat.com, engine-devel
  engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
  Sent: Tuesday, September 24, 2013 12:21:23 AM
  Subject: Re: [vdsm] stale gerrit patches

  - Original Message -

   - Original Message -
From: Itamar Heim ih...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: David Caro dcaro...@redhat.com, engine-devel
engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:54:39 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:

 - Original Message -
 From: Itamar Heim ih...@redhat.com
 To: Alon Bar-Lev alo...@redhat.com
 Cc: David Caro dcaro...@redhat.com, engine-devel
 engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
 Sent: Monday, September 23, 2013 1:50:35 PM
 Subject: Re: [vdsm] stale gerrit patches

 On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

 - Original Message -
 From: Itamar Heim ih...@redhat.com
 To: David Caro dcaro...@redhat.com
 Cc: engine-devel engine-de...@ovirt.org,
 vdsm-devel@lists.fedorahosted.org
 Sent: Monday, September 23, 2013 1:47:47 PM
 Subject: Re: [vdsm] stale gerrit patches

 On 09/23/2013 01:46 PM, David Caro wrote:
 On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
 we have some very old gerrit patches.
 I'm for abandoning patches which were not touched over 60 days
 (to
 begin with, I think the number should actually be lower).
 they can always be re-opened by any interested party post their
 closure.

 i.e., looking at gerrit, the patch list should actually get
 attention,
 and not be a few worth looking at, with a lot of old patches

 thoughts?

 Thanks,
   Itamar
 ___
 vdsm-devel mailing list
 vdsm-devel@lists.fedorahosted.org
 https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

 It might helpful to have a cron-like script that checks the age
 of
 the
 posts and first notifies the sender, the reviewers and the
 maintainer,
 and if the patch is not updated in a certain period just abandons
 it.

 yep - warn after X days via email to just owner (or all subscribed
 to
 the patch), and close if no activity for X+14 days or something
 like
 that.

 This will be annoying.

 And there are patches that pending with good reason.

 pending for 60 days with zero activity on them (no comment, no
 rebase,
 nothing)?

 http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:independent_deployments,n,z

so how does it help us to have these patches, some without any comment
from any reviewer.
lets get them reviewed and decide one way or the other, rather than let
them get old and stay forever

   Again... maintainer can close these if he likes.
   Owner can close these if he likes.

  right, but why?
  a patch without activity being abandoned might actually spur someone into
  motion (rebasing and resubmitting, prodding maintainers etc).
  I'm +1 for automatically abandoning old patches.

 I do not understand why maintainer should not have human interaction with its
 contributers.

I do not understand the relation between the subject and the things you're 
saying.
Right now these patches are stale and are rotting, abandoning them could 
actually spur those interactions into motion.

   The problem is that maintainers avoid closing.
   And that there are people who submitted patches without CC anyone and
   gone.

   So a simple logic can be applied after we add metadata into tree:

   1. If no maintainer is CCed on change, close that change within short
   cycle
   (can be even a week).
   2. Maintainer to close patches that have no interest in.

 Maintainers can close patches that are no interest nor progress.

 Alon

   ___
   vdsm-devel mailing list
   vdsm-devel@lists.fedorahosted.org
   https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-24 Thread Alon Bar-Lev

- Original Message -
 From: Ayal Baron aba...@redhat.com
 To: Alon Bar-Lev alo...@redhat.com
 Cc: Itamar Heim ih...@redhat.com, engine-devel 
 engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
 Sent: Tuesday, September 24, 2013 10:09:46 AM
 Subject: Re: [vdsm] stale gerrit patches

 - Original Message -

  - Original Message -
   From: Ayal Baron aba...@redhat.com
   To: Alon Bar-Lev alo...@redhat.com
   Cc: Itamar Heim ih...@redhat.com, engine-devel
   engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
   Sent: Tuesday, September 24, 2013 9:20:55 AM
   Subject: Re: [vdsm] stale gerrit patches

   - Original Message -

- Original Message -
 From: Ayal Baron aba...@redhat.com
 To: Alon Bar-Lev alo...@redhat.com
 Cc: Itamar Heim ih...@redhat.com, engine-devel
 engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
 Sent: Tuesday, September 24, 2013 12:21:23 AM
 Subject: Re: [vdsm] stale gerrit patches

 - Original Message -

  - Original Message -
   From: Itamar Heim ih...@redhat.com
   To: Alon Bar-Lev alo...@redhat.com
   Cc: David Caro dcaro...@redhat.com, engine-devel
   engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
   Sent: Monday, September 23, 2013 1:54:39 PM
   Subject: Re: [vdsm] stale gerrit patches

   On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:

- Original Message -
From: Itamar Heim ih...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: David Caro dcaro...@redhat.com, engine-devel
engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:50:35 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

- Original Message -
From: Itamar Heim ih...@redhat.com
To: David Caro dcaro...@redhat.com
Cc: engine-devel engine-de...@ovirt.org,
vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:47:47 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:46 PM, David Caro wrote:
On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60
days
(to
begin with, I think the number should actually be lower).
they can always be re-opened by any interested party post
their
closure.

i.e., looking at gerrit, the patch list should actually
get
attention,
and not be a few worth looking at, with a lot of old
patches

thoughts?

Thanks,
  Itamar
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

It might helpful to have a cron-like script that checks the
age
of
the
posts and first notifies the sender, the reviewers and the
maintainer,
and if the patch is not updated in a certain period just
abandons
it.

yep - warn after X days via email to just owner (or all
subscribed
to
the patch), and close if no activity for X+14 days or
something
like
that.

This will be annoying.

And there are patches that pending with good reason.

pending for 60 days with zero activity on them (no comment, no
rebase,
nothing)?

http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:independent_deployments,n,z

   so how does it help us to have these patches, some without any
   comment
   from any reviewer.
   lets get them reviewed and decide one way or the other, rather
   than
   let
   them get old and stay forever

  Again... maintainer can close these if he likes.
  Owner can close these if he likes.

 right, but why?
 a patch without activity being abandoned might actually spur someone
 into
 motion (rebasing and resubmitting, prodding maintainers etc).
 I'm +1 for automatically abandoning old patches.

I do not understand why maintainer should not have human interaction
with
its
contributers.

   I do not understand the relation between the subject and the things
   you're
   saying.
   Right now these patches are stale and are rotting, abandoning them could
   actually spur those interactions into motion.

  You prefer machines to interact with contributers to kick them in motion.
  I believe

Re: [vdsm] stale gerrit patches

2013-09-24 Thread Zhou Zheng Sheng

on 2013/09/24 05:21, Ayal Baron wrote:

- Original Message -

- Original Message -
From: Itamar Heim ih...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: David Caro dcaro...@redhat.com, engine-devel
engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:54:39 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:

On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

- Original Message -
From: Itamar Heim ih...@redhat.com
To: David Caro dcaro...@redhat.com
Cc: engine-devel engine-de...@ovirt.org,
vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:47:47 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:46 PM, David Caro wrote:
On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60 days (to
begin with, I think the number should actually be lower).
they can always be re-opened by any interested party post their
closure.

i.e., looking at gerrit, the patch list should actually get
attention,
and not be a few worth looking at, with a lot of old patches

thoughts?

Thanks,
Itamar
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

It might helpful to have a cron-like script that checks the age of
the
posts and first notifies the sender, the reviewers and the
maintainer,
and if the patch is not updated in a certain period just abandons it.

yep - warn after X days via email to just owner (or all subscribed to
the patch), and close if no activity for X+14 days or something like
that.

This will be annoying.

And there are patches that pending with good reason.

pending for 60 days with zero activity on them (no comment, no rebase,
nothing)?

http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:independent_deployments,n,z

so how does it help us to have these patches, some without any comment
from any reviewer.
lets get them reviewed and decide one way or the other, rather than let
them get old and stay forever

Again... maintainer can close these if he likes.
Owner can close these if he likes.

right, but why?
a patch without activity being abandoned might actually spur someone into
motion (rebasing and resubmitting, prodding maintainers etc).
I'm +1 for automatically abandoning old patches.

At least we all agree on that old patches should be abandoned.

I think we can do this in a semi-automatic way. A cron job checks the
patch's freshness, and sends an email to warn the author and reviewers
of an old patch. If the someone has a good reason to keep the patch, he
can leave a comment on the gerrit web page saying I want to #keep the
patch# because Then the system skips the patches whose last
comment contains #keep the patch#. If no one cares it, the patch is
abandoned after some time.
--
Thanks and best regards!

Zhou Zheng Sheng / 周征晟
E-mail: zhshz...@linux.vnet.ibm.com
Telephone: 86-10-82454397

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

[vdsm] stale gerrit patches

2013-09-23 Thread Itamar Heim


we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60 days (to begin 
with, I think the number should actually be lower).

they can always be re-opened by any interested party post their closure.

i.e., looking at gerrit, the patch list should actually get attention, 
and not be a few worth looking at, with a lot of old patches


thoughts?

Thanks,
   Itamar
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-23 Thread David Caro

On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
 we have some very old gerrit patches.
 I'm for abandoning patches which were not touched over 60 days (to
 begin with, I think the number should actually be lower).
 they can always be re-opened by any interested party post their closure.

 i.e., looking at gerrit, the patch list should actually get attention,
 and not be a few worth looking at, with a lot of old patches

 thoughts?

 Thanks,
Itamar
 ___
 vdsm-devel mailing list
 vdsm-devel@lists.fedorahosted.org
 https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

It might helpful to have a cron-like script that checks the age of the 
posts and first notifies the sender, the reviewers and the maintainer, 
and if the patch is not updated in a certain period just abandons it.


--
David Caro

Red Hat Czech s.r.o.
Continuous Integration Engineer - EMEA ENG Virtualization RD

Tel.: +420 532 294 605
Email: dc...@redhat.com
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno, Czech Republic
RHT Global #: 82-62605
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-23 Thread Alon Bar-Lev

- Original Message -
 From: Itamar Heim ih...@redhat.com
 To: David Caro dcaro...@redhat.com
 Cc: engine-devel engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
 Sent: Monday, September 23, 2013 1:47:47 PM
 Subject: Re: [vdsm] stale gerrit patches

 On 09/23/2013 01:46 PM, David Caro wrote:
  On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
  we have some very old gerrit patches.
  I'm for abandoning patches which were not touched over 60 days (to
  begin with, I think the number should actually be lower).
  they can always be re-opened by any interested party post their closure.

  i.e., looking at gerrit, the patch list should actually get attention,
  and not be a few worth looking at, with a lot of old patches

  thoughts?

  Thanks,
  Itamar
  ___
  vdsm-devel mailing list
  vdsm-devel@lists.fedorahosted.org
  https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

  It might helpful to have a cron-like script that checks the age of the
  posts and first notifies the sender, the reviewers and the maintainer,
  and if the patch is not updated in a certain period just abandons it.

 yep - warn after X days via email to just owner (or all subscribed to
 the patch), and close if no activity for X+14 days or something like that.

This will be annoying.

And there are patches that pending with good reason.

Maintainers can close patches that are no interest nor progress.

Alon
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-23 Thread Itamar Heim

On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

- Original Message -

From: Itamar Heim ih...@redhat.com
To: David Caro dcaro...@redhat.com
Cc: engine-devel engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:47:47 PM
Subject: Re: [vdsm] stale gerrit patches

On 09/23/2013 01:46 PM, David Caro wrote:

On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:

we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60 days (to
begin with, I think the number should actually be lower).
they can always be re-opened by any interested party post their closure.

i.e., looking at gerrit, the patch list should actually get attention,
and not be a few worth looking at, with a lot of old patches

thoughts?

Thanks,
 Itamar
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

It might helpful to have a cron-like script that checks the age of the
posts and first notifies the sender, the reviewers and the maintainer,
and if the patch is not updated in a certain period just abandons it.

yep - warn after X days via email to just owner (or all subscribed to
the patch), and close if no activity for X+14 days or something like that.

This will be annoying.

And there are patches that pending with good reason.

pending for 60 days with zero activity on them (no comment, no rebase, 
nothing)?

Maintainers can close patches that are no interest nor progress.

Alon

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-23 Thread Alon Bar-Lev

- Original Message -
 From: Itamar Heim ih...@redhat.com
 To: Alon Bar-Lev alo...@redhat.com
 Cc: David Caro dcaro...@redhat.com, engine-devel 
 engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
 Sent: Monday, September 23, 2013 1:50:35 PM
 Subject: Re: [vdsm] stale gerrit patches

 On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

  - Original Message -
  From: Itamar Heim ih...@redhat.com
  To: David Caro dcaro...@redhat.com
  Cc: engine-devel engine-de...@ovirt.org,
  vdsm-devel@lists.fedorahosted.org
  Sent: Monday, September 23, 2013 1:47:47 PM
  Subject: Re: [vdsm] stale gerrit patches

  On 09/23/2013 01:46 PM, David Caro wrote:
  On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
  we have some very old gerrit patches.
  I'm for abandoning patches which were not touched over 60 days (to
  begin with, I think the number should actually be lower).
  they can always be re-opened by any interested party post their closure.

  i.e., looking at gerrit, the patch list should actually get attention,
  and not be a few worth looking at, with a lot of old patches

  thoughts?

  Thanks,
   Itamar
  ___
  vdsm-devel mailing list
  vdsm-devel@lists.fedorahosted.org
  https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

  It might helpful to have a cron-like script that checks the age of the
  posts and first notifies the sender, the reviewers and the maintainer,
  and if the patch is not updated in a certain period just abandons it.

  yep - warn after X days via email to just owner (or all subscribed to
  the patch), and close if no activity for X+14 days or something like that.

  This will be annoying.

  And there are patches that pending with good reason.

 pending for 60 days with zero activity on them (no comment, no rebase,
 nothing)?

http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:independent_deployments,n,z

  Maintainers can close patches that are no interest nor progress.

  Alon

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-23 Thread Alon Bar-Lev

- Original Message -
 From: Alon Bar-Lev alo...@redhat.com
 To: Itamar Heim ih...@redhat.com
 Cc: David Caro dcaro...@redhat.com, engine-devel 
 engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
 Sent: Monday, September 23, 2013 1:52:56 PM
 Subject: Re: [vdsm] stale gerrit patches

 - Original Message -
  From: Itamar Heim ih...@redhat.com
  To: Alon Bar-Lev alo...@redhat.com
  Cc: David Caro dcaro...@redhat.com, engine-devel
  engine-de...@ovirt.org, vdsm-devel@lists.fedorahosted.org
  Sent: Monday, September 23, 2013 1:50:35 PM
  Subject: Re: [vdsm] stale gerrit patches

  On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

   - Original Message -
   From: Itamar Heim ih...@redhat.com
   To: David Caro dcaro...@redhat.com
   Cc: engine-devel engine-de...@ovirt.org,
   vdsm-devel@lists.fedorahosted.org
   Sent: Monday, September 23, 2013 1:47:47 PM
   Subject: Re: [vdsm] stale gerrit patches

   On 09/23/2013 01:46 PM, David Caro wrote:
   On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
   we have some very old gerrit patches.
   I'm for abandoning patches which were not touched over 60 days (to
   begin with, I think the number should actually be lower).
   they can always be re-opened by any interested party post their
   closure.

   i.e., looking at gerrit, the patch list should actually get attention,
   and not be a few worth looking at, with a lot of old patches

   thoughts?

   Thanks,
Itamar
   ___
   vdsm-devel mailing list
   vdsm-devel@lists.fedorahosted.org
   https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

   It might helpful to have a cron-like script that checks the age of the
   posts and first notifies the sender, the reviewers and the maintainer,
   and if the patch is not updated in a certain period just abandons it.

   yep - warn after X days via email to just owner (or all subscribed to
   the patch), and close if no activity for X+14 days or something like
   that.

   This will be annoying.

   And there are patches that pending with good reason.

  pending for 60 days with zero activity on them (no comment, no rebase,
  nothing)?

 http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:independent_deployments,n,z

http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:ldap_independence,n,z

   Maintainers can close patches that are no interest nor progress.

   Alon

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-23 Thread Alon Bar-Lev

On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:

On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:

i.e., looking at gerrit, the patch list should actually get attention,
and not be a few worth looking at, with a lot of old patches

thoughts?

Thanks,
Itamar
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

It might helpful to have a cron-like script that checks the age of the
posts and first notifies the sender, the reviewers and the maintainer,
and if the patch is not updated in a certain period just abandons it.

yep - warn after X days via email to just owner (or all subscribed to
the patch), and close if no activity for X+14 days or something like
that.

This will be annoying.

And there are patches that pending with good reason.

pending for 60 days with zero activity on them (no comment, no rebase,
nothing)?

http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:independent_deployments,n,z

so how does it help us to have these patches, some without any comment
from any reviewer.
lets get them reviewed and decide one way or the other, rather than let
them get old and stay forever

Again... maintainer can close these if he likes.
Owner can close these if he likes.

The problem is that maintainers avoid closing.
And that there are people who submitted patches without CC anyone and gone.

So a simple logic can be applied after we add metadata into tree:

1. If no maintainer is CCed on change, close that change within short cycle
(can be even a week).
2. Maintainer to close patches that have no interest in.

Maintainers can close patches that are no interest nor progress.

Alon

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] stale gerrit patches

2013-09-23 Thread Ayal Baron