Re: [vdsm] gerrit problem when reviewing VDSM code
On 08/05/12 09:23, Itamar Heim wrote: > On 05/08/2012 09:03 AM, Shu Ming wrote: >> On 2012-5-8 13:24, Itamar Heim wrote: >>> On 05/08/2012 04:50 AM, Shu Ming wrote: Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? >>> >>> just changed in gerrit the context to show you 'whole file' rather >>> than '10 lines'? >>> >> Yes. 10 lines don't have much meaning to the people not familiar with >> the file, but still have an interesting to review the code. More context >> will help them to review the code without patching the diffs into the >> original file. >> > > sorry if i wasn't clear - the change is something you can do when viewing the > patch, not a general change. > See the attached; 1. Change the context as you wish. 2. Push the update button. This will remain as your default until you change it. -- /d "Air conditioned environment - Do NOT open Windows!" <>___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] gerrit problem when reviewing VDSM code
On 05/08/2012 08:24 AM, Itamar Heim wrote: On 05/08/2012 04:50 AM, Shu Ming wrote: Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? just changed in gerrit the context to show you 'whole file' rather than '10 lines'? this should have read "just change...", it is a user level change. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] gerrit problem when reviewing VDSM code
On 05/08/2012 09:03 AM, Shu Ming wrote: On 2012-5-8 13:24, Itamar Heim wrote: On 05/08/2012 04:50 AM, Shu Ming wrote: Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? just changed in gerrit the context to show you 'whole file' rather than '10 lines'? Yes. 10 lines don't have much meaning to the people not familiar with the file, but still have an interesting to review the code. More context will help them to review the code without patching the diffs into the original file. sorry if i wasn't clear - the change is something you can do when viewing the patch, not a general change. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] gerrit problem when reviewing VDSM code
On 2012-5-8 13:24, Itamar Heim wrote: On 05/08/2012 04:50 AM, Shu Ming wrote: Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? just changed in gerrit the context to show you 'whole file' rather than '10 lines'? Yes. 10 lines don't have much meaning to the people not familiar with the file, but still have an interesting to review the code. More context will help them to review the code without patching the diffs into the original file. -- Shu Ming IBM China Systems and Technology Laboratory ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] gerrit problem when reviewing VDSM code
On 05/08/2012 04:50 AM, Shu Ming wrote: Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? just changed in gerrit the context to show you 'whole file' rather than '10 lines'? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] gerrit problem when reviewing VDSM code
Hi, In my reviewing patches in gerrit for VDSM code, I found it was a bit awkward to understand the diffs without much context above or below the diffs. I hope I can read the unchanged lines around the diffs to get more information. The unchanged lines should be in folding state when I don't care about them and can be unfolded when I need more information. What do you think about this? -- Shu Ming IBM China Systems and Technology Laboratory ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel